EDIT

the selection as candidate or target is not possible, the menu items are not enabled.
and the details view does not show up.
the menu items are not correct, for example there are menu items like "change to person" for references

Katja Luther wrote:

this works fine now

maybe one minor issue: when set a multi selection as deduptlication candidate, the marker is not shown before changing the selection, this is a little bit confusing.

This works for me. I select two elements, right-click "Set as candidate" and the marker appears in the label

Can we have left alignment instead of center alignment. Especially for the titleCache columns this is easier to read.

For focus loss after save see #6321#note-23

Can we remove the "Sort by" field (see attachment above)? It think it is not in use in all/most bulk editors.

Instead it would be nice and very helpful to enable sorting by columns in the NAT tables.
And of course it would be nice to allow more columns such as further cache fields,id, uuid, created, updated,... which can also be used for sorting (but this might be a new ticket)

Adding a marker does not update the "+" in supplemental data view. Maybe this is not related to NAT.

Copying parts of the titleCache within the table is not possible. This is a regression compared to the old table.

Can we make cells "editable" in the sense that it is possible to select (and copy) parts of the text but at same time not make it possible to change data in the field? This is how it was before.

Copying always copies the titlecache column value even if the other column has the focus. For now this might be acceptable as we have only one important column but may change once we have multiple columns with information that users may want to copy.
This may become irrelevant once the above issue #7439#note-14 is implemented.

If the whole row has the focus we may want to copy all fields in csv or tsv format.

"Copy" is not yet translated to German.

For multi-select copy is not yet possible but might be a very nice feature (e.g. for copy and paste larger datasets to Excel). Feel free to create a new ticket as this is a new feature.

Comment #7439#note-7: Cell text is left aligned
Comment #7439#note-11: I can reproduce this as well when opening the third editor. Question: Do we really want to allow opening the same type of bulk editor multiple times?
Comment #7439#note-12: Enabled sorting (Please open a new ticket specifying which additional columns should be present)
Comment #7439#note-13: Could not reproduce this behavior. Which bulk editor did you use? On which element did you test this?

Patrick Plitzner wrote:

Comment #7439#note-11: I can reproduce this as well when opening the third editor. Question: Do we really want to allow opening the same type of bulk editor multiple times?

Sure. Searching for "B*" is different from "A*". One may want to have open both for various reasons.

Also the problem is not necessarily related to opening multiple editors. But this is how you can easily reproduce the behavior.

Patrick Plitzner wrote:

Comment #7439#note-13: Could not reproduce this behavior. Which bulk editor did you use? On which element did you test this?

No matter which bulk editor. Just take any name, taxon, reference or author (...) without a marker => no + shows up in supplemental data view beside marker.
Add a marker via bulk editor. Still no + shows up (but should).

Andreas Müller wrote:

Copying parts of the titleCache within the table is not possible. This is a regression compared to the old table.

Can we make cells "editable" in the sense that it is possible to select (and copy) parts of the text but at same time not make it possible to change data in the field? This is how it was before.

By the way, changing data within the columns may become an option now. E.g. changing the specific epithet of a name might be more comfortable to do within the table then within the details view as the workflow is probably faster if you go through a long list of names.
It was no option as long as only the titleCache was shown. Editing the titleCache should still only be possible if the cache is protected (same as in details view). Should we open a new ticket for editing fields (this is also related to #7502)

Patrick Plitzner wrote:

Comment #7439#note-12: Enabled sorting (Please open a new ticket specifying which additional columns should be present)

Great! But there is a problem now. If sorting is e.g. DESC on titleCache, reloading (#6321) should take place in the same order.

Comment #7439#note-9: Focus loss is fixed
Comment #7439#note-11: Rendering problem is fixed
Comment #7439#note-12: Removed sort combo
Comment #7439#note-14: Cell text can be selected but not edited
Comment #7439#note-16: new ticket #7507
Comment #7439#note-17: i18n for "copy"
Comment #7439#note-18: new ticket #7507
Comment #7439#note-23: This is fixed but other issue occured (#7504)
Comment #7439#note-25: new ticket #7506

Having the markers for deduplication (target, candidate) in the text fields is not very comfortable and scalable. When we have multiple columns and users change the order of the columns the order gets lost. Also editing the columns (#7503) will not be possible anymore.
Is there no other possibility to add markers rows in NAT tables? If not we should create a new column which then handles the deduplication information seperately (preferably with a 3 state icon - none, target, candidate).

Changing the text in a cell for now should not be possible until #7503 is implemented. If NAT tables don't offer such a state we could probably catch the change events and handle them such that the text does not change.

Andreas Müller wrote:

Having the markers for deduplication (target, candidate) in the text fields is not very comfortable and scalable. When we have multiple columns and users change the order of the columns the order gets lost. Also editing the columns (#7503) will not be possible anymore.
Is there no other possibility to add markers rows in NAT tables? If not we should create a new column which then handles the deduplication information seperately (preferably with a 3 state icon - none, target, candidate).

We decided to use row colors instead. Additionally offering tooltips saying that a row is target or candidate for deduplication.

Andreas Müller wrote:

Using the standard right click menu is cumbersome as clicking on a column cell immediately changes the cell into the editing mode with a less comfortable menu:

We had the same discussion when introducing the standard tables for bulk editor. Please refer to that discussion for details. Generally we need to go to editing mode only by double click. And even better we should not show the above menu in editing mode but a more suitable one.

This is release critical.

Now, the editing mode shows the standard menu but in many cases no menu appears at all when doing some kind of right click on the table. This is very critical. Maybe we better revert everything related to editing mode.

Now, column resizing is disabled which is better then before. However, we should resize the table to window size at the beginning when opening the bulk editor.

The editing mode of the table caused a widget is disposed exception and no menu was shown.
I reverted these changes and the resizing.