Project

General

Profile

Actions
Copy link

feature request #7413

closed

Make in-Authors editable in TaxEditor for zoological and fungi names

Added by Andreas Müller almost 6 years ago. Updated 3 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Katja Luther
Category:
taxeditor
Target version:
Release 5.42
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Tags:
edapho

Description

This includes inCombinationAuthor and inBasionymAuthor (but call the later "original name author" or so, as basionym does not exist in zoology)

Files

clipboard-202401161347-gxtsf.png (23.9 KB) clipboard-202401161347-gxtsf.png Andreas Müller, 01/16/2024 01:47 PM

Related issues

Related to EDIT - feature request #7443: Implement in-authors in name parser and formatter for zoological and fungi namesClosedAndreas Müller

Actions
Related to EDIT - task #10432: Cora importResolvedAndreas Müller

Actions
Follows EDIT - feature request #6943: Allow zoological in-Authors in taxon namesClosedAndreas Müller

Actions
Actions
Copy link
 #1

Updated by Andreas Müller almost 6 years ago

  • Due date set to 09/14/2017
  • Start date changed from 05/14/2018 to 09/14/2017
  • Follows feature request #6943: Allow zoological in-Authors in taxon names added
Actions
Copy link
 #2

Updated by Andreas Müller almost 6 years ago

  • Target version changed from Release 5.0 to Release 5.1
Actions
Copy link
 #3

Updated by Andreas Müller almost 6 years ago

  • Related to feature request #7443: Implement in-authors in name parser and formatter for zoological and fungi names added
Actions
Copy link
 #4

Updated by Andreas Müller almost 6 years ago

  • Target version changed from Release 5.1 to Release 5.2
Actions
Copy link
 #5

Updated by Andreas Müller over 5 years ago

  • Target version changed from Release 5.2 to Release 5.3
Actions
Copy link
 #6

Updated by Katja Luther over 5 years ago

  • Target version changed from Release 5.3 to Release 5.4
Actions
Copy link
 #7

Updated by Andreas Müller over 5 years ago

  • Due date deleted (09/14/2017)
  • Priority changed from New to Highest
Actions
Copy link
 #8

Updated by Andreas Müller over 5 years ago

  • Target version changed from Release 5.4 to Release 5.5
Actions
Copy link
 #9

Updated by Andreas Müller about 5 years ago

  • Target version changed from Release 5.5 to Release 5.6
Actions
Copy link
 #10

Updated by Andreas Müller about 5 years ago

  • Target version changed from Release 5.6 to Reviewed Next Major Release
Actions
Copy link
 #11

Updated by Andreas Müller 5 months ago

  • Subject changed from Make zoological inAuthors editable in TaxEditor to Make in-Authors editable in TaxEditor for zoological and fungi names
  • Target version changed from Reviewed Next Major Release to Release 5.42
Actions
Copy link
 #12

Updated by Andreas Müller 5 months ago

Actions
Copy link
 #13

Updated by Katja Luther 5 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

The text fields are added to the name details view and I also added it to the name details view preference because most of the users will not need the in-authors.

Please review.

Actions
Copy link
 #14

Updated by Andreas Müller 4 months ago

  • % Done changed from 0 to 60

In a next step we will discuss with users if this is really only relevant for fungi and animals.

Actions
Copy link
 #15

Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

in-Authors can be edited now, but are not saved to the DB.

Actions
Copy link
 #16

Updated by Andreas Müller 3 months ago

in-authors are shown independent of the preference and of the nom. code now. For now it should be shown only if nom. code is Fungus or ICZ.

Actions
Copy link
 #17

Updated by Katja Luther 3 months ago

  • Assignee changed from Katja Luther to Andreas Müller

If the preference is set then you have to reload the details view. The saving should be fixed for InCombinationAuthor, but there is a method setInBasionymAuthorship missing!
Should I add it or do you add it?

Actions
Copy link
 #18

Updated by Andreas Müller 3 months ago

Katja Luther wrote in #note-17:

If the preference is set then you have to reload the details view. The saving should be fixed for InCombinationAuthor, but there is a method setInBasionymAuthorship missing!
Should I add it or do you add it?

The method is already there. Line 1020.

Actions
Copy link
 #19

Updated by Andreas Müller 3 months ago

  • Assignee changed from Andreas Müller to Katja Luther
Actions
Copy link
 #20

Updated by Andreas Müller 3 months ago

Katja Luther wrote in #note-17:

If the preference is set then you have to reload the details view. The saving should be fixed for InCombinationAuthor, but there is a method setInBasionymAuthorship missing!
Should I add it or do you add it?

Reloading does not help. Even restarting the TaxEditor and opening a completely different taxon shows all the authors including in-authors, though the preferences was deselected an the taxon had the nom. code ICNAFP.

Actions
Copy link
 #21

Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

This should be fixed with the last commits. Please review.

Actions
Copy link
 #22

Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

The basionym in-author is still not saved or handled (you did not find the method but it exists).

Actions
Copy link
 #23

Updated by Andreas Müller 3 months ago

How far is the preference used at all. To me it seems that it has no effect. If so we should remove it.

Actions
Copy link
 #24

Updated by Katja Luther 3 months ago

Andreas Müller wrote in #note-22:

The basionym in-author is still not saved or handled (you did not find the method but it exists).

I moved all "inAuthor-methods" to INonViralName because also Fungus names can have in-authors

Actions
Copy link
 #25

Updated by Katja Luther 3 months ago

Andreas Müller wrote in #note-23:

How far is the preference used at all. To me it seems that it has no effect. If so we should remove it.

It is checked which NC the name belongs to and whether the preference is set, if the preference is set and the NC is zoological or fungus, the in-author fields are shown.

Actions
Copy link
 #26

Updated by Andreas Müller 3 months ago

Katja Luther wrote in #note-25:

Andreas Müller wrote in #note-23:

How far is the preference used at all. To me it seems that it has no effect. If so we should remove it.

It is checked which NC the name belongs to and whether the preference is set, if the preference is set and the NC is zoological or fungus, the in-author fields are shown.

No, it is also shown, if NC is fungus/zoo and the preference is not set. Therefore I asked.

Actions
Copy link
 #27

Updated by Andreas Müller 3 months ago

Andreas Müller wrote in #note-26:

Katja Luther wrote in #note-25:

Andreas Müller wrote in #note-23:

How far is the preference used at all. To me it seems that it has no effect. If so we should remove it.

It is checked which NC the name belongs to and whether the preference is set, if the preference is set and the NC is zoological or fungus, the in-author fields are shown.

No, it is also shown, if NC is fungus/zoo and the preference is not set. Therefore I asked.

Works now.

Actions
Copy link
 #28

Updated by Andreas Müller 3 months ago

Andreas Müller wrote in #note-22:

The basionym in-author is still not saved or handled (you did not find the method but it exists).

This still seems to be open.

Actions
Copy link
 #29

Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote in #note-28:

Andreas Müller wrote in #note-22:

The basionym in-author is still not saved or handled (you did not find the method but it exists).

This still seems to be open.

Now it is fixed.

Actions
Copy link
 #30

Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 60 to 100

works as expected now

Actions
Copy link
 #31

Updated by Andreas Müller 3 months ago

  • Assignee changed from Andreas Müller to Katja Luther
Actions
Copy link

Also available in: Atom PDF