Project

General

Profile

Actions

feature request #7345

closed

[E+M] Common name references selectable in TaxEditor

Added by Andreas Müller almost 5 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
2:00 h
Severity:
normal
Tags:

Description

In Euro+Med Berlin Model references for common names are handled separately from other references but do link to them (optional). In CDM we do not want to keep them separate but they should be flagged somehow as Common Name references.

There are multiple ways to do so:

  • Add a marker "Reference for Common Names" and mark all relevant references with this marker
  • Make the list of common name references a CdmPreference and/or a local preference
  • Implement on model level by adding something like supportsXXX for references to indicate in which context a certain reference might be used. Something also discussed for nomenclatural references.

Additionally in Berlin Model the references do have 1 or more languages attached to make them easier searchable(?) in certain contexts. This does not yet exist in CDM. We need to discuss if it is really needed.


Related issues

Follows EDIT - feature request #7440: E+M mark common name reference with according markerClosedAndreas Müller

Actions
Actions #1

Updated by Andreas Müller almost 5 years ago

  • Description updated (diff)
Actions #2

Updated by Andreas Müller over 4 years ago

  • Priority changed from New to Priority14
  • Estimated time set to 2:00 h
Actions #3

Updated by Andreas Müller over 4 years ago

  • Description updated (diff)

Decision for migration: We implement the marker solution.

Actions #4

Updated by Andreas Müller over 4 years ago

Actions #5

Updated by Katja Luther over 4 years ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
  • Target version changed from Euro+Med Migration to Release 5.4

added a new markerType 'common name reference' and everytime a reference is added as source reference a marker of this type is added if the reference not already has a merker of this type.

for review the server needs to be restarted because of the new markertype

Actions #6

Updated by Katja Luther over 4 years ago

now the selection dialog searches only for references with marker of markerType commonNameReference and when creating a new Reference from this selection dialog the marker is added.

Actions #7

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • Priority changed from Priority14 to Highest

The PreferencePredicate still seems to be missing so I can't review and functionality is not yet there.

If UI implementation for admin prefs is not possible in 5.4 it would be good (for E+M) to at least be able to read it from DB preferences

Actions #8

Updated by Andreas Müller over 4 years ago

  • % Done changed from 0 to 20
Actions #9

Updated by Katja Luther over 4 years ago

now there is a cdmPreference CommonNameReferencesWithMarker which can be set to true, if the selection dialog should filter by the commonNameReferenceMarker

Actions #10

Updated by Andreas Müller about 4 years ago

Can you add openIssues to the ticket, so we remember what is still missing. Or is it already fully solved and can be put to "resolved"? Or are most parts missing and we should move it to 5.5.

Actions #11

Updated by Katja Luther about 2 years ago

  • Status changed from Feedback to Resolved

this seems to be fixed, the preference is available and activate and deactivate the filtering for common name references works as expected.

Actions #12

Updated by Andreas Müller about 2 years ago

Actions #13

Updated by Andreas Müller about 2 years ago

  • Due date set to 05/29/2018
  • Start date changed from 04/05/2018 to 05/29/2018
  • Follows feature request #7440: E+M mark common name reference with according marker added
Actions #14

Updated by Andreas Müller about 2 years ago

  • Due date deleted (05/29/2018)
Actions #15

Updated by Andreas Müller about 2 years ago

  • Assignee changed from Katja Luther to Andreas Müller
Actions #16

Updated by Andreas Müller about 2 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 20 to 100

I think this works and can be closed.

Actions

Also available in: Atom PDF