Project

General

Profile

Actions

task #7325

closed

Taxeditor uses CdmTransientEntityCacher from cdmlib-cache

Added by Andreas Kohlbecker almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

By solving #7206 the CdmTransientEntityCacher has been moved from the taxeditor project into a new cdmlib module.

The Taxeditor now needs to be adapted so that it also uses the Cacher provided by the new package.


Related issues

Related to EDIT - bug #7206: CdmEntityCache not correctly updating with entitiy graphs loaded afterwardsClosedAndreas Kohlbecker

Actions
Actions #1

Updated by Andreas Kohlbecker almost 5 years ago

  • Related to bug #7206: CdmEntityCache not correctly updating with entitiy graphs loaded afterwards added
Actions #2

Updated by Andreas Kohlbecker almost 5 years ago

Hallo Katja,

das sollte relativ einfach sein:

  1. Subclass von CdmTransientEntityCacher: Zb: ConversationalTransientEntityCacher, Diese klasse implemntiert dann all die Methoden die im CdmTransientEntityCacher auskommentiert wurden.
  2. Alle Klassen die in eu.etaxonomy.cdm.cache vorkommen im editor löschen.

Viele Grüße
Andreas

Actions #3

Updated by Andreas Müller almost 5 years ago

  • Description updated (diff)
Actions #4

Updated by Andreas Müller almost 5 years ago

  • Status changed from New to Resolved
  • Assignee changed from Andreas Müller to Andreas Kohlbecker
Actions #5

Updated by Andreas Kohlbecker almost 5 years ago

  • Description updated (diff)
  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Kohlbecker to Katja Luther
  • Priority changed from New to Highest
  • % Done changed from 0 to 50

Hi Katja,

I did reviewing your changes.

All Classes which have moved to cdmlib-cache are removed from the taxeditor. And the switch to the classes now provided by the cdmlib-cache package looks clean and ok. Since the integration tests are all running successful I consider this taks as completed.

Andreas

Actions #6

Updated by Andreas Kohlbecker almost 5 years ago

  • Description updated (diff)
Actions #7

Updated by Andreas Kohlbecker almost 5 years ago

  • Status changed from Closed to In Progress

I just discovered that at least one changeset from the taxeditor project (taxeditor|98baf5f8 ) which fixed a bug #6389 has not yet been incorporated into cdmlib-cache. This is of course also one of the tasks to accomplish for this issue.

all changes since Fri Jan 19 17:23:04 2018 +0100 need to be considered being a candidate to patch over cdmlib-cache
Theses are:

* 98baf5f - Tue, 27 Feb 2018 14:30:33 +0100 (3 weeks ago)
|   fix #6389 Fixed cache loader method - Patrick Plitzner
* e25b303 - Wed, 24 Jan 2018 14:46:03 +0100 (8 weeks ago)
|   quick fix for #7212 in taxeditor - Katja Luther
Actions #8

Updated by Andreas Kohlbecker almost 5 years ago

I cared for taxeditor|98baf5f ( #6389 )

Actions #9

Updated by Katja Luther almost 5 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Kohlbecker

taxeditor|e25b303 ( #7212 ) seems to be already in cdmlib. I think we can close this ticket. please review if you think everything is ok.

Actions #10

Updated by Andreas Kohlbecker over 4 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Kohlbecker to Katja Luther
  • % Done changed from 50 to 100

looks ok now!

Actions

Also available in: Atom PDF