Project

General

Profile

task #7325

Taxeditor uses CdmTransientEntityCacher from cdmlib-cache

Added by Andreas Kohlbecker 9 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
03/22/2018
Due date:
% Done:

100%

Severity:
normal

Description

By solving #7206 the CdmTransientEntityCacher has been moved from the taxeditor project into a new cdmlib module.

The Taxeditor now needs to be adapted so that it also uses the Cacher provided by the new package.


Related issues

Related to Edit - bug #7206: CdmEntityCache not correctly updating with entitiy graphs loaded afterwards Closed 01/18/2018

Associated revisions

Revision f4cc04f2 (diff)
Added by Katja Luther 9 months ago

adapt taxeditor cache to cdmlib-cache

Revision 4b5b85e0 (diff)
Added by Katja Luther 9 months ago

adapt tests to cdmlib-cache

Revision 3fd86b55 (diff)
Added by Katja Luther 9 months ago

missing test adaption for cdmlib-cache

Revision 6034c463 (diff)
Added by Katja Luther 9 months ago

fix using correct cache

Revision 1c9d09b9 (diff)
Added by Andreas Kohlbecker 9 months ago

ref #7325 applying taxeditor changeset (98baf5f ref #6389) onto cdmlib-cache

History

#1 Updated by Andreas Kohlbecker 9 months ago

  • Related to bug #7206: CdmEntityCache not correctly updating with entitiy graphs loaded afterwards added

#2 Updated by Andreas Kohlbecker 9 months ago

Hallo Katja,

das sollte relativ einfach sein:

  1. Subclass von CdmTransientEntityCacher: Zb: ConversationalTransientEntityCacher, Diese klasse implemntiert dann all die Methoden die im CdmTransientEntityCacher auskommentiert wurden.
  2. Alle Klassen die in eu.etaxonomy.cdm.cache vorkommen im editor löschen.

Viele Grüße
Andreas

#3 Updated by Andreas Müller 9 months ago

  • Description updated (diff)

#4 Updated by Andreas Müller 9 months ago

  • Status changed from New to Resolved
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

#5 Updated by Andreas Kohlbecker 9 months ago

  • Description updated (diff)
  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Kohlbecker to Katja Luther
  • Priority changed from New to Highest
  • % Done changed from 0 to 50

Hi Katja,

I did reviewing your changes.

All Classes which have moved to cdmlib-cache are removed from the taxeditor. And the switch to the classes now provided by the cdmlib-cache package looks clean and ok. Since the integration tests are all running successful I consider this taks as completed.

Andreas

#6 Updated by Andreas Kohlbecker 9 months ago

  • Description updated (diff)

#7 Updated by Andreas Kohlbecker 9 months ago

  • Status changed from Closed to In Progress

I just discovered that at least one changeset from the taxeditor project (taxeditor|98baf5f8 ) which fixed a bug #6389 has not yet been incorporated into cdmlib-cache. This is of course also one of the tasks to accomplish for this issue.

all changes since Fri Jan 19 17:23:04 2018 +0100 need to be considered being a candidate to patch over cdmlib-cache
Theses are:

* 98baf5f - Tue, 27 Feb 2018 14:30:33 +0100 (3 weeks ago)
|   fix #6389 Fixed cache loader method - Patrick Plitzner
* e25b303 - Wed, 24 Jan 2018 14:46:03 +0100 (8 weeks ago)
|   quick fix for #7212 in taxeditor - Katja Luther

#8 Updated by Andreas Kohlbecker 9 months ago

I cared for taxeditor|98baf5f ( #6389 )

#9 Updated by Katja Luther 8 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Kohlbecker

taxeditor|e25b303 ( #7212 ) seems to be already in cdmlib. I think we can close this ticket. please review if you think everything is ok.

#10 Updated by Andreas Kohlbecker 7 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Kohlbecker to Katja Luther
  • % Done changed from 50 to 100

looks ok now!

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)