Project

General

Profile

feature request #7309

Implement collectorTitle and collectorTitleCache and the same for nomenclatural title in tax editor

Added by Katja Luther over 3 years ago. Updated 4 months ago.

Status:
Feedback
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
03/12/2018
Due date:
% Done:

90%

Severity:
normal

Description

Teams and persons in future will have the field collectorTitleCache. Additionally Person will have a field collectorTitle and Team a field protectedCollectorTitleCache.

So for Person we need an ordinary text field collectorTitle while for Team we need an ordinary cache field collectorTitleCache including protectedXXX functionality like for any other cache field.
For Person the result of the collectorTitleCache field should only be displayed but not be editable.

Exactly the same we need for nomenclaturalTitle, nomencalturalTitleCache and protectedNomenclaturalTitleCache.


Related issues

Related to Edit - feature request #4311: Improve person representation in CDM Closed 02/09/2018
Related to Edit - feature request #7178: implement collectorTitleCache in TeamOrPersonField (vaadin) New 02/12/2018
Related to Edit - feature request #9680: Show collectorTitleCache and protectedCollectorTitleCache+ protectedNomenclaturalTitleCache in BulkEditor Closed 06/25/2021

Associated revisions

Revision 8f1f6888 (diff)
Added by Katja Luther 4 months ago

ref #7309: add collectorTitle/titleCache to editor

Revision e033750b (diff)
Added by Katja Luther 4 months ago

ref #7309: add collectorTitle/titleCache to editor - continue

Revision c9e207d1 (diff)
Added by Katja Luther 4 months ago

fix updateCaches - do not set nomenclaturalTitle but nomenclaturalTitleCache

Revision 9ef89740 (diff)
Added by Katja Luther 4 months ago

ref #7309: collector and nomenclatural title fields show cache if empty

Revision 3645336f (diff)
Added by Katja Luther 4 months ago

ref #7309: avoid CCE

History

#1 Updated by Katja Luther over 3 years ago

#2 Updated by Andreas Müller over 3 years ago

#3 Updated by Andreas Kohlbecker over 3 years ago

  • Blocked by deleted (feature request #7178: implement collectorTitleCache in TeamOrPersonField (vaadin))

#4 Updated by Andreas Kohlbecker over 3 years ago

#5 Updated by Andreas Müller over 3 years ago

  • Target version changed from Release 5.0 to Release 5.1

#6 Updated by Andreas Müller over 3 years ago

  • Target version changed from Release 5.1 to Release 5.2

#7 Updated by Andreas Müller about 3 years ago

  • Target version changed from Release 5.2 to Release 5.3

#8 Updated by Katja Luther about 3 years ago

  • Target version changed from Release 5.3 to Release 5.4

#9 Updated by Andreas Müller almost 3 years ago

  • Target version changed from Release 5.4 to Release 5.5

#10 Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 5.5 to Release 5.6

#11 Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 5.6 to Reviewed Next Major Release

#12 Updated by Andreas Müller 4 months ago

  • Priority changed from Priority14 to Highest
  • Target version changed from Reviewed Next Major Release to Release 5.25

I will implement the update script now so we also need the fields in taxeditor

#13 Updated by Andreas Müller 4 months ago

  • Subject changed from Implement collector titlecache in tax editor to Implement collectorTitle and collectorTitleCache and the same for nomenclatural title in tax editor
  • Description updated (diff)

#14 Updated by Katja Luther 4 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

This should be implemented now, please review.

#15 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 50

For Person the result of the collectorTitleCache field should only be displayed but not be editable.

This still seems to be missing. We either need a separate field or label here or we could show the text in the "background" of the given field (like sometimes usage hints are shown in empty fields) as long as the field is not yet filled with any text. I don't know if this is possible in RCP, if yes, this might be the preferred solution as it keeps the UI simple.

#16 Updated by Andreas Müller 4 months ago

  • Related to feature request #9680: Show collectorTitleCache and protectedCollectorTitleCache+ protectedNomenclaturalTitleCache in BulkEditor added

#17 Updated by Katja Luther 4 months ago

Andreas Müller wrote:

For Person the result of the collectorTitleCache field should only be displayed but not be editable.

This still seems to be missing. We either need a separate field or label here or we could show the text in the "background" of the given field (like sometimes usage hints are shown in empty fields) as long as the field is not yet filled with any text. I don't know if this is possible in RCP, if yes, this might be the preferred solution as it keeps the UI simple.

this is implemented now, also for nomenclatural title(cache)

#18 Updated by Katja Luther 4 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

#19 Updated by Andreas Müller 4 months ago

It seems to work now.

However, there is another problem now. The protect button is disabled for all titleCache fields if the cache is not protected. This is the case not only for persons but for all xxxCache fields in Details View.
Maybe this is related to changes in #9287

#20 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

#21 Updated by Katja Luther 4 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

It seems to work now.

However, there is another problem now. The protect button is disabled for all titleCache fields if the cache is not protected. This is the case not only for persons but for all xxxCache fields in Details View.
Maybe this is related to changes in #9287

this is fixed. Please have a look whether all toggleable text fields are fixed.

#22 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 100

Works as expected now

#23 Updated by Andreas Müller 4 months ago

  • Status changed from Closed to Feedback
  • % Done changed from 100 to 90

A final minor issue. Can we use a grey which is a bit more light? Currently, at least on my screen, it is difficult to distinguish really existing values (which should be darker) from cache values (which should be more light).

#24 Updated by Katja Luther 4 months ago

Andreas Müller wrote:

A final minor issue. Can we use a grey which is a bit more light? Currently, at least on my screen, it is difficult to distinguish really existing values (which should be darker) from cache values (which should be more light).

This colour is set when the message is shown, I need to find how to change this.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)