Actions
feature request #7268
closedfeature request #6565: [MASTER] Eclipse 4 Migration
Re-implement own preference dialog
Added by Patrick Plitzner about 6 years ago. Updated almost 6 years ago.
Start date:
Due date:
% Done:
100%
Estimated time:
Severity:
normal
Tags:
Description
Note: Also clean up p2 related code because we are now just using one update site at a time.
Updated by Patrick Plitzner about 6 years ago
- Status changed from New to In Progress
Updated by Patrick Plitzner about 6 years ago
Copied from #7007:
Katja Luther wrote:
Opening the preferences now throws an NPE:
java.lang.Exception: login : admin editor version : 4.15.0.201802191042 server : test.e-taxonomy.eu (edit-test) / rem_conf_am schema version : 4.7.0.0.201710040000 os : Windows Server 2012 R2 6.3 amd64 java : 1.8.0_121 java.lang.NullPointerException at eu.etaxonomy.taxeditor.preference.menu.AbstractMenuPreferences.checkNoneChecked(AbstractMenuPreferences.java:270) at eu.etaxonomy.taxeditor.preference.menu.AbstractMenuPreferences.performOk(AbstractMenuPreferences.java:247) at org.eclipse.jface.preference.PreferenceDialog$8.run(PreferenceDialog.java:905) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50) at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173) at org.eclipse.jface.preference.PreferenceDialog.okPressed(PreferenceDialog.java:889) at org.eclipse.jface.preference.PreferenceDialog.buttonPressed(PreferenceDialog.java:230) at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:618) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824) at org.eclipse.jface.window.Window.runEventLoop(Window.java:818) at org.eclipse.jface.window.Window.open(Window.java:794) at eu.etaxonomy.taxeditor.workbench.handler.OpenPreferencesHandler.execute(OpenPreferencesHandler.java:124) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
Updated by Patrick Plitzner about 6 years ago
Patrick Plitzner wrote:
Copied from #7007:
Katja Luther wrote:
Opening the preferences now throws an NPE:
java.lang.Exception: login : admin editor version : 4.15.0.201802191042 server : test.e-taxonomy.eu (edit-test) / rem_conf_am schema version : 4.7.0.0.201710040000 os : Windows Server 2012 R2 6.3 amd64 java : 1.8.0_121 java.lang.NullPointerException at eu.etaxonomy.taxeditor.preference.menu.AbstractMenuPreferences.checkNoneChecked(AbstractMenuPreferences.java:270) at eu.etaxonomy.taxeditor.preference.menu.AbstractMenuPreferences.performOk(AbstractMenuPreferences.java:247) at org.eclipse.jface.preference.PreferenceDialog$8.run(PreferenceDialog.java:905) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50) at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173) at org.eclipse.jface.preference.PreferenceDialog.okPressed(PreferenceDialog.java:889) at org.eclipse.jface.preference.PreferenceDialog.buttonPressed(PreferenceDialog.java:230) at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:618) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824) at org.eclipse.jface.window.Window.runEventLoop(Window.java:818) at org.eclipse.jface.window.Window.open(Window.java:794) at eu.etaxonomy.taxeditor.workbench.handler.OpenPreferencesHandler.execute(OpenPreferencesHandler.java:124) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
Fixed potential NPE with taxeditor|935c0645af6942b1af9834fe6a3a78960bb1646c
Updated by Andreas Müller almost 6 years ago
How far is this implemented already? Should we assign it to the current milestone? Or the next? Percentage done?
Updated by Patrick Plitzner almost 6 years ago
- Status changed from In Progress to Closed
- Target version changed from Unassigned CDM tickets to Release 5.0
- % Done changed from 0 to 100
The preferences are completely migrated. Any remaining issues should be treated in other tickets.
Actions