Project

General

Profile

feature request #7251

Enable collectorTitle in cdm-vaadin TeamOrPersonBaseCaptionGenerator

Added by Andreas Kohlbecker over 3 years ago. Updated about 1 month ago.

Status:
Closed
Priority:
Highest
Category:
cdm-vaadin
Target version:
Start date:
02/09/2018
Due date:
% Done:

100%

Severity:
normal

Description

In the TeamOrPersonBaseCaptionGenerator the the collector title is commented:

@Override
    public String getCaption(T option) {
        switch(cacheType){
        case NOMENCLATURAL_TITLE:
            return option.getNomenclaturalTitle();
        case COLLECTOR_TITLE:
            // return option.getCollectorTitle(); // enable once #4311 is solved
        case BIBLIOGRAPHIC_TITLE:
        default:
            return option.getTitleCache();
        }
    }


Related issues

Related to Edit - bug #7207: TeamOrPersonField and PersonField comboboxSelect is configurable to use different cache types Closed 01/18/2018
Related to Edit - feature request #7178: implement collectorTitleCache in TeamOrPersonField (vaadin) New 02/12/2018
Blocked by Edit - feature request #4311: Improve person representation in CDM Closed 02/09/2018

Associated revisions

Revision 64a847c9 (diff)
Added by Andreas Müller 4 months ago

ref #4311 adapt vadin to collectorTitleCache

History

#1 Updated by Andreas Kohlbecker over 3 years ago

  • Related to bug #7207: TeamOrPersonField and PersonField comboboxSelect is configurable to use different cache types added

#2 Updated by Andreas Müller over 3 years ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

was this ticket on purpose for me? I don't feel responsible for the vaadin issues. But of course for an according ticket in cdmlib cache generation. Is there such a ticket? If yes we should relate these 2 (e.g. blocked by)

#3 Updated by Andreas Kohlbecker over 3 years ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller

Andreas Müller wrote:

was this ticket on purpose for me? I don't feel responsible for the vaadin issues. But of course for an according ticket in cdmlib cache generation. Is there such a ticket? If yes we should relate these 2 (e.g. blocked by)

Yes this was by purpose. This ticket is a sub-issue of #4311 for which you are responsible. Once #4311 is fixed solving this issue is only a matter of removing two slashes which comment the prepared code. It is much more reliable if you do this right away after the parent issue is solved. Otherwise you would have to point me to this ticket once its parent is solved, by putting it into the current release milestone, set it to HIGHEST, etc and you must not forget to do so! But will you really remember this if you are not dedicated to this ticket?

#4 Updated by Andreas Müller over 3 years ago

OK, now I understand. I did not see that it was a subticket.
I also did not expect it to be a subticket as we have another policy for subtickets. Subtickets should only be used if they (as a set) include ALL tasks that make up the master task. That is oviously not the case here. Therefore I remove the parent and make it a blocked by ticket.

#5 Updated by Andreas Müller over 3 years ago

  • Parent task deleted (#4311)

#6 Updated by Andreas Müller over 3 years ago

#7 Updated by Andreas Müller 4 months ago

  • Related to task #9681: Open issues for improving person representation added

#8 Updated by Andreas Müller 4 months ago

  • Status changed from New to Resolved
  • Assignee changed from Andreas Müller to Andreas Kohlbecker
  • Priority changed from New to Highest
  • Target version changed from Unassigned CDM tickets to Release 5.25
  • % Done changed from 0 to 50

This was solved with #4311 I guess. Please review.

Please also check if some implementation needs to be done for #7178 which is related.

#9 Updated by Andreas Müller 4 months ago

#10 Updated by Andreas Müller 4 months ago

  • Related to deleted (task #9681: Open issues for improving person representation)

#11 Updated by Andreas Kohlbecker 3 months ago

  • Target version changed from Release 5.25 to Release 5.28

#12 Updated by Andreas Kohlbecker 3 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • % Done changed from 50 to 100

as far as I can see by now, the current implementation is fully sufficient. I will open a new ticket as far as there is something missing related to #7178

#13 Updated by Andreas Müller about 1 month ago

  • Target version changed from Release 5.28 to Release 5.27

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)