Actions
task #7202
open[DISCUSS] Can we remove equals override from some classes directly inheriting from CdmBase
Status:
New
Priority:
New
Assignee:
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:
0%
Estimated time:
Severity:
normal
Description
This is a prerequisite to make CdmBase.equals() final. For discussion see #7155 and javadoc in CdmBase.equals().
The most important classes are
- GrantedAuthorityImpl
- LSIDAuthority
Some further classes are related to the validation framework
- EntityConstraintViolation
- Some test classes for validation framework
Can you please check if these equal implementations are really needed in cdmlib and/or in UIs. If only needed for UIs we should find another solution. If needed in cdmlib we will need to discuss if no other solution exists.
I give this ticket first to AK as he is most familiar with GrantedAuthorityImpl and has a use case for LSIDAuthority (CoL webservice) but everybode should check.
The GrantedAuthorityImpl.equals seems to be implemented by Cherian. Maybe he needed it only for UI (GrantedAuthority editor).
Related issues
Updated by Andreas Müller about 6 years ago
- Related to task #7201: [DISCUSS] Should we remove created comparison from CdmBase.equals? added
Updated by Andreas Müller about 6 years ago
- Copied from bug #7155: VersionableEntity.equals() should take updated timestamp into account added
Actions