Project

General

Profile

task #7202

[DISCUSS] Can we remove equals override from some classes directly inheriting from CdmBase

Added by Andreas Müller over 1 year ago. Updated over 1 year ago.

Status:
New
Priority:
New
Category:
cdmlib
Target version:
Start date:
01/18/2018
Due date:
% Done:

0%

Severity:
normal

Description

This is a prerequisite to make CdmBase.equals() final. For discussion see #7155 and javadoc in CdmBase.equals().

The most important classes are

  • GrantedAuthorityImpl
  • LSIDAuthority

Some further classes are related to the validation framework

  • EntityConstraintViolation
  • Some test classes for validation framework

Can you please check if these equal implementations are really needed in cdmlib and/or in UIs. If only needed for UIs we should find another solution. If needed in cdmlib we will need to discuss if no other solution exists.

I give this ticket first to AK as he is most familiar with GrantedAuthorityImpl and has a use case for LSIDAuthority (CoL webservice) but everybode should check.

The GrantedAuthorityImpl.equals seems to be implemented by Cherian. Maybe he needed it only for UI (GrantedAuthority editor).


Related issues

Related to Edit - task #7201: [DISCUSS] Should we remove created comparison from CdmBase.equals? Closed 01/18/2018
Copied from Edit - bug #7155: VersionableEntity.equals() should take updated timestamp into account Closed 01/08/2018

History

#1 Updated by Andreas Müller over 1 year ago

  • Related to task #7201: [DISCUSS] Should we remove created comparison from CdmBase.equals? added

#2 Updated by Andreas Müller over 1 year ago

  • Copied from bug #7155: VersionableEntity.equals() should take updated timestamp into account added

#3 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)