Project

General

Profile

bug #7189

Taxeditor connect dialog high-dpi suport

Added by Andreas Kohlbecker over 2 years ago. Updated about 2 months ago.

Status:
Closed
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
01/16/2018
Due date:
% Done:

100%

Severity:
normal
Found in Version:

Description

With increased dpi for the system fonts as it is needed for high dpi displays the connect elementd do overlap:

I seems as if the heights in the dialog are set to fixed pixel values. Instead the heights should adapt, depend on the fontsize.

Interesting source:

https://www.slideshare.net/da152/swt-scalingece2014-aktuell

picture271-1.png View (20.8 KB) Andreas Kohlbecker, 01/16/2018 02:07 PM

picture933-1.png View (16.7 KB) Andreas Kohlbecker, 03/27/2020 03:46 PM


Related issues

Duplicated by Edit - bug #8536: Connect Dialog: UI elements exceed the available space Duplicate 09/10/2019

Associated revisions

Revision f919df55 (diff)
Added by Andreas Kohlbecker 3 months ago

ref #7189 Connect dialog resizable and allowing for automatic size calculation

Revision 91736608 (diff)
Added by Andreas Kohlbecker 2 months ago

ref #7189 improving & cleaning up size calculation of login dialog

Revision 02d289c7 (diff)
Added by Andreas Kohlbecker 2 months ago

ref #7189 improving & cleaning up size calculation of login dialog - cleaning up

Revision 5d5e74b3 (diff)
Added by Andreas Kohlbecker 2 months ago

ref #7189 fixing layout issues with empty cells in grid

Revision 20f5abe9 (diff)
Added by Andreas Kohlbecker about 2 months ago

ref #7189 resetting remote login dialog to default font sizes

History

#1 Updated by Andreas Kohlbecker 4 months ago

  • Duplicated by bug #8536: Connect Dialog: UI elements exceed the available space added

#2 Updated by Andreas Müller 4 months ago

  • Assignee changed from Andreas Müller to Katja Luther

#3 Updated by Andreas Kohlbecker 4 months ago

The same probelm exists in windows 10:

(Windows 10 at text size 150%)

#4 Updated by Andreas Kohlbecker 4 months ago

  • Assignee changed from Andreas Müller to Katja Luther

#5 Updated by Andreas Kohlbecker 3 months ago

  • Status changed from New to In Progress
  • Assignee changed from Katja Luther to Andreas Kohlbecker
  • Priority changed from New to Highest
  • Target version changed from Unassigned CDM tickets to Release 5.15

#6 Updated by Andreas Kohlbecker 3 months ago

  • Status changed from In Progress to Feedback
  • Assignee changed from Andreas Kohlbecker to Katja Luther
  • % Done changed from 0 to 40

this issue is mainly fixed. Only the width of the comboboxes is a bit too wide.

I left inactivated lines commented in the code, These should be deleted finally !!!!

@Katja: do you have an idea how the size of the comboboxes can be restricted without breaking the automatic layout and size calculation

#7 Updated by Katja Luther about 2 months ago

  • Assignee changed from Katja Luther to Andreas Kohlbecker

Andreas Kohlbecker wrote:

this issue is mainly fixed. Only the width of the comboboxes is a bit too wide.

I left inactivated lines commented in the code, These should be deleted finally !!!!

@Katja: do you have an idea how the size of the comboboxes can be restricted without breaking the automatic layout and size calculation

no, sorry. If you set widthHint, then it is not resized and it is only possible to set a minimum width.

#8 Updated by Andreas Kohlbecker about 2 months ago

Im code ist mir aufgefallen dass Cherian die Ubuntu Fontfamilie verwendet. ich nehme an um die Schriftgröße setzen zu können.

Da gibt es doch sicher bessere Wege als eine auf vielen Systemen nicht exisiterende Schrift zu verwenden:

private static final String UBUNTU = "Ubuntu"; //$NON-NLS-1$
lblCdmServer.setFont(SWTResourceManager.getFont(UBUNTU, 9, SWT.NORMAL));

#9 Updated by Andreas Kohlbecker about 2 months ago

I think we just should remove all this programmatic setting of font sizes as they are centrally managed via the settings in eclipse rcp

#10 Updated by Andreas Kohlbecker about 2 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • % Done changed from 40 to 50

I consider this as fixed, please review.

#11 Updated by Andreas Müller about 2 months ago

  • Description updated (diff)
  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Andreas Kohlbecker
  • % Done changed from 50 to 100

This is generally fixed. Only issue is that the recalculation of the layout sometimes stocks in the middle while data is loaded. This looks no so nice but is not critical.
We may want to try to fix this later.

An interesting source on how to scale swt layouts is: https://www.slideshare.net/da152/swt-scalingece2014-aktuell

#12 Updated by Andreas Müller about 2 months ago

I tested with 100%, 125%, 150% and 175% on a windows machine

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)