Project

General

Profile

Actions

bug #7143

closed

Finish not enabled when unprotecting titleCache in new Person dialog

Added by Andreas Müller about 5 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:

Description

Using the new person dialog, at the beginning the title cache is protected. Therefore entering data e.g. into "family name" does not change the titleCache. It is still empty and therefore the "Finish" button is still disabled.

Now clicking on unprotected fills the titleCache and therefore the Finish button should be enabled, but isn't.

Please check if this might also be the case for other "New" dialogs.


Files

picture465-1.png (25.2 KB) picture465-1.png Andreas Kohlbecker, 11/06/2019 03:53 PM
Actions #1

Updated by Andreas Müller about 5 years ago

  • Description updated (diff)
Actions #2

Updated by Andreas Kohlbecker over 3 years ago

The problem persists, even if a commit exists for this issue.

Actions #3

Updated by Andreas Müller over 3 years ago

  • Status changed from New to In Progress
  • Target version changed from Unassigned CDM tickets to Release 5.11

Katja can you check the state here.

But we need to be very careful. I remember this has been fixed once but the fix created a regression elsewhere. So it needs to be well checked.

Actions #4

Updated by Katja Luther over 3 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Kohlbecker

now it should work correctly, please review

Actions #5

Updated by Katja Luther over 3 years ago

  • % Done changed from 0 to 70
Actions #6

Updated by Andreas Kohlbecker over 3 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Kohlbecker to Katja Luther
  • Found in Version set to Release 5.10

Finish is not enabled when only the title cache is filled with data.

Even after entering the family name it still is required to click the title cache padlock icon twice to turn the Finish button to enabled state.

Actions #7

Updated by Katja Luther about 3 years ago

  • Assignee changed from Katja Luther to Andreas Kohlbecker

Andreas Kohlbecker wrote:

Finish is not enabled when only the title cache is filled with data.

Even after entering the family name it still is required to click the title cache padlock icon twice to turn the Finish button to enabled state.

With the actual nightly I cannot reproduce this problem anymore. Did you used the actual nightly build?

Actions #8

Updated by Andreas Kohlbecker about 3 years ago

  • Status changed from Feedback to Resolved

Katja Luther wrote:

Andreas Kohlbecker wrote:

With the actual nightly I cannot reproduce this problem anymore. Did you used the actual nightly build?

I was testing with the nightly build from yesterday. I will test again today.

Actions #9

Updated by Andreas Kohlbecker about 3 years ago

I would expect that the finish button is enabled after entering text in the TitleCache field only.

This is not yet working:

Actions #10

Updated by Katja Luther about 3 years ago

  • Assignee changed from Katja Luther to Andreas Kohlbecker

this is fixed now.

Actions #11

Updated by Andreas Kohlbecker about 3 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Kohlbecker to Katja Luther
  • Priority changed from New to Highest
  • % Done changed from 70 to 100

confirmed!

Actions

Also available in: Atom PDF