Project

General

Profile

bug #7108

supress unwanted sourcetypes in handle_annotations_and_sources()

Added by Andreas Kohlbecker almost 4 years ago. Updated 5 months ago.

Status:
Closed
Priority:
New
Category:
cdm-dataportal
Target version:
Start date:
12/04/2017
Due date:
% Done:

100%

Severity:
normal
Found in Version:
Tags:

Description

in cdm_create_footnotes() the function _is_original_source_type() is used to suppress unwanted source types, this check should also be used in handle_annotations_and_sources()

by this only the following source type will be shown:

 OriginalSourceType::Lineage,
      OriginalSourceType::PrimaryMediaSource,
      OriginalSourceType::PrimaryTaxonomicSource,
      OriginalSourceType::Unknown,
      OriginalSourceType::Other,

Associated revisions

Revision f6408572 (diff)
Added by Andreas Kohlbecker almost 4 years ago

fix #7108 supressing unwanted sourcetype in general

History

#1 Updated by Andreas Kohlbecker almost 4 years ago

  • Description updated (diff)

#2 Updated by Andreas Kohlbecker almost 4 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#3 Updated by Andreas Kohlbecker almost 4 years ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller

#5 Updated by Andreas Müller almost 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Andreas Kohlbecker
  • % Done changed from 50 to 100

Works fine now and ticket can be closed.

I only wonder if only a citation micro reference is given (without citation reference) for a source that is to be shown, why nothing is displayed. Is this on purpose (actually only a micro ref with no ref does no make so much sense, of course, but may happen if used incorrectly by user) or is it unwanted behavior?

#6 Updated by Andreas Kohlbecker 11 months ago

  • Status changed from Feedback to Closed

Andreas Müller wrote:

Works fine now and ticket can be closed.

I only wonder if only a citation micro reference is given (without citation reference) for a source that is to be shown, why nothing is displayed. Is this on purpose (actually only a micro ref with no ref does no make so much sense, of course, but may happen if used incorrectly by user) or is it unwanted behavior?

yes this is intended, microrefences without citation are suppressed as there is nothing the detail is referring to:

render_original_source($source, $do_link_to_reference = TRUE, $do_link_to_name_used_in_source = FALSE) {
  ...
  if (isset($source->citation)) {
    $out .= cdm_reference_markup($source->citation, $source->citationMicroReference, false, $do_link_to_reference);
  }

#7 Updated by Andreas Müller 5 months ago

Andreas Kohlbecker wrote:

Andreas Müller wrote:

Works fine now and ticket can be closed.

I only wonder if only a citation micro reference is given (without citation reference) for a source that is to be shown, why nothing is displayed. Is this on purpose (actually only a micro ref with no ref does no make so much sense, of course, but may happen if used incorrectly by user) or is it unwanted behavior?

yes this is intended, microrefences without citation are suppressed as there is nothing the detail is referring to:

Actually I have seen data where users put all source information as freetext into the microreference field. This is of course dirty but however, for me it shows there might be a reason to show the microreference even if no reference exists.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)