Project

General

Profile

Actions

bug #7108

closed

supress unwanted sourcetypes in handle_annotations_and_sources()

Added by Andreas Kohlbecker about 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
New
Category:
cdm-dataportal
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:
Tags:

Description

in cdm_create_footnotes() the function _is_original_source_type() is used to suppress unwanted source types, this check should also be used in handle_annotations_and_sources()

by this only the following source type will be shown:

 OriginalSourceType::Lineage,
      OriginalSourceType::PrimaryMediaSource,
      OriginalSourceType::PrimaryTaxonomicSource,
      OriginalSourceType::Unknown,
      OriginalSourceType::Other,
Actions #1

Updated by Andreas Kohlbecker about 5 years ago

  • Description updated (diff)
Actions #2

Updated by Andreas Kohlbecker about 5 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions #3

Updated by Andreas Kohlbecker about 5 years ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller
Actions #5

Updated by Andreas Müller about 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Andreas Kohlbecker
  • % Done changed from 50 to 100

Works fine now and ticket can be closed.

I only wonder if only a citation micro reference is given (without citation reference) for a source that is to be shown, why nothing is displayed. Is this on purpose (actually only a micro ref with no ref does no make so much sense, of course, but may happen if used incorrectly by user) or is it unwanted behavior?

Actions #6

Updated by Andreas Kohlbecker about 2 years ago

  • Status changed from Feedback to Closed

Andreas Müller wrote:

Works fine now and ticket can be closed.

I only wonder if only a citation micro reference is given (without citation reference) for a source that is to be shown, why nothing is displayed. Is this on purpose (actually only a micro ref with no ref does no make so much sense, of course, but may happen if used incorrectly by user) or is it unwanted behavior?

yes this is intended, microrefences without citation are suppressed as there is nothing the detail is referring to:

render_original_source($source, $do_link_to_reference = TRUE, $do_link_to_name_used_in_source = FALSE) {
  ...
  if (isset($source->citation)) {
    $out .= cdm_reference_markup($source->citation, $source->citationMicroReference, false, $do_link_to_reference);
  }
Actions #7

Updated by Andreas Müller over 1 year ago

Andreas Kohlbecker wrote:

Andreas Müller wrote:

Works fine now and ticket can be closed.

I only wonder if only a citation micro reference is given (without citation reference) for a source that is to be shown, why nothing is displayed. Is this on purpose (actually only a micro ref with no ref does no make so much sense, of course, but may happen if used incorrectly by user) or is it unwanted behavior?

yes this is intended, microrefences without citation are suppressed as there is nothing the detail is referring to:

Actually I have seen data where users put all source information as freetext into the microreference field. This is of course dirty but however, for me it shows there might be a reason to show the microreference even if no reference exists.

Actions

Also available in: Atom PDF