bug #7103
verify, fix, improve SpecimenTypeDesignationWorkingSetServiceImpl delete functions
100%
Description
SpecimenTypeDesignationWorkingSetServiceImpl implements the delete operation for SpecimenTypeDesignationWorkingSetDTO<Registration> and also handles the removal of SpecimenTypeDesignations from a workingset. For both test are implemented in SpecimenTypeDesignationWorkingSetServiceImplTest but they still fail completely or not all assumptions are fulfilled:
deleteTypeDesignationTest: fails completely and is ignoreddeleteWorkingsetTest: works but the deletion of the working set is not complete:- the gathering event is not deleted, should it be deleted by orphan removal?
- media are not affected be the deletion, should be an option in
SpecimenDeleteConfigurator?
Associated revisions
fix delete and tests of specimen with typedesignations and gathering events
renaming SpecimenTypeDesignationWorkingsetEditorPresenterTest to SpecimenTypeDesignationWorkingSetServiceImplTest and fixing test data
ref #7103 using transaction rollback to reset db after test method
ref #7103 fixing test setup and data for SpecimenTypeDesignationWorkingSetServiceImplTest
ref #7103 completeting assertions for SpecimenTypeDesignationWorkingSetServiceImplTest
ref #7103 defined test method execution order
ref #7103 TypedEntityReference: harmonizing equals with hashCode method (ignore label) and reenabling testcase in SpecimenTypeDesignationWorkingSetServiceImplTest
History
#1 Updated by Andreas Kohlbecker about 2 years ago
- Description updated (diff)
#2 Updated by Katja Luther about 2 years ago
- Assignee changed from Katja Luther to Andreas Kohlbecker
The delete in OccurrenceService is updated. Now the deletion of field units of a specimen used in a typedesignation works within a cdmlib service test (see OccurrenceServiceDeepDeleteTest.testDeepDelete_FieldUnitWithTypeDesignation()), the deletion of the gathering event if it is not used somewhere else, works too (see testDeepDelete_FieldUnit()).
Please try if the tests in vaadin work as well.
#3 Updated by Katja Luther about 2 years ago
- Status changed from New to In Progress
#4 Updated by Andreas Kohlbecker about 2 years ago
- Target version changed from Release 4.12 to Release 4.13
#5 Updated by Andreas Kohlbecker about 2 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 70
#6 Updated by Andreas Kohlbecker about 2 years ago
- Status changed from Resolved to Closed
- % Done changed from 70 to 100
