bug #7103: verify, fix, improve SpecimenTypeDesignationWorkingSetServiceImpl delete functions - Edit - Redmine

bug #7103

verify, fix, improve SpecimenTypeDesignationWorkingSetServiceImpl delete functions

Added by Andreas Kohlbecker over 1 year ago. Updated over 1 year ago.

Status:

Closed

Priority:

New

Assignee:

Andreas Kohlbecker

Category:

cdm-vaadin

Target version:

Release 4.13

Start date:

12/01/2017

Due date:

% Done:

100%

Severity:

normal

Found in Version:

Tags:

phycobank

Description

SpecimenTypeDesignationWorkingSetServiceImpl implements the delete operation for SpecimenTypeDesignationWorkingSetDTO<Registration> and also handles the removal of SpecimenTypeDesignations from a workingset. For both test are implemented in SpecimenTypeDesignationWorkingSetServiceImplTest but they still fail completely or not all assumptions are fulfilled:

deleteTypeDesignationTest: fails completely and is ignored
deleteWorkingsetTest: works but the deletion of the working set is not complete:
- the gathering event is not deleted, should it be deleted by orphan removal?
- media are not affected be the deletion, should be an option in SpecimenDeleteConfigurator?

Associated revisions

Revision 8f5a9520 (diff)
Added by Katja Luther over 1 year ago

fix delete and tests of specimen with typedesignations and gathering events

Revision b1b16714 (diff)
Added by Andreas Kohlbecker over 1 year ago

renaming SpecimenTypeDesignationWorkingsetEditorPresenterTest to SpecimenTypeDesignationWorkingSetServiceImplTest and fixing test data

Revision 28481c29 (diff)
Added by Andreas Kohlbecker over 1 year ago

ref #7103 using transaction rollback to reset db after test method

Revision 0453b64d (diff)
Added by Andreas Kohlbecker over 1 year ago

ref #7103 fixing test setup and data for SpecimenTypeDesignationWorkingSetServiceImplTest

Revision 9a56a56f (diff)
Added by Andreas Kohlbecker over 1 year ago

ref #7103 completeting assertions for SpecimenTypeDesignationWorkingSetServiceImplTest

Revision d1344a8b (diff)
Added by Andreas Kohlbecker over 1 year ago

ref #7103 defined test method execution order

Revision 8555ad50 (diff)
Added by Andreas Kohlbecker over 1 year ago

ref #7103 TypedEntityReference: harmonizing equals with hashCode method (ignore label) and reenabling testcase in SpecimenTypeDesignationWorkingSetServiceImplTest

History

#1 Updated by Andreas Kohlbecker over 1 year ago

Description updated (diff)

#2 Updated by Katja Luther over 1 year ago

Assignee changed from Katja Luther to Andreas Kohlbecker

The delete in OccurrenceService is updated. Now the deletion of field units of a specimen used in a typedesignation works within a cdmlib service test (see OccurrenceServiceDeepDeleteTest.testDeepDelete_FieldUnitWithTypeDesignation()), the deletion of the gathering event if it is not used somewhere else, works too (see testDeepDelete_FieldUnit()).

Please try if the tests in vaadin work as well.