Edit

Applied in changeset taxeditor|0594533897ccd7e0709aeff830424f5ec29479c5.

Delete on taxon gave an NPE

login : admin
editor version : 4.13.0.201801292346
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 4.7.0.0.201710040000
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
    at eu.etaxonomy.taxeditor.ui.section.occurrence.DeterminationEventDetailElement.handleEvent(DeterminationEventDetailElement.java:122)
    at eu.etaxonomy.taxeditor.ui.section.AbstractEntityCollectionElement.propertyChange(AbstractEntityCollectionElement.java:160)
    at eu.etaxonomy.taxeditor.ui.element.AbstractCdmFormElement.firePropertyChangeEvent(AbstractCdmFormElement.java:234)
    at eu.etaxonomy.taxeditor.ui.selection.EntitySelectionElement$DeleteListener.widgetSelected(EntitySelectionElement.java:420)
    at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
    at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
    at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
    at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
    at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
    at eu.etaxonomy.taxeditor.Application.start(Application.java:24)
    at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
    at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
    at org.eclipse.equinox.launcher.Main.run(Main.java:1519)

EDIT for taxa gives a strange message (see screenshot)

move this forgotten issue to current milestone

Andreas Müller wrote:

Andreas Müller wrote:

Deleting the name should also delete the taxon

This sometimes works immediately but after saving, clicking on another record and going back to the record the taxon is there again.
After full reload even the name is there again because it is reloaded by the CdmPreDataChangeListener.

This problem still exists.

Also when deleting the taxon the name is also deleted. This is not wanted. Only when deleting the name the taxon should be automatically deleted.

Note: saving here usually does not lead to a disabled save symbol after save. Maybe this can be fixed also
Note2: if there is a longer result list(tree) saving leads to a scroll down which unexpected

Can you please check again if the issues last mentioned still exist. I fixed the unintended deletion of the taxon name but I could not reproduce the other issues.
And what view is scrolled when saving?

Patrick Plitzner wrote:

And what view is scrolled when saving?

The specimen tree editor view, see attachement.

One more related issue: when adding a taxon or name, the according text fields do not change their size but stay in single line mode. Usually for taxon representation but also for names we need 2 or more lines. It only changes size if resizing e.g. the width of the details view or by resellecting the specimen.

So this and the scrolling issue are remaining from this ticket. Feel free to open new ticket(s) if necessary.