Project

General

Profile

Actions

bug #7069

closed

Delete taxon node should have consistent configuration

Added by Andreas Müller about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

50%

Estimated time:
Severity:
normal
Found in Version:

Description

**Currently delete in taxon navigator comes with 2 flavors: taxon nodes with children and without children.

Without children the configuration possibilities are very limited. Only "delete taxon if possible" is available while "with children" has many configurations.

We should use the same Dialog but only adapt child handling buttons in a way that they are correct for the version without children, e.g. by adapting labels of buttons or disabling / changing visibility of buttons.

===

Also the label for Cancel should be changed, at least in German. "Überspringen" is not correct, it should be "Abbrechen". Havn't checked if it is correct in English.


Files

picture354-1.png (16.9 KB) picture354-1.png Andreas Müller, 01/30/2018 11:33 AM

Related issues

Copied to EDIT - bug #7273: Expanding DeleteTaxonNode wizard shows some parts of the buttons in old positionNewKatja Luther

Actions
Actions #1

Updated by Andreas Müller about 5 years ago

  • Target version changed from Release 4.12 to Release 4.13
Actions #2

Updated by Katja Luther about 5 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions #3

Updated by Katja Luther about 5 years ago

  • Assignee changed from Katja Luther to Andreas Müller
Actions #4

Updated by Katja Luther about 5 years ago

please review

Actions #5

Updated by Andreas Müller about 5 years ago

  • Description updated (diff)
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 80

Generally this is solved. Some minor issues:

  1. Deleting a leaf: German label is "Wollen sie die ausgewählten Knoten ...", should be "Wollen sie den ..." if only one leaf is selected. Please check if this is also an issue in English.
  2. Deleting a node with children. German label is "... Es sind Kindknoten vorhanden, die auch gelöscht werden". This doesn't fit to the new functionality anymore. Better maybe "Wollen Sie den ausgewählten Knoten wirklich löschen? Sollen die Kindknoten auch gelöscht werden?". Please also adapt in English.
Actions #6

Updated by Katja Luther about 5 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 80 to 50
Actions #7

Updated by Katja Luther about 5 years ago

  • Assignee changed from Katja Luther to Andreas Müller

The dialog is now adapted to the possibility to delete more than one taxon node and the minor issues are solved as well.

Actions #8

Updated by Andreas Müller about 5 years ago

I removed duplication in German label. Please confirm (1d720e10dd7db8)

Generally it works. 2 further open issues:

1) When opening "Configure" the screen does not refresh correctly (see screenshot attachment), also when resizing the dialog window it does not refresh correctly (feel free to open new ticket if immediate fix not possible)

2) When clicking on the "x" to close the window the delete command is executed instead of canceling, this is critical because unexpected (feel free to open new ticket if immediate fix not possible)

Actions #9

Updated by Katja Luther almost 5 years ago

  • Status changed from Feedback to Closed

now the nodes are only deleted if delete is clicked.
the problem of the remaining button parts when expanding the wizard I move to a new ticket.

Actions #10

Updated by Katja Luther almost 5 years ago

  • Copied to bug #7273: Expanding DeleteTaxonNode wizard shows some parts of the buttons in old position added
Actions

Also available in: Atom PDF