feature request #7063
closed
Improve the area selection wizard for distribution editor
Added by Katja Luther over 6 years ago.
Updated about 5 years ago.
Description
The wizard for selection of areas for the distribution editor should be improved.
- while opening the wizard the vocabularies are not correctly marked if the whole vocabulary or only parts of it should be used in the distribution editor.
- the wizard is quite slow (performance)
For the first issue we decided to implement the following:
- we keep selection via tree structure
- the checkbox uses triple state:
a. checked, if, and only if, all subareas, and their subareas are fully included
- undefined, if, some subareas are checked, but not all (including recursive subareas
- not checked, if no of the subareas is checked or in "undefinded" state it self
- opening a node in the tree works via "triangle button"
- click actions: double functionality is needed
- select/deselect all subareas
- select the given area (not including the subareas)
- problem: we want to avoid right click menus or other double functionality handling modes (e.g. single click/double click) as they are maybe not intuitive
- solution: to select/deselect the single area (without subareas) we add it to itself as child node at first position, without children
- click action "select all subareas" will
- open the for one more level
- check the parent checkbox and all child checkboxes
- check all grandchild checkboxes if expanded, however for all grand(grand) children the information needs to be stored that they are "checked"
- opening also all grandchildren takes a lot of rendering time and is not necessary
- click "deselect all" will
- unckeck all child and grandchild areas
- not change the expansion state of the tree
For performance improvement need something like a UuidAndTitleCache for trees (including the parent information). Loading this should be faster then current implementation but can still load the full vocabulary at once if voc is not extremely large. But maybe this already exists e.g. from taxon navigator DTO.
Open issues:
- triple state is not yet correctly propagated to vocabulary during initial load (checkbox always empty)
- deselection only propagates to next parent, but not to grandparent (e.g. if parent switches from checked to undefined and grandparent is also checked, it also needs to switch to undefined)
- clicking on a parent which is in "undefined" does not change its state but should (either going to checked or unchecked, because also all its children switch to this state
- Subject changed from improve the area selection wizard for sistribution editor to improve the area selection wizard for distribution editor
The area selection wizard works better now then before. Some minor issues:
Handling of triple states: if only parts of a vocabulary are selected I would expect a triple state. As the vocabulary itself is not an area, it should only show the state of the selected areas within this vocabulary, with (1) selected = all areas selescted, (2) undefined = some areas selected, (3) unselected = no area selected. I managed to get such an "undefined" state once for the Waterbody vocabulary, but could not reproduce for any other. This is different for parent nodes which are areas themselves. They must not have a triple state because they might be shown or not shown in the editor.
The performance of e.g. clicking on TDWG vocabulary is very bad. Probably it is not a use case to select ALL TDWG areas. We may think for a better solution. Maybe it is enough to only select the next layer (e.g. TDWG level 1) and one has to select the next level manually, but this has also drawbacks, so we have to further think about a good solution
- Copied from bug #6159: improve distribution editor in TaxEditor added
- Target version changed from Release 4.12 to Release 4.13
Katja Luther wrote:
The area selection wizard works better now then before. Some minor issues:
- Handling of triple states: if only parts of a vocabulary are selected I would expect a triple state. As the vocabulary itself is not an area, it should only show the state of the selected areas within this vocabulary, with (1) selected = all areas selescted, (2) undefined = some areas selected, (3) unselected = no area selected. I managed to get such an "undefined" state once for the Waterbody vocabulary, but could not reproduce for any other. This is different for parent nodes which are areas themselves. They must not have a triple state because they might be shown or not shown in the editor.
this is partly implemented by checkmark if all areas of a vocabulary are selected and a grayed if only some areas are selected. It is not possible to select a parent node which is an area and deselect the children or select only some of the children (then the parent node is not displayed in distribution editor)
- Status changed from New to In Progress
for better usabilty the terms are sorted now
- Target version changed from Release 4.13 to Release 4.14
- Target version changed from Release 4.14 to Release 5.0
the grayed check boxes for larger hierarchies needs to be improved
- Related to bug #6297: [Overview] BGBM User group wishes 2017 added
- Target version changed from Release 5.0 to Release 5.1
- % Done changed from 0 to 40
- Estimated time set to 8:00 h
- Target version changed from Release 5.1 to Release 5.2
- Target version changed from Release 5.2 to Release 5.3
- Target version changed from Release 5.3 to Release 5.4
now the admin can define the vocabulary and in the distribution editor itself the shown areas can be defined.
- Status changed from In Progress to Resolved
- Assignee changed from Katja Luther to Andreas Müller
A lot of work on this has been done in #7793. I put to resolved to check if all issues reported here are resolved now.
- Related to feature request #7235: Make available area vocabularies a database preference for TaxEditor distribution editor added
- Related to task #7854: Open issues in TaxDistributionEditor added
Performance has been improved by preselecting vocabularies in DB prefs or local prefs.
- Description updated (diff)
- Status changed from Resolved to Feedback
I updated description to refelct our decisions how the selection tree should work
- Description updated (diff)
- Description updated (diff)
- Description updated (diff)
- Assignee changed from Andreas Müller to Katja Luther
- Status changed from Feedback to Resolved
- Assignee changed from Katja Luther to Andreas Müller
I think this is solved with #7887.
Now the items in the tree have three states and it is possible to select and deselct all children of an item.
- Subject changed from improve the area selection wizard for distribution editor to Improve the area selection wizard for distribution editor
- Status changed from Resolved to Closed
- Assignee changed from Andreas Müller to Katja Luther
- % Done changed from 40 to 100
Katja Luther wrote:
I think this is solved with #7887.
Now the items in the tree have three states and it is possible to select and deselct all children of an item.
I think it is #7912 (not 7887). However, the selection wizard works good now. Minor open issues will be handled in #7912. So we can close this ticket.
Also available in: Atom
PDF