Project

General

Profile

feature request #7056

Media View should show Preview

Added by Katja Luther about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Priority14
Category:
taxeditor
Target version:
Start date:
11/06/2017
Due date:
% Done:

100%

Severity:
normal

Description

The media view should provide a preview of the image. the default should be no preview but it should be turned on by the preferences.


Related issues

Copied to Edit - feature request #7066: media view with preview should have different row heights for different image sizes New 11/07/2017

Associated revisions

Revision a904e4d0 (diff)
Added by Katja Luther about 1 year ago

ref #7056: add possibility to show preview of the image in media view

Revision fa07dfed (diff)
Added by Patrick Plitzner about 1 year ago

ref #7056 Generate titleCache for newly created image galleries

Revision 29c6624e (diff)
Added by Katja Luther about 1 year ago

choose smallest representation for media preview

Revision e8e82804 (diff)
Added by Katja Luther about 1 year ago

use mediaUtils for getting the best matching media representation for mediaViewLabelProvider

History

#1 Updated by Katja Luther about 1 year ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

the preview is now available, it can be activated in preferences

at the moment it is not possible to have different heights for the columns, therefore we need another treeviewer for implementing this we open a new ticket and close this one. (#7066)

#2 Updated by Andreas Müller about 1 year ago

  • Copied to feature request #7066: media view with preview should have different row heights for different image sizes added

#3 Updated by Andreas Müller about 1 year ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 100

The base implementation seems to work correct.

#4 Updated by Andreas Müller about 1 year ago

  • Status changed from Closed to Feedback

The algorithm should always choose the smallest representation (or at least the best fitting for the given - small - size). There are already methods available to find the best fitting representation.

#5 Updated by Andreas Müller about 1 year ago

The current implementation only iterates only on the parts of the first representation, but should iterate on all representations. Parts can be neglected (will be removed from model soon), always the first part should be taken.

URI uri = parts.get(0).getUri();

anyway uses the first part. The computed variable "smallestPart" is not used elsewhere in code.

Also have in mind, that often size does not exist, instead we need to take width and height. There is code for computing this elsewhere. We should try to reuse it. I need to search for it. AK may know.

#6 Updated by Katja Luther about 1 year ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

now the smallest part is used and the library function to compute the smallest part.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)