Project

General

Profile

Actions

bug #7045

open

portal/classification/{uuid}/childNodesOf/{uuid} service slow

Added by Andreas Kohlbecker over 6 years ago. Updated 6 days ago.

Status:
Feedback
Priority:
Highest
Assignee:
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:

70%

Estimated time:
Severity:
critical
Found in Version:
Tags:


Related issues

Related to EDIT - bug #4962: improve portal/classification/{taxon_uuid}/childNodesAt/{rank_uuid} web serviceResolvedAndreas Müller

Actions
Related to EDIT - feature request #9271: Improve E+M dataportal performanceNewAndreas Müller

Actions
Related to EDIT - feature request #10322: Use DTOs for portal taxon page (cont.)NewAndreas Müller

Actions
Actions #1

Updated by Andreas Kohlbecker over 6 years ago

  • Related to bug #4962: improve portal/classification/{taxon_uuid}/childNodesAt/{rank_uuid} web service added
Actions #2

Updated by Andreas Müller over 6 years ago

is this a duplicate or only related to #4962?

Actions #3

Updated by Andreas Kohlbecker over 6 years ago

Andreas Müller wrote:

is this a duplicate or only related to #4962?
only related, #4962 is on the childNodesAt/{rank_uuid} web service

Actions #4

Updated by Andreas Müller over 6 years ago

  • Target version changed from Release 4.11 to Release 4.12
Actions #5

Updated by Andreas Müller about 6 years ago

  • Target version changed from Release 4.12 to Release 4.13
Actions #6

Updated by Andreas Müller about 6 years ago

  • Target version changed from Release 4.13 to Release 4.14
Actions #7

Updated by Andreas Müller about 6 years ago

  • Target version changed from Release 4.14 to Release 5.0
Actions #8

Updated by Andreas Müller almost 6 years ago

  • Target version changed from Release 5.0 to Release 5.1
Actions #9

Updated by Andreas Müller over 5 years ago

  • Target version changed from Release 5.1 to Release 5.2
Actions #10

Updated by Andreas Müller over 5 years ago

  • Target version changed from Release 5.2 to Release 5.3
Actions #11

Updated by Andreas Müller over 5 years ago

  • Target version changed from Release 5.3 to Release 5.4
Actions #12

Updated by Andreas Müller over 5 years ago

  • Target version changed from Release 5.4 to Release 5.5
Actions #13

Updated by Andreas Müller about 5 years ago

  • Target version changed from Release 5.5 to Release 5.6
Actions #14

Updated by Andreas Müller about 5 years ago

  • Priority changed from New to Highest
  • Target version changed from Release 5.6 to Reviewed Next Major Release
Actions #15

Updated by Andreas Müller over 3 years ago

Actions #16

Updated by Andreas Müller almost 2 years ago

  • Target version changed from Reviewed Next Major Release to Release 5.44

This seems to have happened after #4962 has been resolved.

Unfortunately the bogota example is not available (archived) anymore.

Actions #17

Updated by Andreas Müller about 1 month ago

  • Description updated (diff)

TaxonNodeDto params:

easy to load:

  • secUuid
  • taxonUuid
  • (taxon node) status
  • taxonStatus = TaxonStatus.Accepted
  • classificationUUID
  • parentUuid
  • treeIndex
  • sortIndex
  • taxonIsPublish
  • rankOrderIndex
  • taxonomicChildrenCount (is precomputed)

middle:

  • rankLabel (language dependend, needed?)
  • statusNote (language dependend, needed)

complex:

  • taggedTitle

Inherited:

  • type (class)
  • uuid
  • id
  • titleCache (needed ?)
  • abbrevTitleCache (not needed)
  • isProtectedTitleCache (needed ?)
Actions #18

Updated by Andreas Müller about 1 month ago

  • Description updated (diff)
Actions #19

Updated by Andreas Müller 18 days ago

  • Target version changed from Release 5.44 to Release 5.43
Actions #20

Updated by Andreas Müller 18 days ago

  • Status changed from New to In Progress
Actions #21

Updated by Andreas Müller 14 days ago

The relevant service is ClassificationService.listChildNodeDtosOfTaxon()

Actions #22

Updated by Andreas Müller 10 days ago

  • Description updated (diff)
Actions #23

Updated by Andreas Müller 10 days ago

  • Description updated (diff)
  • % Done changed from 0 to 50
Actions #24

Updated by Andreas Müller 10 days ago

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 70

still need to test and cleanup (e.g. use map instead of result class)

Actions #25

Updated by Andreas Müller 6 days ago

  • Assignee changed from Andreas Müller to Katja Luther

Can you please review if it all works and if all fields potentially needed are available? Afterwards please pass the ticket back to me for further code cleaning.

Actions #26

Updated by Katja Luther 6 days ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Katja Luther to Andreas Müller

We also need the taggedFullTitleCache for the name because for example in euro+med the search results also contain the nomenclatural reference

Actions #27

Updated by Andreas Müller 6 days ago

  • Assignee changed from Andreas Müller to Katja Luther

Katja Luther wrote in #note-26:

We also need the taggedFullTitleCache for the name because for example in euro+med the search results also contain the nomenclatural reference

But isn't the nomenclatural reference available via TaxonFindDto.sourceString (originally it must have been retrieved via the explicit .../nomenclaturalCitation?microCitation(?) service)?

Actions #28

Updated by Katja Luther 6 days ago

Andreas Müller wrote in #note-27:

Katja Luther wrote in #note-26:

We also need the taggedFullTitleCache for the name because for example in euro+med the search results also contain the nomenclatural reference

But isn't the nomenclatural reference available via TaxonFindDto.sourceString (originally it must have been retrieved via the explicit .../nomenclaturalCitation?microCitation(?) service)?

It would be easier if it is in the tagged text format than we can use the same method as now, otherwise we have to format it on portal side.

Actions #29

Updated by Andreas Müller 6 days ago

Actions #30

Updated by Andreas Müller 6 days ago

Katja Luther wrote in #note-28:

Andreas Müller wrote in #note-27:

Katja Luther wrote in #note-26:

We also need the taggedFullTitleCache for the name because for example in euro+med the search results also contain the nomenclatural reference

But isn't the nomenclatural reference available via TaxonFindDto.sourceString (originally it must have been retrieved via the explicit .../nomenclaturalCitation?microCitation(?) service)?

It would be easier if it is in the tagged text format than we can use the same method as now, otherwise we have to format it on portal side.

But again, wasn't this done like before? Currently in production we have calls like "reference/99ceee38-0238-40fd-9bab-c91e18815d3f/nomenclaturalCitation?microReference=1052". So also in the existing code the formatting worked with a separate ws-call for retrieving the formatted nom. ref. Why can't we simply reuse this code and replace the ws result by the TaxonFindDto.sourceString?

In general I agree that including the nom. ref. in the tagged text might make sense. But this is not trivial to implement as I explained yesterday and therefor I would like to wait with it for now.

Actions #31

Updated by Katja Luther 6 days ago

Andreas Müller wrote in #note-30:

Katja Luther wrote in #note-28:

Andreas Müller wrote in #note-27:

Katja Luther wrote in #note-26:

We also need the taggedFullTitleCache for the name because for example in euro+med the search results also contain the nomenclatural reference

But isn't the nomenclatural reference available via TaxonFindDto.sourceString (originally it must have been retrieved via the explicit .../nomenclaturalCitation?microCitation(?) service)?

It would be easier if it is in the tagged text format than we can use the same method as now, otherwise we have to format it on portal side.

But again, wasn't this done like before? Currently in production we have calls like "reference/99ceee38-0238-40fd-9bab-c91e18815d3f/nomenclaturalCitation?microReference=1052". So also in the existing code the formatting worked with a separate ws-call for retrieving the formatted nom. ref. Why can't we simply reuse this code and replace the ws result by the TaxonFindDto.sourceString?

In general I agree that including the nom. ref. in the tagged text might make sense. But this is not trivial to implement as I explained yesterday and therefor I would like to wait with it for now.

The WS returns a formatted string of the nomenclatural reference and its microreference, this formatting needs to be done on portal side, if we only have the complete source.

Actions

Also available in: Atom PDF