Project

General

Profile

feature request #6990

feature request #6565: [MASTER] Eclipse 4 Migration

Migrate search result view

Added by Patrick Plitzner about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
New
Category:
taxeditor
Target version:
Start date:
09/27/2017
Due date:
% Done:

100%

Severity:
critical
Tags:

picture96-1.png View (9.08 KB) Andreas Müller, 10/19/2017 09:14 PM

picture352-1.png View (1.85 KB) Andreas Müller, 10/19/2017 09:15 PM

picture724-1.png View (14.6 KB) Katja Luther, 11/02/2017 02:25 PM

Associated revisions

Revision 2ff53a7f (diff)
Added by Patrick Plitzner about 1 year ago

fix #6990 Migrate search result view

Revision 5362d1b1 (diff)
Added by Patrick Plitzner about 1 year ago

ref #6990 Fix double-click opening from search results

Revision 9f70389a (diff)
Added by Patrick Plitzner about 1 year ago

ref #6990, #6932 Fix exception when opening orphaned taxon in bulkeditor

Revision 5b3f7856 (diff)
Added by Patrick Plitzner about 1 year ago

ref #6990 catch potential NPE

Revision db033747 (diff)
Added by Patrick Plitzner about 1 year ago

ref #6990 Evaluate preferences for search results

  • open in navigation part stack

Revision 47562b1c (diff)
Added by Patrick Plitzner about 1 year ago

ref #6990 Fix label provider fonts

Revision a9ee1fff (diff)
Added by Patrick Plitzner about 1 year ago

ref #6990 open search result view in correct part stack

Revision 64998378 (diff)
Added by Patrick Plitzner about 1 year ago

ref #6990 Fix resize of search bar

History

#1 Updated by Patrick Plitzner about 1 year ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#2 Updated by Andreas Müller about 1 year ago

  • Assignee changed from Patrick Plitzner to Andreas Müller

Can this be reviewed

#3 Updated by Patrick Plitzner about 1 year ago

There may be smaller errors but yes, please review.

#4 Updated by Andreas Müller about 1 year ago

Double click on an accepted taxon (of a classification) results in an "Unsupported Type" exception (see attachement).

It is possible to open it via context menu in name editor. Opening in Bulk Editor (Name or Taxon) is not possible as the Bulk editor is disabled (see attachement 2).

We also should distinguish opening in taxon and name editor I think. But this is not a migration issue as it did not exist in the previous version yet.

This is critical because core functionality.

#6 Updated by Andreas Müller about 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

#7 Updated by Andreas Müller about 1 year ago

If preference "open search result in separate windows" is unchecked the search is result is still opened in separate window, but shouldn't.

#8 Updated by Andreas Müller about 1 year ago

There is also an issue with the local preferences are shown in the search result view #7006#note-8 and https://dev.e-taxonomy.eu/redmine/attachments/download/1104/picture240-1.png

Probably this is an issue of the solution in #7006 and not directly related to this ticket, but not sure.

#9 Updated by Andreas Müller about 1 year ago

#10 Updated by Patrick Plitzner about 1 year ago

#11 Updated by Patrick Plitzner about 1 year ago

Andreas Müller wrote:

Double click on an accepted taxon (of a classification) results in an "Unsupported Type" exception (see attachement).

It is possible to open it via context menu in name editor. Opening in Bulk Editor (Name or Taxon) is not possible as the Bulk editor is disabled (see attachement 2).

We also should distinguish opening in taxon and name editor I think. But this is not a migration issue as it did not exist in the previous version yet.

This is critical because core functionality.

Double-click is fixed

open in bulk editor also

#12 Updated by Katja Luther about 1 year ago

double click works fine now, the open in options work as well.

#13 Updated by Katja Luther about 1 year ago

only this problem still exists:

If preference "open search result in separate windows" is unchecked the search is result is still opened in separate window, but shouldn't.

#14 Updated by Patrick Plitzner about 1 year ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 50 to 70

All issues should be fixed

#15 Updated by Patrick Plitzner about 1 year ago

Please also check the fonts used in the search results.
Also check if there are tooltips. But maybe they were already broken before.

#16 Updated by Katja Luther about 1 year ago

searching in taxon bulk editor and search bar provides in two different results. see attached screenshot

#17 Updated by Andreas Müller about 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

#18 Updated by Katja Luther about 1 year ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller

sorry was my fault. Test was the author and the searchbar only works on the nameCache

#19 Updated by Andreas Müller about 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

This seems to be fully implemented. Couldn't find any open issues.

All tooltips that were available in 4.10 are still available, additionally tooltips on context menu are now available but were not available before. Is there any hint in the code that there should be more tooltips but they are broken?

If not we can close this ticket. If yes, we can also close but should create a new ticket for fixing the tooltips.

Ahh, sorry, 1 more issue: If preferences say "Open search result in seperate window" the new result is not shown in the same part as the already existing search but at the default position beside the navigator. It should open in the same part as already existing search results (this is how it worked in e3).

#20 Updated by Patrick Plitzner about 1 year ago

  • Assignee changed from Patrick Plitzner to Andreas Müller

Fixed the issue where the view is opened.
I don't understand what you mean with the tooltips. These are just the tooltips for the commands in the context menu. They should have been there before.

#21 Updated by Andreas Müller about 1 year ago

  • Status changed from Feedback to Closed
  • Assignee changed from Andreas Müller to Patrick Plitzner
  • % Done changed from 70 to 100

Looks fine now.

About the tooltips: this was an answer to #note-15 where you asked to also test tooltips and say that some were maybe broken before. Tooltips seem to work better than before so I think we can close this ticket.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)