Project

General

Profile

bug #6961

Drag&Drop for taxon nodes throws NPE when hovering Classification

Added by Andreas Müller about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Priority14
Category:
taxeditor
Target version:
Start date:
09/20/2017
Due date:
% Done:

50%

Severity:
normal
Found in Version:

Description

login : 
editor version : 4.10.0.201709192246
server :  ()
schema version : 
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
                at eu.etaxonomy.cdm.persistence.hibernate.permission.CdmPermissionClass.getValueOf(CdmPermissionClass.java:40)
                at eu.etaxonomy.cdm.persistence.hibernate.permission.CdmAuthority.<init>(CdmAuthority.java:82)
                at eu.etaxonomy.cdm.persistence.hibernate.permission.CdmPermissionEvaluator.authorityRequiredFor(CdmPermissionEvaluator.java:183)
                at eu.etaxonomy.cdm.persistence.hibernate.permission.CdmPermissionEvaluator.hasPermission(CdmPermissionEvaluator.java:91)
                at eu.etaxonomy.taxeditor.store.CdmStore.currentAuthentiationHasPermission(CdmStore.java:443)
                at eu.etaxonomy.taxeditor.navigation.navigator.TreeNodeDropAdapterAssistant.validateDrop(TreeNodeDropAdapterAssistant.java:123)
                at org.eclipse.ui.navigator.CommonDropAdapter$2.run(CommonDropAdapter.java:237)
                at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
                at org.eclipse.ui.navigator.CommonDropAdapter.validateDrop(CommonDropAdapter.java:233)
                at org.eclipse.jface.viewers.ViewerDropAdapter.doDropValidation(ViewerDropAdapter.java:204)
                at org.eclipse.jface.viewers.ViewerDropAdapter.dragOver(ViewerDropAdapter.java:241)
                at org.eclipse.swt.dnd.DNDListener.handleEvent(DNDListener.java:81)
                at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
                at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
                at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
                at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1103)
                at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1088)
                at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:802)
                at org.eclipse.swt.dnd.DropTarget.DragOver(DropTarget.java:380)
                at org.eclipse.swt.dnd.DropTarget.DragOver_64(DropTarget.java:352)
                at org.eclipse.swt.dnd.DropTarget$3.method4(DropTarget.java:260)
                at org.eclipse.swt.internal.ole.win32.COMObject.callback4(COMObject.java:101)
                at org.eclipse.swt.internal.ole.win32.COM.DoDragDrop(Native Method)
                at org.eclipse.swt.dnd.DragSource.drag(DragSource.java:378)
                at org.eclipse.swt.dnd.DragSource.access$0(DragSource.java:304)
                at org.eclipse.swt.dnd.DragSource$1.handleEvent(DragSource.java:173)
                at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
                at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
                at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
                at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236)
                at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824)
                at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
                at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
                at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
                at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
                at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
                at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
                at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
                at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
                at eu.etaxonomy.taxeditor.Application.start(Application.java:24)
                at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
                at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
                at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
                at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
                at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
                at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
                at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
                at java.lang.reflect.Method.invoke(Method.java:498)
                at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
                at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
                at org.eclipse.equinox.launcher.Main.run(Main.java:1519)

Related issues

Related to Edit - bug #6894: NPE when trying drag&drop a Classification to the GrantedAuthority editor Closed 08/07/2017
Related to Edit - feature request #6977: check TreeNodeDropAdapterAssistant and TreeNodeDropAdapter if both are needed Rejected 09/22/2017

Associated revisions

Revision e2a02bc3 (diff)
Added by Andreas Müller about 1 year ago

fix #6961 fix NPE for TaxonNode d&d when hovering classification

Revision 9aa59538 (diff)
Added by Andreas Müller about 1 year ago

fix #6961 fix NPE for TaxonNode d&d when hovering classification in AdapterAssistant class

Revision fa8083dd (diff)
Added by Andreas Müller about 1 year ago

fix #6961 fix further potential NPEs in TreeNodeDropAdapter and TreeNodeDropAdapterAssistant and cleanup

Revision 1cefec6b (diff)
Added by Andreas Müller about 1 year ago

fix #6961 fix further NPEs in TreeNodeDropAdapter and TreeNodeDropAdapterAssistant

History

#1 Updated by Andreas Müller about 1 year ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#2 Updated by Andreas Müller about 1 year ago

  • Assignee changed from Andreas Müller to Katja Luther
  • Priority changed from New to Priority14

Can you please review?

What I do not understand is the difference between TreeNodeDropAdapterAssistant and TreeNodeDropAdapter.

They look both very similar. Are they both needed?

#3 Updated by Andreas Müller about 1 year ago

  • Related to bug #6894: NPE when trying drag&drop a Classification to the GrantedAuthority editor added

#4 Updated by Katja Luther about 1 year ago

  • Status changed from Resolved to Closed
  • Assignee changed from Katja Luther to Andreas Müller

works now.

I will check the two classes (create a new ticket and close this one)

#5 Updated by Katja Luther about 1 year ago

  • Related to feature request #6977: check TreeNodeDropAdapterAssistant and TreeNodeDropAdapter if both are needed added

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)