https://dev.e-taxonomy.eu/redmine/https://dev.e-taxonomy.eu/redmine/redmine/favicon.ico?14691914852009-10-01T18:44:10ZEDIT Project ManagementEDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=33392009-10-01T18:44:10ZAndreas Müller
<ul><li><strong>Priority</strong> changed from <i>Priority08</i> to <i>Priority11</i></li></ul> EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=33402009-10-05T15:47:33ZKatja Luther
<ul><li><strong>Target version</strong> changed from <i>CDM lib Release 2.0</i> to <i>CDM lib Release 2.3</i></li></ul> EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=617332021-07-02T21:10:56ZAndreas Müller
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/redmine/journals/61733/diff?detail_id=76741">diff</a>)</li></ul><p>We do have a term tree service. But there is no DescriptionElementService yet. Needs discussion if we really need it.</p>
EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=617692021-07-05T07:42:37ZAndreas Kohlbecker
<ul><li><strong>Tags</strong> set to <i>api</i></li><li><strong>Private</strong> changed from <i>Yes</i> to <i>No</i></li></ul> EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=617812021-07-05T09:05:09ZAndreas Müller
<ul><li><strong>Tags</strong> changed from <i>api</i> to <i>service-api</i></li></ul> EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=640172021-11-23T21:21:24ZAndreas Müller
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>Target version</strong> changed from <i>cdmlib - Old Next Major Release</i> to <i>Release 5.45</i></li></ul> EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=643582022-01-20T22:35:50ZAndreas Müller
<ul><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Andreas Kohlbecker</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>50</i></li></ul><p>please review</p>
EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=644252022-01-27T14:27:44ZAndreas Kohlbecker
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Feedback</i></li><li><strong>Assignee</strong> changed from <i>Andreas Kohlbecker</i> to <i>Andreas Müller</i></li></ul><p>This ticket is fairly old. The DescriptionElementService functionality once has been implemented into the <code>DescriptionServiceImpl</code>. Now we have two services for DescriptionElements. I am bit undecided how to deal with this situation. We could deprecate all old DescriptionElement-methods and reactor all callers to use the new service.</p>
<p>That we are having DescriptionElementService now offers to options to use the polymorphism also for the DescriptionElementController which could not be bases on the AbstractIdentifiableController so far.</p>
EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=644282022-01-27T15:23:02ZAndreas Müller
<ul><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Andreas Kohlbecker</i></li></ul><p>Andreas Kohlbecker wrote in <a href="#note-8">#note-8</a>:</p>
<blockquote>
<p>This ticket is fairly old. The DescriptionElementService functionality once has been implemented into the <code>DescriptionServiceImpl</code>. Now we have two services for DescriptionElements. I am bit undecided how to deal with this situation. We could deprecate all old DescriptionElement-methods and reactor all callers to use the new service.</p>
<p>That we are having DescriptionElementService now offers to options to use the polymorphism also for the DescriptionElementController which could not be bases on the AbstractIdentifiableController so far.</p>
</blockquote>
<p>I do not fully understand this answer. Have you looked at the code? I already removed the old methods. So they are not only deprecated but removed. All controllers are using the new methods already.<br>
However, I did not check yet, if there might be more methods that need to be moved.</p>
EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=645142022-02-15T14:41:56ZAndreas Müller
<ul><li><strong>Target version</strong> changed from <i>Release 5.45</i> to <i>Release 5.29</i></li></ul> EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=645912022-02-17T12:01:09ZAndreas Müller
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-6 status-1 priority-11 priority-default" href="/redmine/issues/9944">task #9944</a>: Move further methods from DescriptionService to DescriptionElementService</i> added</li></ul> EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=645942022-02-17T12:03:30ZAndreas Müller
<ul><li><strong>% Done</strong> changed from <i>50</i> to <i>90</i></li></ul><p>I created a new ticket for moving further methods to the new service (<a class="issue tracker-6 status-1 priority-11 priority-default" title="task: Move further methods from DescriptionService to DescriptionElementService (New)" href="https://dev.e-taxonomy.eu/redmine/issues/9944">#9944</a>).</p>
<p>Can we close this ticket now?</p>
EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=645952022-02-17T12:28:52ZAndreas Kohlbecker
<ul><li><strong>Assignee</strong> changed from <i>Andreas Kohlbecker</i> to <i>Andreas Müller</i></li></ul><p>I think the method <code>public Pager<Annotation> getDescriptionElementAnnotations()</code> just duplicates the method <code>public Pager<Annotation> getAnnotations()</code> in the base class and therefore is redundant - We should remove it if I am right, or deprecate it and delegate all calls to <code>getAnnotations</code> </p>
<p>Aside from this the ticket can be closed.</p>
EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=646032022-02-18T12:19:15ZAndreas Müller
<ul><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Andreas Kohlbecker</i></li></ul><p>Good point. I removed the method from the service and from the 2 calling controllers and started new build. Can you please verify that everything works as expected for the webservices/dataportal and then close the ticket?</p>
EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=646042022-02-18T13:05:26ZAndreas Kohlbecker
<ul><li><strong>Assignee</strong> changed from <i>Andreas Kohlbecker</i> to <i>Andreas Müller</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul><p>looks good now! Ticket can be closed.</p>
<p>The DescriptionElementController can now be modified like :</p>
<pre><code class="java syntaxhl"><span class="kd">class</span> <span class="nc">DescriptionElementController</span> <span class="kd">extends</span> <span class="nc">AbstractIdentifiableController</span><span class="o"><</span><span class="nc">DescriptionElementBase</span><span class="o">,</span> <span class="nc">IDescriptionElementService</span><span class="o">></span>
</code></pre>
<p>This allows to remove the <code>doGetDescriptionElementAnnotations()</code> method which is provided bv the BaseController for free.<br>
You may want to create a ticket for this it it does not exist</p>
EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=646052022-02-18T14:10:13ZAndreas Müller
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-4 status-1 priority-11 priority-default" href="/redmine/issues/9947">bug #9947</a>: Make DescriptionElementController inherit from base controller and remove doGetDescriptionElementAnnotations</i> added</li></ul> EDIT - feature request #694: FeatureTreeService and DescriptionElement implementedhttps://dev.e-taxonomy.eu/redmine/issues/694?journal_id=646072022-02-18T14:16:26ZAndreas Müller
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Closed</i></li></ul><p>Andreas Kohlbecker wrote in <a href="#note-15">#note-15</a>:</p>
<blockquote>
<p>The DescriptionElementController can now be modified like :</p>
<pre><code class="java syntaxhl"><span class="kd">class</span> <span class="nc">DescriptionElementController</span> <span class="kd">extends</span> <span class="nc">AbstractIdentifiableController</span><span class="o"><</span><span class="nc">DescriptionElementBase</span><span class="o">,</span> <span class="nc">IDescriptionElementService</span><span class="o">></span>
</code></pre>
<p>This allows to remove the <code>doGetDescriptionElementAnnotations()</code> method which is provided bv the BaseController for free.<br>
You may want to create a ticket for this it it does not exist</p>
</blockquote>
<p>I don't think it can inherit from AbstractIdentifiableController as it DescriptionElementBase is not Identifiable.</p>
<p>But I created a new ticket <a class="issue tracker-4 status-1 priority-11 priority-default" title="bug: Make DescriptionElementController inherit from base controller and remove doGetDescriptionElement... (New)" href="https://dev.e-taxonomy.eu/redmine/issues/9947">#9947</a> and already made the controller inherit from BaseController class.<br>
All further discussions on this issue in the new ticket.</p>