Edit

I did it on my workspace but deleted the workbench.xmi

In the new bulk editor it is not possible anymore to copy the text of the entries (or part of the text). This is an important feature for some workflows and should be re-enabled if possible.

Patrick Plitzner wrote:

Andreas Müller wrote:

In the new bulk editor it is not possible anymore to copy the text of the entries (or part of the text). This is an important feature for some workflows and should be re-enabled if possible.

I added a second column for type information and also enabled text selection

But now it is possible to edit the text. It is not possible to save, but this is confusing for the user

And when selecting one of the columns, not the whole row the menu is the one to edit strings (copy, delete, unicode Steuerzeichen anzeigen etc), maybe we should disable everything other than copy in this menu, because it has no effect on the data.

Katja Luther wrote:

Patrick Plitzner wrote:

Andreas Müller wrote:

In the new bulk editor it is not possible anymore to copy the text of the entries (or part of the text). This is an important feature for some workflows and should be re-enabled if possible.

I added a second column for type information and also enabled text selection

But now it is possible to edit the text. It is not possible to save, but this is confusing for the user

And when selecting one of the columns, not the whole row the menu is the one to edit strings (copy, delete, unicode Steuerzeichen anzeigen etc), maybe we should disable everything other than copy in this menu, because it has no effect on the data.

It is the same behavior as in the referencing objects view. It is not possible to edit the text because all changes are rejected. This is currently the only way I know which lets you select only parts of the text. I agree that it does not look nice. If copying the whole text is sufficient then I would also prefer that.

I don't know if this is an old issue: when bulk editor is not saved and you try to deduplicate entries, a message pops up, that the merging can't be perfomed without saving. Clicking on save, saves everything but the annotations are gone and a message that says that nothing was marked for deduplication appears.

Patrick Plitzner wrote:

Katja Luther wrote:

Patrick Plitzner wrote:

Andreas Müller wrote:

In the new bulk editor it is not possible anymore to copy the text of the entries (or part of the text). This is an important feature for some workflows and should be re-enabled if possible.

I added a second column for type information and also enabled text selection

But now it is possible to edit the text. It is not possible to save, but this is confusing for the user

And when selecting one of the columns, not the whole row the menu is the one to edit strings (copy, delete, unicode Steuerzeichen anzeigen etc), maybe we should disable everything other than copy in this menu, because it has no effect on the data.

It is the same behavior as in the referencing objects view. It is not possible to edit the text because all changes are rejected. This is currently the only way I know which lets you select only parts of the text. I agree that it does not look nice. If copying the whole text is sufficient then I would also prefer that.

Sometimes there is a distinction between editable and enabled, I used that for the synoyms in the name editor. But I don't know if it possible here.

Another issue is the performance: The old bulk editor marked every item that was changed as "mergeable" and during save, only for the mergeable object merge was called.

I think the new bulk editor calls the merge twice, first time in input.saveModel() and again with the input of the viewer which should be the same.

Katja Luther wrote:

Another issue is the performance: The old bulk editor marked every item that was changed as "mergeable" and during save, only for the mergeable object merge was called.

I think the new bulk editor calls the merge twice, first time in input.saveModel() and again with the input of the viewer which should be the same.

I fixed this.

calling the search a second time, the search is not performed on the db. That's why I did not recognized, that the save did not work.

It looks like the search result at least in taxon bulk editor is not ordered. But maybe this was the case in e3 already. Is this easy to implement?

Patrick Plitzner wrote:

I reverted the changes so not saving works again. We should have a look at the performance after the release

why is it difficult to implement this same as in e3? The bad performance is a bit critical. I got an Stack Overflow when I tried to save with a bulk editor with ~1400 taxa loaded. But only 1 taxon edited.

If one adds a marker via bulk editor this is generally immediately reflected in the supplemental data view, only the + behind the marker section label is not activated if there was no marker before. Feel free to create new ticket as this probably wasn't the case before. Also not very important.

In taxon bulk editor, when clicking in details view on taxon or synonym section label to try to collapse or expand it the details view becomes completely empty. This is a regression.

Andreas Müller wrote:

In taxon bulk editor, when clicking in details view on taxon or synonym section label to try to collapse or expand it the details view becomes completely empty. This is a regression.

This is also the case for other sections in other bulk editors detail views.

Andreas Müller wrote:

This is also the case for other sections in other bulk editors detail views.

It is even the case for all elements in the details view, BUT only if no name editor is opened in parallel. If a name editor is open the bulk editor works as expected.

If I do re-search in bulk editor with no save than the dirty flag is not set back but should as the search should start a new session.

Katja Luther wrote:

It is the same behavior as in the referencing objects view. It is not possible to edit the text because all changes are rejected. This is currently the only way I know which lets you select only parts of the text. I agree that it does not look nice. If copying the whole text is sufficient then I would also prefer that.

Sometimes there is a distinction between editable and enabled, I used that for the synoyms in the name editor. But I don't know if it possible here.

Now it is still not possible to copy the text, neither in parts nor complete. We should try to change this.

It is not possible anymore to select multiple row for select/deselect for deduplication candidate

Changing a person to a team (1) has no visible effect. But after research the result is correct. The same applies for changing team to person (2).

In v4.10 changing team to person required save after the call (with dirty flag set). This is the expected behavior as it is in consistency with deduplication. This is currently missing in nightly.

Changing person to team did not set the dirty flag and did not require save in 4.10 as it does in nightly, but it should. But maybe there was a reason for the current behavior or we did just forget to implement it correctly. Katja?

Andreas Müller wrote:

In taxon bulk editor, when clicking in details view on taxon or synonym section label to try to collapse or expand it the details view becomes completely empty. This is a regression.

Andreas Müller wrote:

Changing a person to a team (1) has no visible effect. But after research the result is correct. The same applies for changing team to person (2).

In v4.10 changing team to person required save after the call (with dirty flag set). This is the expected behavior as it is in consistency with deduplication. This is currently missing in nightly.

Changing person to team did not set the dirty flag and did not require save in 4.10 as it does in nightly, but it should. But maybe there was a reason for the current behavior or we did just forget to implement it correctly. Katja?

This already worked, but now the changed team/person disappeaers after research???

Andreas Müller wrote:

If I do research in bulk editor with no save than the dirty flag is not set back but should as the search should start a new session.

fixed

saving and sorting of taxa is fixed or improved

If a record is selected as target for duplicate removal it is not possible to directly remove it as target again. If you want to remove you first have to make it candidate and than you remove it completely.

one click on a record immediately goes into editing mode (enabled only for copy functionality). This is critical as usually one wants to use the context menu in bulk editor which is not available anymore in editing mode.

• Solutions could be: go in editing mode only by double click (preferred)
• adapt context menu for editing mode (if possible, e.g. use same context menu as in non-editing mode, by add "copy" command)

save of the bulk editor only saves the edited elements now.

multi selection for deduplication is now available again

Multi selection is generally handled in #7010.

Are there any other open issues?

When closing this ticket please also close master ticket as this is the last ticket not closed yet.