Project

General

Profile

Actions

feature request #6932

closed

feature request #6565: [MASTER] Eclipse 4 Migration

Migrate bulk editor

Added by Patrick Plitzner about 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
New
Assignee:
Patrick Plitzner
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
blocker
Tags:

Related issues

Related to EDIT - feature request #7010: Adapt handlers for multiple selection in e4 viewsClosedPatrick Plitzner

Actions
Actions #1

Updated by Patrick Plitzner about 5 years ago

  • Target version changed from Release 4.10 to Release 4.11
Actions #2

Updated by Patrick Plitzner about 5 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions #3

Updated by Patrick Plitzner about 5 years ago

  • Assignee changed from Patrick Plitzner to Katja Luther
Actions #4

Updated by Katja Luther about 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Katja Luther to Patrick Plitzner

in name bulk editor there is the possibility to deduplicate, but we do not have deduplication for names yet.

in old bulk editor we did a new search after saving, we should do this in the new one, too.

the deduplication for persons does not work.

Didn't we had the type of TeamOrPerson in brackets behind the title (like A. Kern [Person]) this was nice to see where we have to change the type

Actions #5

Updated by Patrick Plitzner about 5 years ago

  • Assignee changed from Patrick Plitzner to Katja Luther

Katja Luther wrote:

in name bulk editor there is the possibility to deduplicate, but we do not have deduplication for names yet.

in old bulk editor we did a new search after saving, we should do this in the new one, too.

the deduplication for persons does not work.

Didn't we had the type of TeamOrPerson in brackets behind the title (like A. Kern [Person]) this was nice to see where we have to change the type

Did you delete the workbench.xmi? There is no deduplication for names in my workspace. I also tested deduplication for persons and it worked. Did you test on nightly?

Actions #6

Updated by Katja Luther about 5 years ago

I did it on my workspace but deleted the workbench.xmi

Actions #7

Updated by Patrick Plitzner about 5 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Patrick Plitzner

I tried in nightly. In name bulk editor there is no deduplication menu item.
But it is true that deduplication does not work correctly for persons. Hmm, but in my workspace it does...

Actions #8

Updated by Andreas Müller about 5 years ago

  • Status changed from Resolved to Feedback
Actions #9

Updated by Andreas Müller about 5 years ago

In the new bulk editor it is not possible anymore to copy the text of the entries (or part of the text). This is an important feature for some workflows and should be re-enabled if possible.

Actions #10

Updated by Patrick Plitzner about 5 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller

Andreas Müller wrote:

In the new bulk editor it is not possible anymore to copy the text of the entries (or part of the text). This is an important feature for some workflows and should be re-enabled if possible.

I added a second column for type information and also enabled text selection

Actions #11

Updated by Katja Luther about 5 years ago

Patrick Plitzner wrote:

Andreas Müller wrote:

In the new bulk editor it is not possible anymore to copy the text of the entries (or part of the text). This is an important feature for some workflows and should be re-enabled if possible.

I added a second column for type information and also enabled text selection

But now it is possible to edit the text. It is not possible to save, but this is confusing for the user

And when selecting one of the columns, not the whole row the menu is the one to edit strings (copy, delete, unicode Steuerzeichen anzeigen etc), maybe we should disable everything other than copy in this menu, because it has no effect on the data.

Actions #12

Updated by Patrick Plitzner about 5 years ago

Katja Luther wrote:

Patrick Plitzner wrote:

Andreas Müller wrote:

In the new bulk editor it is not possible anymore to copy the text of the entries (or part of the text). This is an important feature for some workflows and should be re-enabled if possible.

I added a second column for type information and also enabled text selection

But now it is possible to edit the text. It is not possible to save, but this is confusing for the user

And when selecting one of the columns, not the whole row the menu is the one to edit strings (copy, delete, unicode Steuerzeichen anzeigen etc), maybe we should disable everything other than copy in this menu, because it has no effect on the data.

It is the same behavior as in the referencing objects view. It is not possible to edit the text because all changes are rejected. This is currently the only way I know which lets you select only parts of the text. I agree that it does not look nice. If copying the whole text is sufficient then I would also prefer that.

Actions #13

Updated by Katja Luther about 5 years ago

I don't know if this is an old issue: when bulk editor is not saved and you try to deduplicate entries, a message pops up, that the merging can't be perfomed without saving. Clicking on save, saves everything but the annotations are gone and a message that says that nothing was marked for deduplication appears.

Actions #14

Updated by Katja Luther about 5 years ago

Patrick Plitzner wrote:

Katja Luther wrote:

Patrick Plitzner wrote:

Andreas Müller wrote:

In the new bulk editor it is not possible anymore to copy the text of the entries (or part of the text). This is an important feature for some workflows and should be re-enabled if possible.

I added a second column for type information and also enabled text selection

But now it is possible to edit the text. It is not possible to save, but this is confusing for the user

And when selecting one of the columns, not the whole row the menu is the one to edit strings (copy, delete, unicode Steuerzeichen anzeigen etc), maybe we should disable everything other than copy in this menu, because it has no effect on the data.

It is the same behavior as in the referencing objects view. It is not possible to edit the text because all changes are rejected. This is currently the only way I know which lets you select only parts of the text. I agree that it does not look nice. If copying the whole text is sufficient then I would also prefer that.

Sometimes there is a distinction between editable and enabled, I used that for the synoyms in the name editor. But I don't know if it possible here.

Actions #15

Updated by Katja Luther about 5 years ago

Another issue is the performance: The old bulk editor marked every item that was changed as "mergeable" and during save, only for the mergeable object merge was called.

I think the new bulk editor calls the merge twice, first time in input.saveModel() and again with the input of the viewer which should be the same.

Actions #16

Updated by Katja Luther about 5 years ago

Katja Luther wrote:

Another issue is the performance: The old bulk editor marked every item that was changed as "mergeable" and during save, only for the mergeable object merge was called.

I think the new bulk editor calls the merge twice, first time in input.saveModel() and again with the input of the viewer which should be the same.

I fixed this.

Actions #17

Updated by Andreas Müller about 5 years ago

  • Assignee changed from Andreas Müller to Patrick Plitzner
  • Severity changed from normal to blocker

Now the bulk editor does not save anymore !!! Changes are not persisted!

This is a blocker and should be fixed asap. Maybe this came with the performance improvements?

Actions #18

Updated by Andreas Müller about 5 years ago

  • Status changed from Resolved to Feedback
Actions #19

Updated by Patrick Plitzner about 5 years ago

  • Assignee changed from Patrick Plitzner to Katja Luther

I reverted the changes so not saving works again. We should have a look at the performance after the release

Actions #20

Updated by Katja Luther about 5 years ago

calling the search a second time, the search is not performed on the db. That's why I did not recognized, that the save did not work.

Actions #21

Updated by Katja Luther about 5 years ago

  • Assignee changed from Katja Luther to Patrick Plitzner
Actions #22

Updated by Patrick Plitzner about 5 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Katja Luther
  • % Done changed from 50 to 70

Katja Luther wrote:

calling the search a second time, the search is not performed on the db. That's why I did not recognized, that the save did not work.

This should work now. At least now it is the same code as in e3

Actions #23

Updated by Katja Luther about 5 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 70 to 100

works fine now.

Actions #24

Updated by Andreas Müller about 5 years ago

  • Status changed from Closed to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
Actions #25

Updated by Andreas Müller about 5 years ago

It looks like the search result at least in taxon bulk editor is not ordered. But maybe this was the case in e3 already. Is this easy to implement?

Actions #26

Updated by Andreas Müller about 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

The bulk editor is not synchronized when data is changed in details view. This was the case in e3 (v4.10). We should try to fix this before the release.

Actions #27

Updated by Andreas Müller about 5 years ago

Patrick Plitzner wrote:

I reverted the changes so not saving works again. We should have a look at the performance after the release

why is it difficult to implement this same as in e3? The bad performance is a bit critical. I got an Stack Overflow when I tried to save with a bulk editor with ~1400 taxa loaded. But only 1 taxon edited.

Actions #28

Updated by Andreas Müller about 5 years ago

If one adds a marker via bulk editor this is generally immediately reflected in the supplemental data view, only the + behind the marker section label is not activated if there was no marker before. Feel free to create new ticket as this probably wasn't the case before. Also not very important.

Actions #29

Updated by Andreas Müller about 5 years ago

In taxon bulk editor, when clicking in details view on taxon or synonym section label to try to collapse or expand it the details view becomes completely empty. This is a regression.

Actions #30

Updated by Andreas Müller about 5 years ago

Andreas Müller wrote:

In taxon bulk editor, when clicking in details view on taxon or synonym section label to try to collapse or expand it the details view becomes completely empty. This is a regression.

This is also the case for other sections in other bulk editors detail views.

Actions #31

Updated by Andreas Müller about 5 years ago

Andreas Müller wrote:

This is also the case for other sections in other bulk editors detail views.

It is even the case for all elements in the details view, BUT only if no name editor is opened in parallel. If a name editor is open the bulk editor works as expected.

Actions #32

Updated by Andreas Müller about 5 years ago

If I do re-search in bulk editor with no save than the dirty flag is not set back but should as the search should start a new session.

Actions #33

Updated by Andreas Müller about 5 years ago

Katja Luther wrote:

It is the same behavior as in the referencing objects view. It is not possible to edit the text because all changes are rejected. This is currently the only way I know which lets you select only parts of the text. I agree that it does not look nice. If copying the whole text is sufficient then I would also prefer that.

Sometimes there is a distinction between editable and enabled, I used that for the synoyms in the name editor. But I don't know if it possible here.

Now it is still not possible to copy the text, neither in parts nor complete. We should try to change this.

Actions #34

Updated by Andreas Müller about 5 years ago

It is not possible anymore to select multiple row for select/deselect for deduplication candidate

Actions #35

Updated by Andreas Müller about 5 years ago

Changing a person to a team (1) has no visible effect. But after research the result is correct. The same applies for changing team to person (2).

In v4.10 changing team to person required save after the call (with dirty flag set). This is the expected behavior as it is in consistency with deduplication. This is currently missing in nightly.

Changing person to team did not set the dirty flag and did not require save in 4.10 as it does in nightly, but it should. But maybe there was a reason for the current behavior or we did just forget to implement it correctly. Katja?

Actions #36

Updated by Katja Luther about 5 years ago

Andreas Müller wrote:

In taxon bulk editor, when clicking in details view on taxon or synonym section label to try to collapse or expand it the details view becomes completely empty. This is a regression.

Actions #37

Updated by Katja Luther about 5 years ago

Andreas Müller wrote:

Changing a person to a team (1) has no visible effect. But after research the result is correct. The same applies for changing team to person (2).

In v4.10 changing team to person required save after the call (with dirty flag set). This is the expected behavior as it is in consistency with deduplication. This is currently missing in nightly.

Changing person to team did not set the dirty flag and did not require save in 4.10 as it does in nightly, but it should. But maybe there was a reason for the current behavior or we did just forget to implement it correctly. Katja?

This already worked, but now the changed team/person disappeaers after research???

Actions #38

Updated by Katja Luther about 5 years ago

Andreas Müller wrote:

If I do research in bulk editor with no save than the dirty flag is not set back but should as the search should start a new session.

fixed

Actions #39

Updated by Katja Luther about 5 years ago

saving and sorting of taxa is fixed or improved

Actions #40

Updated by Andreas Müller about 5 years ago

If a record is selected as target for duplicate removal it is not possible to directly remove it as target again. If you want to remove you first have to make it candidate and than you remove it completely.

Actions #41

Updated by Andreas Müller about 5 years ago

one click on a record immediately goes into editing mode (enabled only for copy functionality). This is critical as usually one wants to use the context menu in bulk editor which is not available anymore in editing mode.

  • Solutions could be: go in editing mode only by double click (preferred)
  • adapt context menu for editing mode (if possible, e.g. use same context menu as in non-editing mode, by add "copy" command)
Actions #42

Updated by Katja Luther about 5 years ago

  • Status changed from Feedback to In Progress
  • Assignee changed from Patrick Plitzner to Katja Luther

after deduplication the symbol of the target does not disappear

Actions #43

Updated by Katja Luther about 5 years ago

save of the bulk editor only saves the edited elements now.

Actions #44

Updated by Katja Luther about 5 years ago

multi selection for deduplication is now available again

Actions #45

Updated by Katja Luther almost 5 years ago

  • Status changed from In Progress to Resolved

the entities are only selected by double click.

Actions #46

Updated by Katja Luther almost 5 years ago

  • Assignee changed from Katja Luther to Andreas Müller
Actions #47

Updated by Patrick Plitzner over 4 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Patrick Plitzner

The E4 migration has been done up to a sufficient state.
Remaining issues should be handled in separate tickets.

Actions #48

Updated by Andreas Müller over 4 years ago

  • Status changed from Closed to Feedback
  • Assignee changed from Patrick Plitzner to Katja Luther

I think we should first create a ticket with the remaining issues before closing. Otherwise the information will get lost.

Katja, could you create the ticket as most of the comments and also part of the implementation are yours? And close this ticket afterwards.

By the way, multi-select still does not work for me.

Actions #49

Updated by Andreas Müller over 4 years ago

  • % Done changed from 100 to 90
Actions #50

Updated by Andreas Müller over 4 years ago

Actions #51

Updated by Andreas Müller over 4 years ago

Multi selection is generally handled in #7010.

Are there any other open issues?

When closing this ticket please also close master ticket as this is the last ticket not closed yet.

Actions #52

Updated by Andreas Müller over 4 years ago

  • Status changed from Feedback to Closed
  • Assignee changed from Katja Luther to Patrick Plitzner
  • % Done changed from 90 to 100

Close this ticket as bulk editor has new developments like NAT tables and parallel loading anyways.

Actions

Also available in: Atom PDF