feature request #6932
feature request #6565: [MASTER] Eclipse 4 Migration
Migrate bulk editor
100%
Related issues
Associated revisions
ref #6932 Migrate bulk editor (non-stable)
ref #6932 Migrate bulk editor (search and results display working)
ref #6932 Migrate bulk context menu (non-functional)
ref #6932 Migrate bulk editor handlers (part I)
ref #6932 Migrate bulk editor handlers and add annotation merge support
ref #6932 Fix intitial layouting of bulk editor
ref #6932 Add non-restore tag to bulk editor
ref #6932 Fix new element handler and save
ref #6932 further migration of handlers
ref #6932 Ask before permanent delete
ref #6932 Refactor merge annotating
ref #6932 Refactor merge and delete handler
ref #6932 Migrate merge handlers
ref #6932 Add "Open in..." menu
ref #6932 Asjust menu item visibility
ref #6932 Migrate marker type handler
ref #6932 Remove unused code
ref #6932 Add missing bulk editor menu items
ref #6932 Retrieve missing taxon service for saving in bulk editor
ref #6932 Enable supplemental view for bulk editor
ref #6932 Use getText() of editor input for labels
ref #6932 enhancements for bulk editor
- i18n
- set part label
- evaluate condition for merge menu items
ref #6932 add type info to bulk editor
ref #6932 Allow text selection in bulk editor
- show type information in second column
ref #6932 Do not reset merge candidates when saving before merge
ref #6932: remove second call of merge in bulkeditor
ref #6932 Revert "remove second call of merge in bulkeditor"
ref #6932 Invoke search in new session
ref #6932 Disable focus service for bulk editor
ref #6932: remove dirty flag when research without saving
ref #6932 Re-enable text selection in bulk editor
ref #6932: fix taxon bulk editor is sorted
ref #6932: save the complete list with one service call
save only dirty elements of the bulkeditor
reset saveCandidate list after save
fix save for bulkeditor
ref #6932: allow multiselection for deduplication
ref #6932: allow multiselection for deduplication
fix #6392: fix remaining bulk editor migration issues
History
#1 Updated by Patrick Plitzner almost 4 years ago
- Target version changed from Release 4.10 to Release 4.11
#2 Updated by Patrick Plitzner almost 4 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 50
#3 Updated by Patrick Plitzner almost 4 years ago
- Assignee changed from Patrick Plitzner to Katja Luther
#4 Updated by Katja Luther almost 4 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Katja Luther to Patrick Plitzner
in name bulk editor there is the possibility to deduplicate, but we do not have deduplication for names yet.
in old bulk editor we did a new search after saving, we should do this in the new one, too.
the deduplication for persons does not work.
Didn't we had the type of TeamOrPerson in brackets behind the title (like A. Kern [Person]) this was nice to see where we have to change the type
#5 Updated by Patrick Plitzner almost 4 years ago
- Assignee changed from Patrick Plitzner to Katja Luther
Katja Luther wrote:
in name bulk editor there is the possibility to deduplicate, but we do not have deduplication for names yet.
in old bulk editor we did a new search after saving, we should do this in the new one, too.
the deduplication for persons does not work.
Didn't we had the type of TeamOrPerson in brackets behind the title (like A. Kern [Person]) this was nice to see where we have to change the type
Did you delete the workbench.xmi? There is no deduplication for names in my workspace. I also tested deduplication for persons and it worked. Did you test on nightly?
#6 Updated by Katja Luther almost 4 years ago
I did it on my workspace but deleted the workbench.xmi
#7 Updated by Patrick Plitzner almost 4 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Katja Luther to Patrick Plitzner
I tried in nightly. In name bulk editor there is no deduplication menu item.
But it is true that deduplication does not work correctly for persons. Hmm, but in my workspace it does...
#8 Updated by Andreas Müller almost 4 years ago
- Status changed from Resolved to Feedback
#9 Updated by Andreas Müller almost 4 years ago
In the new bulk editor it is not possible anymore to copy the text of the entries (or part of the text). This is an important feature for some workflows and should be re-enabled if possible.
#10 Updated by Patrick Plitzner almost 4 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Patrick Plitzner to Andreas Müller
Andreas Müller wrote:
In the new bulk editor it is not possible anymore to copy the text of the entries (or part of the text). This is an important feature for some workflows and should be re-enabled if possible.
I added a second column for type information and also enabled text selection
#11 Updated by Katja Luther almost 4 years ago
Patrick Plitzner wrote:
Andreas Müller wrote:
In the new bulk editor it is not possible anymore to copy the text of the entries (or part of the text). This is an important feature for some workflows and should be re-enabled if possible.
I added a second column for type information and also enabled text selection
But now it is possible to edit the text. It is not possible to save, but this is confusing for the user
And when selecting one of the columns, not the whole row the menu is the one to edit strings (copy, delete, unicode Steuerzeichen anzeigen etc), maybe we should disable everything other than copy in this menu, because it has no effect on the data.
#12 Updated by Patrick Plitzner almost 4 years ago
Katja Luther wrote:
Patrick Plitzner wrote:
Andreas Müller wrote:
In the new bulk editor it is not possible anymore to copy the text of the entries (or part of the text). This is an important feature for some workflows and should be re-enabled if possible.
I added a second column for type information and also enabled text selection
But now it is possible to edit the text. It is not possible to save, but this is confusing for the user
And when selecting one of the columns, not the whole row the menu is the one to edit strings (copy, delete, unicode Steuerzeichen anzeigen etc), maybe we should disable everything other than copy in this menu, because it has no effect on the data.
It is the same behavior as in the referencing objects view. It is not possible to edit the text because all changes are rejected. This is currently the only way I know which lets you select only parts of the text. I agree that it does not look nice. If copying the whole text is sufficient then I would also prefer that.
#13 Updated by Katja Luther almost 4 years ago
I don't know if this is an old issue: when bulk editor is not saved and you try to deduplicate entries, a message pops up, that the merging can't be perfomed without saving. Clicking on save, saves everything but the annotations are gone and a message that says that nothing was marked for deduplication appears.
#14 Updated by Katja Luther almost 4 years ago
Patrick Plitzner wrote:
Katja Luther wrote:
Patrick Plitzner wrote:
Andreas Müller wrote:
In the new bulk editor it is not possible anymore to copy the text of the entries (or part of the text). This is an important feature for some workflows and should be re-enabled if possible.
I added a second column for type information and also enabled text selection
But now it is possible to edit the text. It is not possible to save, but this is confusing for the user
And when selecting one of the columns, not the whole row the menu is the one to edit strings (copy, delete, unicode Steuerzeichen anzeigen etc), maybe we should disable everything other than copy in this menu, because it has no effect on the data.
It is the same behavior as in the referencing objects view. It is not possible to edit the text because all changes are rejected. This is currently the only way I know which lets you select only parts of the text. I agree that it does not look nice. If copying the whole text is sufficient then I would also prefer that.
Sometimes there is a distinction between editable and enabled, I used that for the synoyms in the name editor. But I don't know if it possible here.
#15 Updated by Katja Luther almost 4 years ago
Another issue is the performance: The old bulk editor marked every item that was changed as "mergeable" and during save, only for the mergeable object merge was called.
I think the new bulk editor calls the merge twice, first time in input.saveModel() and again with the input of the viewer which should be the same.
#16 Updated by Katja Luther almost 4 years ago
Katja Luther wrote:
Another issue is the performance: The old bulk editor marked every item that was changed as "mergeable" and during save, only for the mergeable object merge was called.
I think the new bulk editor calls the merge twice, first time in input.saveModel() and again with the input of the viewer which should be the same.
I fixed this.
#17 Updated by Andreas Müller almost 4 years ago
- Assignee changed from Andreas Müller to Patrick Plitzner
- Severity changed from normal to blocker
Now the bulk editor does not save anymore !!! Changes are not persisted!
This is a blocker and should be fixed asap. Maybe this came with the performance improvements?
#18 Updated by Andreas Müller almost 4 years ago
- Status changed from Resolved to Feedback
#19 Updated by Patrick Plitzner almost 4 years ago
- Assignee changed from Patrick Plitzner to Katja Luther
I reverted the changes so not saving works again. We should have a look at the performance after the release
#20 Updated by Katja Luther almost 4 years ago
calling the search a second time, the search is not performed on the db. That's why I did not recognized, that the save did not work.
#21 Updated by Katja Luther almost 4 years ago
- Assignee changed from Katja Luther to Patrick Plitzner
#22 Updated by Patrick Plitzner almost 4 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Patrick Plitzner to Katja Luther
- % Done changed from 50 to 70
Katja Luther wrote:
calling the search a second time, the search is not performed on the db. That's why I did not recognized, that the save did not work.
This should work now. At least now it is the same code as in e3
#23 Updated by Katja Luther over 3 years ago
- Status changed from Resolved to Closed
- % Done changed from 70 to 100
works fine now.
#24 Updated by Andreas Müller over 3 years ago
- Status changed from Closed to Resolved
- Assignee changed from Katja Luther to Andreas Müller
#25 Updated by Andreas Müller over 3 years ago
It looks like the search result at least in taxon bulk editor is not ordered. But maybe this was the case in e3 already. Is this easy to implement?
#26 Updated by Andreas Müller over 3 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Patrick Plitzner
The bulk editor is not synchronized when data is changed in details view. This was the case in e3 (v4.10). We should try to fix this before the release.
#27 Updated by Andreas Müller over 3 years ago
Patrick Plitzner wrote:
I reverted the changes so not saving works again. We should have a look at the performance after the release
why is it difficult to implement this same as in e3? The bad performance is a bit critical. I got an Stack Overflow when I tried to save with a bulk editor with ~1400 taxa loaded. But only 1 taxon edited.
#28 Updated by Andreas Müller over 3 years ago
If one adds a marker via bulk editor this is generally immediately reflected in the supplemental data view, only the + behind the marker section label is not activated if there was no marker before. Feel free to create new ticket as this probably wasn't the case before. Also not very important.
#29 Updated by Andreas Müller over 3 years ago
In taxon bulk editor, when clicking in details view on taxon or synonym section label to try to collapse or expand it the details view becomes completely empty. This is a regression.
#30 Updated by Andreas Müller over 3 years ago
Andreas Müller wrote:
In taxon bulk editor, when clicking in details view on taxon or synonym section label to try to collapse or expand it the details view becomes completely empty. This is a regression.
This is also the case for other sections in other bulk editors detail views.
#31 Updated by Andreas Müller over 3 years ago
Andreas Müller wrote:
This is also the case for other sections in other bulk editors detail views.
It is even the case for all elements in the details view, BUT only if no name editor is opened in parallel. If a name editor is open the bulk editor works as expected.
#32 Updated by Andreas Müller over 3 years ago
If I do re-search in bulk editor with no save than the dirty flag is not set back but should as the search should start a new session.
#33 Updated by Andreas Müller over 3 years ago
Katja Luther wrote:
It is the same behavior as in the referencing objects view. It is not possible to edit the text because all changes are rejected. This is currently the only way I know which lets you select only parts of the text. I agree that it does not look nice. If copying the whole text is sufficient then I would also prefer that.
Sometimes there is a distinction between editable and enabled, I used that for the synoyms in the name editor. But I don't know if it possible here.
Now it is still not possible to copy the text, neither in parts nor complete. We should try to change this.
#34 Updated by Andreas Müller over 3 years ago
It is not possible anymore to select multiple row for select/deselect for deduplication candidate
#35 Updated by Andreas Müller over 3 years ago
Changing a person to a team (1) has no visible effect. But after research the result is correct. The same applies for changing team to person (2).
In v4.10 changing team to person required save after the call (with dirty flag set). This is the expected behavior as it is in consistency with deduplication. This is currently missing in nightly.
Changing person to team did not set the dirty flag and did not require save in 4.10 as it does in nightly, but it should. But maybe there was a reason for the current behavior or we did just forget to implement it correctly. Katja?
#36 Updated by Katja Luther over 3 years ago
Andreas Müller wrote:
In taxon bulk editor, when clicking in details view on taxon or synonym section label to try to collapse or expand it the details view becomes completely empty. This is a regression.
#37 Updated by Katja Luther over 3 years ago
Andreas Müller wrote:
Changing a person to a team (1) has no visible effect. But after research the result is correct. The same applies for changing team to person (2).
In v4.10 changing team to person required save after the call (with dirty flag set). This is the expected behavior as it is in consistency with deduplication. This is currently missing in nightly.
Changing person to team did not set the dirty flag and did not require save in 4.10 as it does in nightly, but it should. But maybe there was a reason for the current behavior or we did just forget to implement it correctly. Katja?
This already worked, but now the changed team/person disappeaers after research???
#38 Updated by Katja Luther over 3 years ago
Andreas Müller wrote:
If I do research in bulk editor with no save than the dirty flag is not set back but should as the search should start a new session.
fixed
#39 Updated by Katja Luther over 3 years ago
saving and sorting of taxa is fixed or improved
#40 Updated by Andreas Müller over 3 years ago
If a record is selected as target for duplicate removal it is not possible to directly remove it as target again. If you want to remove you first have to make it candidate and than you remove it completely.
#41 Updated by Andreas Müller over 3 years ago
one click on a record immediately goes into editing mode (enabled only for copy functionality). This is critical as usually one wants to use the context menu in bulk editor which is not available anymore in editing mode.
- Solutions could be: go in editing mode only by double click (preferred)
- adapt context menu for editing mode (if possible, e.g. use same context menu as in non-editing mode, by add "copy" command)
#42 Updated by Katja Luther over 3 years ago
- Status changed from Feedback to In Progress
- Assignee changed from Patrick Plitzner to Katja Luther
after deduplication the symbol of the target does not disappear
#43 Updated by Katja Luther over 3 years ago
save of the bulk editor only saves the edited elements now.
#44 Updated by Katja Luther over 3 years ago
multi selection for deduplication is now available again
#45 Updated by Katja Luther over 3 years ago
- Status changed from In Progress to Resolved
the entities are only selected by double click.
#46 Updated by Katja Luther over 3 years ago
- Assignee changed from Katja Luther to Andreas Müller
#47 Updated by Patrick Plitzner about 3 years ago
- Status changed from Resolved to Closed
- Assignee changed from Andreas Müller to Patrick Plitzner
The E4 migration has been done up to a sufficient state.
Remaining issues should be handled in separate tickets.
#48 Updated by Andreas Müller about 3 years ago
- Status changed from Closed to Feedback
- Assignee changed from Patrick Plitzner to Katja Luther
I think we should first create a ticket with the remaining issues before closing. Otherwise the information will get lost.
Katja, could you create the ticket as most of the comments and also part of the implementation are yours? And close this ticket afterwards.
By the way, multi-select still does not work for me.
#49 Updated by Andreas Müller about 3 years ago
- % Done changed from 100 to 90
#50 Updated by Andreas Müller about 3 years ago
- Related to feature request #7010: Adapt handlers for multiple selection in e4 views added
#51 Updated by Andreas Müller about 3 years ago
Multi selection is generally handled in #7010.
Are there any other open issues?
When closing this ticket please also close master ticket as this is the last ticket not closed yet.
#52 Updated by Andreas Müller almost 3 years ago
- Status changed from Feedback to Closed
- Assignee changed from Katja Luther to Patrick Plitzner
- % Done changed from 90 to 100
Close this ticket as bulk editor has new developments like NAT tables and parallel loading anyways.
