bug #6894
closedNPE when trying drag&drop a Classification to the GrantedAuthority editor
50%
Description
This is critical because adding to full classification as a GrantedAuthority is a standard usecase. Maybe this got corrupted when changing classification handling in taxon navigator from classification to taxonnode. this is not the and was the cause for fixing this issue the wrong way!
Related issues
Updated by Katja Luther over 6 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 50
The exception is not thrwon anymore, but the type is now TaxonNode, not Classification.
Updated by Katja Luther over 6 years ago
the dragAssistant now check if the dragged node is the root node and then uses the classification instead of the taxonnode as drag source.
Updated by Katja Luther over 6 years ago
- Status changed from In Progress to Resolved
- Assignee changed from Katja Luther to Andreas Müller
Updated by Andreas Müller over 6 years ago
- Assignee changed from Andreas Müller to Andreas Kohlbecker
Katja Luther wrote:
The exception is not thrwon anymore, but the type is now TaxonNode, not Classification.
Do we need classification as type? I imagine that handling everything via TaxonNode is easier than having to handle both Classification and TaxonNode. The semantics is the same.
@AK: what do you thing from the security implementation perspective?
Updated by Andreas Müller over 6 years ago
- Has duplicate bug #6798: NPE when trying to drag&drop a classification to the user rights editor added
Updated by Andreas Müller over 6 years ago
Andreas Müller wrote:
@AK: what do you thing from the security implementation perspective?
??
Updated by Andreas Müller over 6 years ago
- Related to bug #6783: Menu item for editing right is missing added
Updated by Andreas Müller over 6 years ago
- Related to bug #6961: Drag&Drop for taxon nodes throws NPE when hovering Classification added
Updated by Andreas Kohlbecker over 6 years ago
- Assignee changed from Andreas Kohlbecker to Katja Luther
The drag and drop action is no longer causing a NPE but the resulting authority is not correct. The Autority which is created in turn of dropping a clasification is CLASSIFICATION[....] but the TaxonNodeVoter is not able to interpret this. A CdmPermittionVoter is always only responsible for one CDM BaseClass only!! Therefore the resulting authority must the one for the root taxon node of the classification. The drag and drop was originally implemented that way. taxeditor|af65d6ac changed this
Updated by Andreas Kohlbecker over 6 years ago
- Status changed from Resolved to Feedback
Updated by Andreas Müller over 6 years ago
So do I understand correctly that a ClassificationVoter does not (yet) exist. If yes than we need of course to store the TaxonNode instead.
However, for the user I find it more comfortable if we show Classification instead of TaxonNode as this is more what the user expects. Maybe the UI could hide this by transforming root nodes to classifications and back when showing / saving data.
But this we can also do in a more advanced UI later if it is difficult to implement now.
Updated by Andreas Kohlbecker over 6 years ago
Andreas Müller wrote:
So do I understand correctly that a ClassificationVoter does not (yet) exist. If yes than we need of course to store the TaxonNode instead.
Exactly! And there will never be a ClassificationVoter since the TaxonNodeVoter is completely sufficient to to the job
Updated by Katja Luther over 6 years ago
- Status changed from Feedback to Resolved
sorry, I reverted the changes and now the root node is used for the TaxonNodeVoter
Updated by Andreas Müller over 6 years ago
- Assignee changed from Katja Luther to Andreas Müller
Updated by Andreas Müller over 6 years ago
- Status changed from Resolved to Closed
- Assignee changed from Andreas Müller to Katja Luther
Looks good now.