Project

General

Profile

Actions
Copy link

bug #6842

closed

NPE in Registration constructor when name is null

Added by Andreas Kohlbecker almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
New
Assignee:
Andreas Kohlbecker
Category:
cdmlib
Target version:
Release 4.10
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:

Related issues

Related to EDIT - task #6258: Add Registration to cdm modelClosedAndreas Kohlbecker

Actions
Actions
Copy link
 #1

Updated by Andreas Kohlbecker almost 6 years ago

  • Related to task #6258: Add Registration to cdm model added
Actions
Copy link
 #2

Updated by Andreas Kohlbecker almost 6 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions
Copy link
 #3

Updated by Andreas Kohlbecker almost 6 years ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller
Actions
Copy link
 #4

Updated by Andreas Müller almost 6 years ago

hmm, should we better fix the setName() method instead the NewInstance method?

Actions
Copy link
 #5

Updated by Andreas Kohlbecker almost 6 years ago

agreed and fixed

Actions
Copy link
 #6

Updated by Andreas Müller over 5 years ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Looks like there were still some bugs in setName().

  • if name was null there was still an NPE in the last line
  • existing registration was removed from name.getRegistrations but should be removed from this.name.getRegistrations()
  • maybe some more

I adapted the method and wrote test to proof correct behavior.

Please review.

Actions
Copy link
 #7

Updated by Andreas Kohlbecker over 5 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 50 to 100
Actions
Copy link

Also available in: Atom PDF