Project

General

Profile

Actions
Copy link

feature request #6815

closed

OriginalSource idNamespace + idInSource default separator should be whitespace

Added by Andreas Kohlbecker about 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
New
Assignee:
Andreas Kohlbecker
Category:
cdm-dataportal
Target version:
Release 4.10
Start date:
Due date:
% Done:

0%

Estimated time:
Severity:
normal
Tags:
salvador

Description

der Slash in [Fig./1] steht nicht in den Daten, wo kommt der her?

Fig .1 ist in den Daten als "idInSource": "1", mit "idNamespace": "Fig." eingegeben. Bisher wird die idInSource immer mit einem Slash an den Namespace angehängt. Das ist offensichlich keine allgemein funktionierende Herangehensweise.

http://portal.cybertaxonomy.org/salvador/cdm_dataportal/media/fb52d954-f84b-450a-a57c-308f8a35a223

Related issues

Copied to EDIT - bug #6982: OriginalSource idNamespace + idInSource separator must be configurableNewAndreas Kohlbecker

Actions
Actions
Copy link
 #1

Updated by Andreas Müller about 6 years ago

ja, dazu was im Namespace und was direkt in IdInSource landet gibt es ja keine feste Regel. Ich schiebe häufig die statischen Anteile in Namespace und das andere in die IdInSource.
Insofern macht es evtl. Sinn, den Separator konfigurierbar zu machen. Allerdings auch nur so lange, so lange dass dann für alle Quellen funktioniert. Statt einem Slash einfach ein Leerzeichen zu verwenden sollte aber auch sehr häufig funktionieren. Vielleicht als default sogar besser als ein Slash.

Actions
Copy link
 #2

Updated by Andreas Müller about 6 years ago

  • Subject changed from IdentifiableSource idNamespace + idInSource for Figures must not be joined with a glue character to OriginalSource idNamespace + idInSource separator must be configurable
Actions
Copy link
 #3

Updated by Andreas Müller about 6 years ago

  • Tracker changed from bug to feature request
Actions
Copy link
 #4

Updated by Andreas Müller about 6 years ago

  • Target version changed from Release 4.9 to Release 4.10
Actions
Copy link
 #5

Updated by Andreas Müller about 6 years ago

Andreas Müller wrote:

Statt einem Slash einfach ein Leerzeichen zu verwenden sollte aber auch sehr häufig funktionieren. Vielleicht als default sogar besser als ein Slash.

I checked further sources and I still think that a "space" is better as default then a slash

Actions
Copy link
 #6

Updated by Andreas Müller about 6 years ago

Can we still implement the new default in 4.10?

Actions
Copy link
 #7

Updated by Andreas Kohlbecker about 6 years ago

  • Status changed from New to Feedback
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
Actions
Copy link
 #8

Updated by Andreas Kohlbecker about 6 years ago

Andreas Müller wrote:

Can we still implement the new default in 4.10?
Ok, I changed the seperator to the space character.

Regarding configurability: A simple default character would not be suffcient. Woul'nt we rather need a rule based approach? A cdm database may contains quite different identifiers types which need different formatting.

Two basic rules:

  1. if idNamespace is a URI the separator is '/'
  2. otherwise it is ' '
Actions
Copy link
 #9

Updated by Andreas Kohlbecker about 6 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link
 #10

Updated by Andreas Müller about 6 years ago

  • Copied to bug #6982: OriginalSource idNamespace + idInSource separator must be configurable added
Actions
Copy link
 #11

Updated by Andreas Müller about 6 years ago

  • Subject changed from OriginalSource idNamespace + idInSource separator must be configurable to OriginalSource idNamespace + idInSource default separator should be whitespace

Created new ticket for the configurability issue: #6982

Actions
Copy link
 #12

Updated by Andreas Müller about 6 years ago

I will review this after the release.

Actions
Copy link
 #13

Updated by Andreas Müller almost 6 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

This seems to work

Actions
Copy link

Also available in: Atom PDF