Project

General

Profile

feature request #6815

OriginalSource idNamespace + idInSource default separator should be whitespace

Added by Andreas Kohlbecker over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
New
Category:
cdm-dataportal
Target version:
Start date:
07/17/2017
Due date:
% Done:

0%

Severity:
normal
Tags:

Description

der Slash in [Fig./1] steht nicht in den Daten, wo kommt der her?

Fig .1 ist in den Daten als "idInSource": "1", mit "idNamespace": "Fig." eingegeben. Bisher wird die idInSource immer mit einem Slash an den Namespace angehängt. Das ist offensichlich keine allgemein funktionierende Herangehensweise.

http://portal.cybertaxonomy.org/salvador/cdm_dataportal/media/fb52d954-f84b-450a-a57c-308f8a35a223


Related issues

Copied to Edit - bug #6982: OriginalSource idNamespace + idInSource separator must be configurable New 09/25/2017

Associated revisions

Revision 05c57463 (diff)
Added by Andreas Kohlbecker about 1 year ago

ref #6815 using space as separator for idNamespace + idInSource

History

#1 Updated by Andreas Müller over 1 year ago

ja, dazu was im Namespace und was direkt in IdInSource landet gibt es ja keine feste Regel. Ich schiebe häufig die statischen Anteile in Namespace und das andere in die IdInSource.
Insofern macht es evtl. Sinn, den Separator konfigurierbar zu machen. Allerdings auch nur so lange, so lange dass dann für alle Quellen funktioniert. Statt einem Slash einfach ein Leerzeichen zu verwenden sollte aber auch sehr häufig funktionieren. Vielleicht als default sogar besser als ein Slash.

#2 Updated by Andreas Müller over 1 year ago

  • Subject changed from IdentifiableSource idNamespace + idInSource for Figures must not be joined with a glue character to OriginalSource idNamespace + idInSource separator must be configurable

#3 Updated by Andreas Müller over 1 year ago

  • Tracker changed from bug to feature request

#4 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 4.9 to Release 4.10

#5 Updated by Andreas Müller about 1 year ago

Andreas Müller wrote:

Statt einem Slash einfach ein Leerzeichen zu verwenden sollte aber auch sehr häufig funktionieren. Vielleicht als default sogar besser als ein Slash.

I checked further sources and I still think that a "space" is better as default then a slash

#6 Updated by Andreas Müller about 1 year ago

Can we still implement the new default in 4.10?

#7 Updated by Andreas Kohlbecker about 1 year ago

  • Status changed from New to Feedback
  • Assignee changed from Andreas Kohlbecker to Andreas Müller

#8 Updated by Andreas Kohlbecker about 1 year ago

Andreas Müller wrote:

Can we still implement the new default in 4.10?
Ok, I changed the seperator to the space character.

Regarding configurability: A simple default character would not be suffcient. Woul'nt we rather need a rule based approach? A cdm database may contains quite different identifiers types which need different formatting.

Two basic rules:

  1. if idNamespace is a URI the separator is '/'
  2. otherwise it is ' '

#9 Updated by Andreas Kohlbecker about 1 year ago

  • Status changed from Feedback to Resolved

#10 Updated by Andreas Müller about 1 year ago

  • Copied to bug #6982: OriginalSource idNamespace + idInSource separator must be configurable added

#11 Updated by Andreas Müller about 1 year ago

  • Subject changed from OriginalSource idNamespace + idInSource separator must be configurable to OriginalSource idNamespace + idInSource default separator should be whitespace

Created new ticket for the configurability issue: #6982

#12 Updated by Andreas Müller about 1 year ago

I will review this after the release.

#13 Updated by Andreas Müller about 1 year ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

This seems to work

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)