Project

General

Profile

feature request #6806

Add context menu to FeatureTreeEditor

Added by Patrick Plitzner almost 2 years ago. Updated 4 months ago.

Status:
Closed
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
07/12/2017
Due date:
% Done:

80%

Severity:
normal

picture850-1.png View (14.9 KB) Andreas Müller, 01/16/2019 02:18 PM


Related issues

Related to Edit - feature request #6694: Migrate FeatureTreeEditor Closed 06/06/2017
Related to Edit - feature request #8003: [DISUCSS] Implement "Export" on sub tree of FeatureTrees New 01/18/2019
Copied from Edit - bug #6786: Remaining feature tree editor issues Closed 07/12/2017
Copied to Edit - feature request #7372: Allow configuring feature/term tree Resolved 04/26/2018
Copied to Edit - feature request #8060: Implement move up/down in feature tree editor New 02/04/2019

Associated revisions

Revision ff46c6ca (diff)
Added by Patrick Plitzner almost 2 years ago

ref #6806 Add context menu to feature tree editor

  • menu item for add, remove feature and export feature tree (experimental)

Revision 804fe7cc (diff)
Added by Patrick Plitzner almost 2 years ago

ref #6806 remove buttons from FeatureTreeEditorComposite

Revision d9a7bf37 (diff)
Added by Patrick Plitzner over 1 year ago

ref #6806 Fix double invocation SelectionDialog

Revision ff58a197 (diff)
Added by Patrick Plitzner over 1 year ago

ref #6806 Move feature tree widget initialization to WS editor

Revision 4c16d694 (diff)
Added by Patrick Plitzner over 1 year ago

ref #6806 Correctly initialize WS taxon filter

Revision c8daeda0 (diff)
Added by Patrick Plitzner over 1 year ago

ref #6806 Add remove taxon node key listener for DEL

Revision b2a53e66 (diff)
Added by Patrick Plitzner over 1 year ago

ref #6806 Make setTaxonSubtreeFilter public

Revision 7114eadf (diff)
Added by Patrick Plitzner over 1 year ago

ref #6806 clear taxon filter before saving it

Revision 72c03cfb (diff)
Added by Patrick Plitzner about 1 year ago

ref #6806 Add "Add child feature" to feature tree editor context menu

Revision d00e1697 (diff)
Added by Patrick Plitzner about 1 year ago

ref #6806 Allow adding multiple nodes for the same feature

Revision f8f2ac3c (diff)
Added by Patrick Plitzner about 1 year ago

ref #6806 Fix session initialization

Revision c2e12c2b (diff)
Added by Patrick Plitzner about 1 year ago

ref #6806 Implement operation framework for feature tree editor

Revision e6c775fc (diff)
Added by Patrick Plitzner about 1 year ago

ref #6806 Remove saving in service methods

Revision 288109a7 (diff)
Added by Patrick Plitzner 6 months ago

ref #6806 Add isDirty() to IE4SavablePart + extract dirty check to util

Revision 41e1666a (diff)
Added by Patrick Plitzner 6 months ago

ref #6806 Fix dirty state handling and saving in feature tree editor

Revision ac8dcaec (diff)
Added by Patrick Plitzner 4 months ago

ref #6806 Sort feature trees alphabetically

Revision f587725a (diff)
Added by Patrick Plitzner 4 months ago

ref #6806 Select newly created feature tree

Revision 0800831b (diff)
Added by Patrick Plitzner 4 months ago

ref #6806 Disable export context menu for feature nodes

History

#1 Updated by Patrick Plitzner almost 2 years ago

  • Status changed from New to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 0 to 50

@Andreas: I would also remove the buttons then, ok?

#2 Updated by Andreas Müller almost 2 years ago

Patrick Plitzner wrote:

@Andreas: I would also remove the buttons then, ok?

Yes, if all functionality is available via right click.

#3 Updated by Patrick Plitzner almost 2 years ago

Andreas Müller wrote:

Patrick Plitzner wrote:

@Andreas: I would also remove the buttons then, ok?

Yes, if all functionality is available via right click.

Ok, all implemented now

#4 Updated by Andreas Müller almost 2 years ago

#5 Updated by Andreas Müller almost 2 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

With right click menu we have now the possibility to distinguish "add" (on top level) and "add child". This should be implemented.

#6 Updated by Andreas Müller almost 2 years ago

It is great that the selection distinguishes vocabularies and shows them in a tree structure. Unfortunately the terms are not ordered, this is urgently necessary for larger vocabularies.

#7 Updated by Andreas Müller almost 2 years ago

It looks like multiple usage of 1 feature in the same feature tree is currently not supported. If I e.g. select a feature that is already in the feature tree nothing happens. Is this on purpose?

Maybe needs discussion. There are usecase where we want multiple usage, e.g. for structures in a structure tree (feature tree might become term tree in future). Maybe we need a flag to allow or not allow multiple usages, depending of the type of feature tree)

#8 Updated by Andreas Müller over 1 year ago

  • Parent task deleted (#6786)

#9 Updated by Andreas Müller over 1 year ago

  • Copied from bug #6786: Remaining feature tree editor issues added

#10 Updated by Patrick Plitzner about 1 year ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 50 to 80

Comment 5 and 7 are fixed. Comment 6 has already been fixed before.

#11 Updated by Andreas Müller about 1 year ago

#12 Updated by Andreas Müller about 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

Generally all issues fixed or moved to new ticket.

However, the dirty flag does not seem to work correctly. This needs to be fixed urgently.

#13 Updated by Andreas Müller about 1 year ago

  • Priority changed from New to Highest

#14 Updated by Patrick Plitzner about 1 year ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller

#15 Updated by Patrick Plitzner 6 months ago

  • Status changed from Resolved to In Progress
  • Assignee changed from Andreas Müller to Patrick Plitzner
  • Target version changed from Release 4.9 to Release 5.5

#16 Updated by Patrick Plitzner 6 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller

#17 Updated by Andreas Müller 4 months ago

Export menu is disabled on FeatureNodes

#18 Updated by Andreas Müller 4 months ago

Adding a new feature tree should set the focus to the new tree. Also the label should be updated in Details View after focus is set.

#19 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

#20 Updated by Andreas Müller 4 months ago

Andreas Müller wrote:

... Also the label should be updated in Details View after focus is set.

and after changing the titleCache

#21 Updated by Andreas Müller 4 months ago

Paste not possbile on feature tree

#22 Updated by Andreas Müller 4 months ago

Feature trees should be ordered alphabetically

#23 Updated by Andreas Müller 4 months ago

Having a move up/down in right click menu would be a nice nice-to-have as d&d is sometimes a bit cumbersome when moving terms between something. Also it is always good to have >1 possibilities to do something.

#24 Updated by Andreas Müller 4 months ago

Andreas Müller wrote:

Having a move up/down in right click menu would be a nice nice-to-have as d&d is sometimes a bit cumbersome when moving terms between something. Also it is always good to have >1 possibilities to do something.

this is also relevant because currently adding a new feature at a certain position in the sibbling list is not (yet) possible so moving is necessary if you want to add a term a position != last position

#25 Updated by Andreas Müller 4 months ago

Except for the above issues the context menu works fine and looks much better and is more consistent with general TaxEditor usage.

#26 Updated by Patrick Plitzner 4 months ago

Andreas Müller wrote:

Export menu is disabled on FeatureNodes

I remember that we discussed this and it was not clear if we want to export only part of the tree. I move this to a new ticket -> #8003

#27 Updated by Patrick Plitzner 4 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller

all other issues should be fixed now

#28 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

Patrick Plitzner wrote:

Andreas Müller wrote:

Export menu is disabled on FeatureNodes

I remember that we discussed this and it was not clear if we want to export only part of the tree. I move this to a new ticket -> #8003

If we do not implement it, we should completely remove it from the menu, so let's do this for now and add it again when #8003 is implemented

#29 Updated by Patrick Plitzner 4 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller

Andreas Müller wrote:

Patrick Plitzner wrote:

Andreas Müller wrote:

Export menu is disabled on FeatureNodes

I remember that we discussed this and it was not clear if we want to export only part of the tree. I move this to a new ticket -> #8003

If we do not implement it, we should completely remove it from the menu, so let's do this for now and add it again when #8003 is implemented

Export context menu is disabled

#30 Updated by Andreas Müller 4 months ago

#31 Updated by Andreas Müller 4 months ago

#32 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Patrick Plitzner

Andreas Müller wrote:

Having a move up/down in right click menu would be a nice nice-to-have as d&d is sometimes a bit cumbersome when moving terms between something. Also it is always good to have >1 possibilities to do something.

This is not yet implemented. I created a new ticket #8060

So we can close this ticket now.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)