bug #6780
closed
ConversationHolder isTransactionActive() returns true even if the transaction is completed
Added by Andreas Kohlbecker almost 7 years ago.
Updated over 6 years ago.
Description
The ConversationHolder method isTransactionActive() (always?) returns true in cases when the transaction has been rolled back or was committed.
this mehtod should be changed like this:
public boolean isTransactionActive(){
return transactionStatus != null && !transactionStatus.isCompleted();
}
#4335 is possibly a duplicate of this
- Status changed from New to In Progress
- Assignee changed from Andreas Müller to Andreas Kohlbecker
- Target version changed from Unassigned CDM tickets to Release 4.11
- Status changed from In Progress to Resolved
- % Done changed from 0 to 50
I needed to revert (cdm-vaadin|b84bb2fd ) a prevous commit which was making use of the fixed isTransactionActive() method due to problems with the transaction synchronization being not active:
2017-10-25 18:03:20.859:WARN:oejs.HttpChannel:qtp748658608-47: /app/distribution
java.lang.IllegalStateException: Cannot deactivate transaction synchronization - not active
at org.springframework.transaction.support.TransactionSynchronizationManager.clearSynchronization(TransactionSynchronizationManager.java:329)
at org.springframework.transaction.support.TransactionSynchronizationManager.clear(TransactionSynchronizationManager.java:464)
at org.springframework.transaction.support.AbstractPlatformTransactionManager.cleanupAfterCompletion(AbstractPlatformTransactionManager.java:1013)
at org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:811)
at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:730)
at eu.etaxonomy.cdm.api.conversation.ConversationHolder.commit(ConversationHolder.java:341)
at eu.etaxonomy.vaadin.mvp.AbstractPresenter.unbindConversation(AbstractPresenter.java:194)
at eu.etaxonomy.vaadin.mvp.AbstractPresenter.onRequestEnd(AbstractPresenter.java:253)
at eu.etaxonomy.cdm.vaadin.server.CdmSpringVaadinServletService.lambda$1(CdmSpringVaadinServletService.java:56)
at java.util.ArrayList.forEach(ArrayList.java:1249)
at eu.etaxonomy.cdm.vaadin.server.CdmSpringVaadinServletService.requestEnd(CdmSpringVaadinServletService.java:56)
at com.vaadin.server.VaadinService.handleRequest(VaadinService.java:1450)
at com.vaadin.server.VaadinServlet.service(VaadinServlet.java:380)
- Target version changed from Release 4.11 to Release 4.12
- Status changed from Resolved to Feedback
- Status changed from Feedback to Closed
reviewed by a.mueller: "Deine vorgeschlagenen Änderungen im ConversationHolder sind dort ja weiterhin drin. Lediglich in vaadin hast du wohl etwas reverted.
Kann man das Ticket evtl. doch schließen jetzt? "
Ok, dann ist also alles gut und du hast hiermit auch gleich das Review gemacht, also schließe ich das Ticket.
Also available in: Atom
PDF