Project

General

Profile

bug #6748

feature request #6565: [MASTER] Eclipse 4 Migration

feature request #6596: Migrate specimen editor

Linking between derivate view and facts/media view

Added by Katja Luther over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
06/21/2017
Due date:
% Done:

100%

Severity:
critical
Found in Version:

Description

If the derivate view is selected but in the right hand corner like it is, when it is opened. Then the "active editor" is still the name editor and the createDescriptionOperation works with the editorInput of the activeEditor -> this means the description is created for the name not for the specimen.


Related issues

Related to Edit - bug #6747: Media and Facts view is inactive for specimen editor Closed 06/21/2017
Related to Edit - feature request #6795: Invoke selection change event when setting focus to specimen editor Closed 07/10/2017

Associated revisions

Revision 27dcccfd (diff)
Added by Patrick Plitzner over 1 year ago

ref #6748 Unwrap E4 parts during selection change events

Revision 027fe4eb (diff)
Added by Patrick Plitzner over 1 year ago

ref #6748 Refactor parameter name to avoid ambiguity

Revision 5daadc6e (diff)
Added by Patrick Plitzner over 1 year ago

fix #6748 Fix creation of description for specimens

Revision 15e5c1fc (diff)
Added by Patrick Plitzner over 1 year ago

fix #6748 Fix creation of description for specimens

Revision 3ac52088 (diff)
Added by Patrick Plitzner over 1 year ago

fix #6748 Fix creation of description for specimens

History

#1 Updated by Katja Luther over 1 year ago

  • Related to bug #6747: Media and Facts view is inactive for specimen editor added

#2 Updated by Andreas Müller over 1 year ago

  • Severity changed from normal to critical

#3 Updated by Andreas Müller over 1 year ago

It seems like the linking is correct for the media view but not for the facts view

#4 Updated by Katja Luther over 1 year ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

seems to work now with the changes for the other derivate view tickets.

#5 Updated by Andreas Müller over 1 year ago

#6 Updated by Andreas Müller over 1 year ago

#7 Updated by Andreas Müller over 1 year ago

  • Parent task set to #6596

#8 Updated by Patrick Plitzner over 1 year ago

  • % Done changed from 0 to 50

#9 Updated by Andreas Müller over 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

It still does not seem to work if the focus is set to the same record as before.

What I did:

  • Open Specimen Editor
  • Set focus to a specimen (factual data appear in factual data view)
  • Set focus to a taxon (factual data appear for the taxon)
  • Set focus back to the specimen by clicking on it (even multiple times), => factual data and also details still show the taxon data

#10 Updated by Patrick Plitzner over 1 year ago

Andreas Müller wrote:

It still does not seem to work if the focus is set to the same record as before.

What I did:

  • Open Specimen Editor
  • Set focus to a specimen (factual data appear in factual data view)
  • Set focus to a taxon (factual data appear for the taxon)
  • Set focus back to the specimen by clicking on it (even multiple times), => factual data and also details still show the taxon data

That is actually a different problem. There is just no SelectionChangedEvent thrown when re-setting focus to the specimen. If you click on another item and then on the specimen again the views are updated.

#11 Updated by Andreas Müller over 1 year ago

By the way, also the save button dirty state is irritated after a while if you jump back and force between taxa and specimen and add some data. After a while it indicates a dirty state but pressing the button does not change anything and it is really difficult to get it back to undirty state.
I hope this has the same reason. Otherwise we need a new ticket.

#12 Updated by Andreas Müller over 1 year ago

Patrick Plitzner wrote:

Andreas Müller wrote:

It still does not seem to work if the focus is set to the same record as before.

What I did:

  • Open Specimen Editor
  • Set focus to a specimen (factual data appear in factual data view)
  • Set focus to a taxon (factual data appear for the taxon)
  • Set focus back to the specimen by clicking on it (even multiple times), => factual data and also details still show the taxon data

That is actually a different problem. There is just no SelectionChangedEvent thrown when re-setting focus to the specimen. If you click on another item and then on the specimen again the views are updated.

So we need to assure that if the view looses the focus in between if getting back to the view we need to throw a selection change event.

If this is another issue feel free to create a new ticket. However, the effect is very similar and it is also a critical issue as the user may not recognize that he is not editing the expected record.

#13 Updated by Patrick Plitzner over 1 year ago

  • Status changed from Feedback to Resolved

#14 Updated by Andreas Müller over 1 year ago

should I review?

#15 Updated by Patrick Plitzner over 1 year ago

  • Assignee changed from Patrick Plitzner to Andreas Müller

#16 Updated by Patrick Plitzner over 1 year ago

  • Related to feature request #6795: Invoke selection change event when setting focus to specimen editor added

#17 Updated by Patrick Plitzner over 1 year ago

I added and fixed the issue of the focus selection: #6795

#18 Updated by Andreas Müller about 1 year ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Patrick Plitzner
  • % Done changed from 50 to 100

Looks like this is fully fixed now.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)