https://dev.e-taxonomy.eu/redmine/https://dev.e-taxonomy.eu/redmine/redmine/favicon.ico?14691914852017-06-07T10:04:52ZEDIT Project ManagementEDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=296982017-06-07T10:04:52ZPatrick Plitzner
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>Assignee</strong> changed from <i>Patrick Plitzner</i> to <i>Andreas Müller</i></li><li><strong>Target version</strong> changed from <i>Unassigned CDM tickets</i> to <i>Release 4.8</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>80</i></li></ul> EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=298702017-06-14T14:33:48ZAndreas Müller
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-5 priority-10 priority-lowest closed" href="/redmine/issues/6726">bug #6726</a>: NPE in FactualDataView and feature selection does not show any entries in Factual Data View</i> added</li></ul> EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=298852017-06-14T22:27:00ZAndreas Müller
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Feedback</i></li><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Patrick Plitzner</i></li></ul><p>Please check <a class="issue tracker-4 status-5 priority-10 priority-lowest closed" title="bug: NPE in FactualDataView and feature selection does not show any entries in Factual Data View (Closed)" href="https://dev.e-taxonomy.eu/redmine/issues/6726">#6726</a> if these bugs are related to the changes in this ticket.</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=298862017-06-14T22:37:03ZAndreas Müller
<ul></ul><p>Please move the menu entry to "Term Editor" and there below "Others" separated with 2 separators; and call in "Feature Tree", not "Feature Tree Editor".</p>
<p>@Katja: Could you try to implement this already?</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=298872017-06-14T22:45:37ZAndreas Müller
<ul><li><strong>Severity</strong> changed from <i>normal</i> to <i>critical</i></li></ul><p>When moving the Edtior with in the UI I got an IllegalAurgumentException (Message: null). Title: "Could not get conversatoin for AbstractFormSection". Description: "There is an error in the implementation. There should have been an active editor but wasn't".</p>
<p>The error occurred recursively. Showing up in 2 dialogs. One with Details/Error trace, one without (this should not happen). I needed to close it at least 10x to make it go away completely. The element getting the focus afterwards was a synonym in Name Editor.</p>
<pre>java.lang.IllegalArgumentException
login : admin
editor version : 4.8.0.201706140848
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 4.7.0.0.201710040000
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
at eu.etaxonomy.taxeditor.ui.element.AbstractFormSection.getConversationHolder(AbstractFormSection.java:591)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.getConversationHolder(AbstractCdmDetailElement.java:277)
at eu.etaxonomy.taxeditor.ui.element.AbstractFormSection.getConversationHolder(AbstractFormSection.java:587)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.getConversationHolder(AbstractCdmDetailElement.java:277)
at eu.etaxonomy.taxeditor.ui.section.name.AuthorshipDetailElement.createControls(AuthorshipDetailElement.java:101)
at eu.etaxonomy.taxeditor.ui.section.name.AuthorshipDetailElement.createControls(AuthorshipDetailElement.java:1)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.updateContent(AbstractCdmDetailElement.java:107)
at eu.etaxonomy.taxeditor.ui.section.name.AuthorshipDetailElement.updateContent(AuthorshipDetailElement.java:125)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.setEntity(AbstractCdmDetailElement.java:94)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailSection.setEntity(AbstractCdmDetailSection.java:125)
at eu.etaxonomy.taxeditor.ui.section.name.NonViralNameDetailElement.setEntity(NonViralNameDetailElement.java:127)
at eu.etaxonomy.taxeditor.ui.section.name.NonViralNameDetailElement.setEntity(NonViralNameDetailElement.java:1)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailSection.setEntity(AbstractCdmDetailSection.java:125)
at eu.etaxonomy.taxeditor.ui.section.name.NonViralNameDetailSection.setTaxonBase(NonViralNameDetailSection.java:129)
at eu.etaxonomy.taxeditor.view.detail.CdmSectionPart.setFormInput(CdmSectionPart.java:91)
at org.eclipse.ui.forms.ManagedForm.setInput(ManagedForm.java:210)
at eu.etaxonomy.taxeditor.view.AbstractCdmDataViewer.refresh(AbstractCdmDataViewer.java:123)
at eu.etaxonomy.taxeditor.view.AbstractCdmDataViewer.setInput(AbstractCdmDataViewer.java:109)
at eu.etaxonomy.taxeditor.view.detail.DetailsViewer.setInput(DetailsViewer.java:161)
at eu.etaxonomy.taxeditor.view.detail.DetailsViewPart.showViewer(DetailsViewPart.java:268)
at eu.etaxonomy.taxeditor.view.detail.DetailsViewPart.selectionChanged_internal(DetailsViewPart.java:136)
at eu.etaxonomy.taxeditor.view.AbstractCdmEditorViewPart$DelaySelection.run(AbstractCdmEditorViewPart.java:52)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
</pre>
<p>Setting to critical because of this bug.</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=298882017-06-14T22:47:31ZAndreas Müller
<ul></ul><p>If entering text into the "Title" search box has no effect, the text box should be disabled for entering text.</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=298892017-06-14T22:48:38ZAndreas Müller
<ul></ul><p>Layout: The search box is longer then the textbox for the data. It should be aligned.</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=298902017-06-14T22:54:06ZAndreas Müller
<ul></ul><p>If moving nodes in the tree everything seems to be saved immediately. This is unexpected behavior as users are used to have to save results of editing. If this is wanted there should be a warning at least.<br>
Is it necessary that we do not use "save" and set the save button dirty?</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=298912017-06-14T22:58:56ZAndreas Müller
<ul></ul><p>Sometimes there is a bug when moving nodes. The node does not get deleted at the old position but is added at the new position at the same time. </p>
<p>At the same time I also got a never ending resursion as "Conservation" & "Habitat" iterated as being children of each other.</p>
<p>This is difficult to reproduce but similar problems occurred in the old Feature Treee Editor already.</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=299622017-06-16T12:57:33ZPatrick Plitzner
<ul><li><strong>Assignee</strong> changed from <i>Patrick Plitzner</i> to <i>Andreas Müller</i></li></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>If moving nodes in the tree everything seems to be saved immediately. This is unexpected behavior as users are used to have to save results of editing. If this is wanted there should be a warning at least.<br>
Is it necessary that we do not use "save" and set the save button dirty?</p>
</blockquote>
<p>This has been fixed</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=299632017-06-16T12:58:41ZPatrick Plitzner
<ul><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Patrick Plitzner</i></li></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>When moving the Edtior with in the UI I got an IllegalAurgumentException (Message: null). Title: "Could not get conversatoin for AbstractFormSection". Description: "There is an error in the implementation. There should have been an active editor but wasn't".</p>
<p>The error occurred recursively. Showing up in 2 dialogs. One with Details/Error trace, one without (this should not happen). I needed to close it at least 10x to make it go away completely. The element getting the focus afterwards was a synonym in Name Editor.</p>
<pre>java.lang.IllegalArgumentException
login : admin
editor version : 4.8.0.201706140848
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 4.7.0.0.201710040000
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
at eu.etaxonomy.taxeditor.ui.element.AbstractFormSection.getConversationHolder(AbstractFormSection.java:591)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.getConversationHolder(AbstractCdmDetailElement.java:277)
at eu.etaxonomy.taxeditor.ui.element.AbstractFormSection.getConversationHolder(AbstractFormSection.java:587)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.getConversationHolder(AbstractCdmDetailElement.java:277)
at eu.etaxonomy.taxeditor.ui.section.name.AuthorshipDetailElement.createControls(AuthorshipDetailElement.java:101)
at eu.etaxonomy.taxeditor.ui.section.name.AuthorshipDetailElement.createControls(AuthorshipDetailElement.java:1)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.updateContent(AbstractCdmDetailElement.java:107)
at eu.etaxonomy.taxeditor.ui.section.name.AuthorshipDetailElement.updateContent(AuthorshipDetailElement.java:125)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.setEntity(AbstractCdmDetailElement.java:94)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailSection.setEntity(AbstractCdmDetailSection.java:125)
at eu.etaxonomy.taxeditor.ui.section.name.NonViralNameDetailElement.setEntity(NonViralNameDetailElement.java:127)
at eu.etaxonomy.taxeditor.ui.section.name.NonViralNameDetailElement.setEntity(NonViralNameDetailElement.java:1)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailSection.setEntity(AbstractCdmDetailSection.java:125)
at eu.etaxonomy.taxeditor.ui.section.name.NonViralNameDetailSection.setTaxonBase(NonViralNameDetailSection.java:129)
at eu.etaxonomy.taxeditor.view.detail.CdmSectionPart.setFormInput(CdmSectionPart.java:91)
at org.eclipse.ui.forms.ManagedForm.setInput(ManagedForm.java:210)
at eu.etaxonomy.taxeditor.view.AbstractCdmDataViewer.refresh(AbstractCdmDataViewer.java:123)
at eu.etaxonomy.taxeditor.view.AbstractCdmDataViewer.setInput(AbstractCdmDataViewer.java:109)
at eu.etaxonomy.taxeditor.view.detail.DetailsViewer.setInput(DetailsViewer.java:161)
at eu.etaxonomy.taxeditor.view.detail.DetailsViewPart.showViewer(DetailsViewPart.java:268)
at eu.etaxonomy.taxeditor.view.detail.DetailsViewPart.selectionChanged_internal(DetailsViewPart.java:136)
at eu.etaxonomy.taxeditor.view.AbstractCdmEditorViewPart$DelaySelection.run(AbstractCdmEditorViewPart.java:52)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
</pre>
<p>Setting to critical because of this bug.</p>
</blockquote>
<p>This should be fixed by propagating the selection of the editor so that the Details view is emptied.</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=299642017-06-16T12:59:17ZPatrick Plitzner
<ul></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>If entering text into the "Title" search box has no effect, the text box should be disabled for entering text.</p>
</blockquote>
<p>This is not for searching but for editing the label (titleCache) of the feature tree.</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=299652017-06-16T13:16:42ZPatrick Plitzner
<ul></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>Sometimes there is a bug when moving nodes. The node does not get deleted at the old position but is added at the new position at the same time. </p>
<p>At the same time I also got a never ending resursion as "Conservation" & "Habitat" iterated as being children of each other.</p>
<p>This is difficult to reproduce but similar problems occurred in the old Feature Treee Editor already.</p>
</blockquote>
<p>This should also be fixed now. I do not know how to reproduce the recursion but maybe it is fixed as well.</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=299672017-06-16T13:46:05ZPatrick Plitzner
<ul><li><strong>Assignee</strong> changed from <i>Patrick Plitzner</i> to <i>Andreas Müller</i></li></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>Please move the menu entry to "Term Editor" and there below "Others" separated with 2 separators; and call in "Feature Tree", not "Feature Tree Editor".</p>
<p>@Katja: Could you try to implement this already?</p>
</blockquote>
<p>All issues mentioned above should be fixed now</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=299682017-06-17T21:37:39ZAndreas Müller
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li><li><strong>Priority</strong> changed from <i>New</i> to <i>Highest</i></li></ul> EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=299702017-06-19T10:47:09ZAndreas Müller
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Feedback</i></li></ul><p>Patrick Plitzner wrote:</p>
<blockquote>
<p>Andreas Müller wrote:</p>
<blockquote>
<p>When moving the Edtior with in the UI I got an IllegalAurgumentException (Message: null). Title: "Could not get conversatoin for AbstractFormSection". Description: "There is an error in the implementation. There should have been an active editor but wasn't".</p>
<p>The error occurred recursively. Showing up in 2 dialogs. One with Details/Error trace, one without (this should not happen). I needed to close it at least 10x to make it go away completely. The element getting the focus afterwards was a synonym in Name Editor.</p>
<pre>java.lang.IllegalArgumentException
login : admin
editor version : 4.8.0.201706140848
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 4.7.0.0.201710040000
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
at eu.etaxonomy.taxeditor.ui.element.AbstractFormSection.getConversationHolder(AbstractFormSection.java:591)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.getConversationHolder(AbstractCdmDetailElement.java:277)
at eu.etaxonomy.taxeditor.ui.element.AbstractFormSection.getConversationHolder(AbstractFormSection.java:587)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.getConversationHolder(AbstractCdmDetailElement.java:277)
at eu.etaxonomy.taxeditor.ui.section.name.AuthorshipDetailElement.createControls(AuthorshipDetailElement.java:101)
at eu.etaxonomy.taxeditor.ui.section.name.AuthorshipDetailElement.createControls(AuthorshipDetailElement.java:1)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.updateContent(AbstractCdmDetailElement.java:107)
at eu.etaxonomy.taxeditor.ui.section.name.AuthorshipDetailElement.updateContent(AuthorshipDetailElement.java:125)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.setEntity(AbstractCdmDetailElement.java:94)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailSection.setEntity(AbstractCdmDetailSection.java:125)
at eu.etaxonomy.taxeditor.ui.section.name.NonViralNameDetailElement.setEntity(NonViralNameDetailElement.java:127)
at eu.etaxonomy.taxeditor.ui.section.name.NonViralNameDetailElement.setEntity(NonViralNameDetailElement.java:1)
at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailSection.setEntity(AbstractCdmDetailSection.java:125)
at eu.etaxonomy.taxeditor.ui.section.name.NonViralNameDetailSection.setTaxonBase(NonViralNameDetailSection.java:129)
at eu.etaxonomy.taxeditor.view.detail.CdmSectionPart.setFormInput(CdmSectionPart.java:91)
at org.eclipse.ui.forms.ManagedForm.setInput(ManagedForm.java:210)
at eu.etaxonomy.taxeditor.view.AbstractCdmDataViewer.refresh(AbstractCdmDataViewer.java:123)
at eu.etaxonomy.taxeditor.view.AbstractCdmDataViewer.setInput(AbstractCdmDataViewer.java:109)
at eu.etaxonomy.taxeditor.view.detail.DetailsViewer.setInput(DetailsViewer.java:161)
at eu.etaxonomy.taxeditor.view.detail.DetailsViewPart.showViewer(DetailsViewPart.java:268)
at eu.etaxonomy.taxeditor.view.detail.DetailsViewPart.selectionChanged_internal(DetailsViewPart.java:136)
at eu.etaxonomy.taxeditor.view.AbstractCdmEditorViewPart$DelaySelection.run(AbstractCdmEditorViewPart.java:52)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
</pre>
<p>Setting to critical because of this bug.</p>
</blockquote>
<p>This should be fixed by propagating the selection of the editor so that the Details view is emptied.</p>
</blockquote>
<p>The problem still exists. I moved the Feature Tree Editor from one place to another and then clicked on any feature and it happened (editor version 4.8.0.201706190848)</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=299712017-06-19T10:48:42ZAndreas Müller
<ul><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Patrick Plitzner</i></li></ul><p>Patrick Plitzner wrote:</p>
<blockquote>
<p>Andreas Müller wrote:</p>
<blockquote>
<p>Please move the menu entry to "Term Editor" and there below "Others" separated with 2 separators; and call in "Feature Tree", not "Feature Tree Editor".</p>
<p>@Katja: Could you try to implement this already?</p>
</blockquote>
<p>All issues mentioned above should be fixed now</p>
</blockquote>
<p>The menu is at the right position now, but the 2 separators are still missing</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=299722017-06-19T10:54:20ZAndreas Müller
<ul></ul><p>Patrick Plitzner wrote:</p>
<blockquote>
<p>Andreas Müller wrote:</p>
<blockquote>
<p>If entering text into the "Title" search box has no effect, the text box should be disabled for entering text.</p>
</blockquote>
<p>This is not for searching but for editing the label (titleCache) of the feature tree.</p>
</blockquote>
<p>2 problems:</p>
<ul>
<li>even if NO feature tree is selected the field can still be edited (this does not make sense)</li>
<li>if the search dialog button is just beside the field it is not intuitive that this is an editing field. Search and editing should be clearly separated. Can we have a search section and an editing section which are separated? Also the search part should have an according label "Search"</li>
</ul>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=299732017-06-19T10:55:41ZAndreas Müller
<ul></ul><p>Can you provide according translations for the tab title and the title lable. Something like "Merkmals Baum Editor" und "Merkmals Baum"?</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=299742017-06-19T10:58:19ZAndreas Müller
<ul></ul><p>Patrick Plitzner wrote:</p>
<blockquote>
<p>Andreas Müller wrote:</p>
<blockquote>
<p>Sometimes there is a bug when moving nodes. The node does not get deleted at the old position but is added at the new position at the same time. </p>
<p>At the same time I also got a never ending resursion as "Conservation" & "Habitat" iterated as being children of each other.</p>
<p>This is difficult to reproduce but similar problems occurred in the old Feature Treee Editor already.</p>
</blockquote>
<p>This should also be fixed now. I do not know how to reproduce the recursion but maybe it is fixed as well.</p>
</blockquote>
<p>I still managed to create 3 nodes for IndividualsAssociations in the same feature tree just by moving around FeatureNodes. This time no recursion appeared. Still I can't say how to reproduce except for "move nodes often enough, it will occur sooner or later.</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=299752017-06-19T11:01:37ZAndreas Müller
<ul></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>Patrick Plitzner wrote:</p>
<blockquote>
<p>Andreas Müller wrote:</p>
<blockquote>
<p>Sometimes there is a bug when moving nodes. The node does not get deleted at the old position but is added at the new position at the same time. </p>
<p>At the same time I also got a never ending resursion as "Conservation" & "Habitat" iterated as being children of each other.</p>
<p>This is difficult to reproduce but similar problems occurred in the old Feature Treee Editor already.</p>
</blockquote>
<p>This should also be fixed now. I do not know how to reproduce the recursion but maybe it is fixed as well.</p>
</blockquote>
<p>I still managed to create 3 nodes for IndividualsAssociations in the same feature tree just by moving around FeatureNodes. This time no recursion appeared. Still I can't say how to reproduce except for "move nodes often enough, it will occur sooner or later.</p>
</blockquote>
<p>Now I also managed to create recursion. Afterwards I tried to save but pressing the save button had no result. Also trying to close the tab had no result, no matter if I answered the save request with "save" or cancel".</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=300492017-06-20T08:16:12ZPatrick Plitzner
<ul></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>Patrick Plitzner wrote:</p>
<blockquote>
<p>Andreas Müller wrote:</p>
<blockquote>
<p>Please move the menu entry to "Term Editor" and there below "Others" separated with 2 separators; and call in "Feature Tree", not "Feature Tree Editor".</p>
<p>@Katja: Could you try to implement this already?</p>
</blockquote>
<p>All issues mentioned above should be fixed now</p>
</blockquote>
<p>The menu is at the right position now, but the 2 separators are still missing</p>
</blockquote>
<p>I added a separator. It seems that RCP will not render two separator after each other by default so there is only one.</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=300512017-06-20T08:58:38ZAndreas Müller
<ul></ul><p>Patrick Plitzner wrote:</p>
<blockquote>
<p>Andreas Müller wrote:</p>
<blockquote>
<p>Patrick Plitzner wrote:<br>
The menu is at the right position now, but the 2 separators are still missing</p>
</blockquote>
<p>I added a separator. It seems that RCP will not render two separator after each other by default so there is only one.</p>
</blockquote>
<p>This is strange as I know for sure that I already saw double separators (and usually didn't like them). Can it be that they came up because there were menu items in between which where set to invisible in certain surroundings. Is this maybe a work around to add an extra menu item in between and set it always to invisible?<br>
However, this issue is not release critical, so please first try to solve those issues which are critical.</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=300752017-06-20T18:30:03ZPatrick Plitzner
<ul><li><strong>Assignee</strong> changed from <i>Patrick Plitzner</i> to <i>Andreas Müller</i></li><li><strong>% Done</strong> changed from <i>80</i> to <i>90</i></li></ul> EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=300872017-06-20T22:26:55ZAndreas Müller
<ul><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Patrick Plitzner</i></li></ul><p>Now, when trying to add a new feature in the feature tree I always get an LIE</p>
<pre>login : admin
editor version : 4.8.0.201706201949
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 4.7.0.0.201710040000
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
org.hibernate.LazyInitializationException: could not initialize proxy - no Session
at org.hibernate.proxy.AbstractLazyInitializer.initialize(AbstractLazyInitializer.java:148)
at org.hibernate.Hibernate.initialize(Hibernate.java:62)
at eu.etaxonomy.cdm.hibernate.HibernateProxyHelper.deproxy(HibernateProxyHelper.java:45)
at eu.etaxonomy.cdm.model.common.CdmBase.deproxy(CdmBase.java:304)
at eu.etaxonomy.cdm.persistence.hibernate.CdmPreDataChangeListener.generateCaches(CdmPreDataChangeListener.java:110)
at eu.etaxonomy.cdm.persistence.hibernate.CacheStrategyGenerator.saveOrUpdateOrMerge(CacheStrategyGenerator.java:48)
at eu.etaxonomy.cdm.persistence.hibernate.CacheStrategyGenerator.onSaveOrUpdate(CacheStrategyGenerator.java:33)
at org.hibernate.internal.SessionImpl.fireSaveOrUpdate(SessionImpl.java:648)
at org.hibernate.internal.SessionImpl.saveOrUpdate(SessionImpl.java:640)
at org.hibernate.engine.spi.CascadingActions$5.cascade(CascadingActions.java:218)
at org.hibernate.engine.internal.Cascade.cascadeToOne(Cascade.java:398)
at org.hibernate.engine.internal.Cascade.cascadeAssociation(Cascade.java:323)
at org.hibernate.engine.internal.Cascade.cascadeProperty(Cascade.java:162)
at org.hibernate.engine.internal.Cascade.cascade(Cascade.java:111)
at org.hibernate.event.internal.AbstractSaveEventListener.cascadeBeforeSave(AbstractSaveEventListener.java:425)
at org.hibernate.event.internal.AbstractSaveEventListener.performSaveOrReplicate(AbstractSaveEventListener.java:249)
at org.hibernate.event.internal.AbstractSaveEventListener.performSave(AbstractSaveEventListener.java:178)
at org.hibernate.event.internal.AbstractSaveEventListener.saveWithGeneratedId(AbstractSaveEventListener.java:121)
at org.hibernate.event.internal.DefaultSaveOrUpdateEventListener.saveWithGeneratedOrRequestedId(DefaultSaveOrUpdateEventListener.java:192)
at org.hibernate.event.internal.DefaultSaveEventListener.saveWithGeneratedOrRequestedId(DefaultSaveEventListener.java:38)
at org.hibernate.event.internal.DefaultSaveOrUpdateEventListener.entityIsTransient(DefaultSaveOrUpdateEventListener.java:177)
at org.hibernate.event.internal.DefaultSaveEventListener.performSaveOrUpdate(DefaultSaveEventListener.java:32)
at org.hibernate.event.internal.DefaultSaveOrUpdateEventListener.onSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:73)
at org.hibernate.internal.SessionImpl.fireSave(SessionImpl.java:679)
at org.hibernate.internal.SessionImpl.save(SessionImpl.java:671)
at org.hibernate.internal.SessionImpl.save(SessionImpl.java:666)
at eu.etaxonomy.cdm.persistence.dao.hibernate.common.CdmEntityDaoBase.save(CdmEntityDaoBase.java:327)
at eu.etaxonomy.cdm.api.service.ServiceBase.save(ServiceBase.java:268)
at eu.etaxonomy.cdm.api.service.ServiceBase.save(ServiceBase.java:35)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:302)
at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:190)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
at org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:99)
at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:281)
at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:96)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:208)
at com.sun.proxy.$Proxy697.save(Unknown Source)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:302)
at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:190)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
at org.springframework.remoting.support.RemoteInvocationTraceInterceptor.invoke(RemoteInvocationTraceInterceptor.java:78)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:208)
at com.sun.proxy.$Proxy983.save(Unknown Source)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.springframework.remoting.support.RemoteInvocation.invoke(RemoteInvocation.java:212)
at org.springframework.remoting.support.DefaultRemoteInvocationExecutor.invoke(DefaultRemoteInvocationExecutor.java:39)
at org.springframework.remoting.support.RemoteInvocationBasedExporter.invoke(RemoteInvocationBasedExporter.java:78)
at org.springframework.remoting.support.RemoteInvocationBasedExporter.invokeAndCreateResult(RemoteInvocationBasedExporter.java:114)
at org.springframework.remoting.httpinvoker.HttpInvokerServiceExporter.handleRequest(HttpInvokerServiceExporter.java:74)
at org.springframework.web.servlet.mvc.HttpRequestHandlerAdapter.handle(HttpRequestHandlerAdapter.java:51)
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:959)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:893)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:969)
at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:871)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:845)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:808)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669)
at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:316)
at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:126)
at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:90)
at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
at org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:114)
at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
at org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:122)
at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
at org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:169)
at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
at org.springframework.security.web.savedrequest.RequestCacheAwareFilter.doFilter(RequestCacheAwareFilter.java:48)
at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
at org.springframework.security.web.authentication.www.BasicAuthenticationFilter.doFilterInternal(BasicAuthenticationFilter.java:213)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
at org.springframework.security.web.authentication.logout.LogoutFilter.doFilter(LogoutFilter.java:120)
at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
at org.springframework.security.web.header.HeaderWriterFilter.doFilterInternal(HeaderWriterFilter.java:64)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
at org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:91)
at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
at org.springframework.security.web.context.request.async.WebAsyncManagerIntegrationFilter.doFilterInternal(WebAsyncManagerIntegrationFilter.java:53)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
at org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:213)
at org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:176)
at org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:346)
at org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:262)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:121)
at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:577)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:215)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
at org.eclipse.jetty.server.Server.handle(Server.java:497)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:310)
at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:540)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
at java.lang.Thread.run(Thread.java:748)
at org.springframework.remoting.support.RemoteInvocationUtils.fillInClientStackTraceIfPossible(RemoteInvocationUtils.java:45)
at org.springframework.remoting.support.RemoteInvocationResult.recreate(RemoteInvocationResult.java:149)
at org.springframework.remoting.support.RemoteInvocationBasedAccessor.recreateRemoteInvocationResult(RemoteInvocationBasedAccessor.java:85)
at org.springframework.remoting.httpinvoker.HttpInvokerClientInterceptor.invoke(HttpInvokerClientInterceptor.java:150)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:208)
at com.sun.proxy.$Proxy49.save(Unknown Source)
at eu.etaxonomy.taxeditor.featuretree.e4.FeatureTreeEditor$AddButtonListener.widgetSelected(FeatureTreeEditor.java:166)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
...
</pre>
<p>After reloading the feature tree the new feature exists. However, the error pops up and without reloading the new feature is not shown in the tree.</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=300882017-06-20T22:29:42ZAndreas Müller
<ul></ul><p>and when deleting a feature I get an NPE:</p>
<pre>login : admin
editor version : 4.8.0.201706201949
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 4.7.0.0.201710040000
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
at eu.etaxonomy.cdm.api.service.FeatureNodeServiceImpl.isDeletable(FeatureNodeServiceImpl.java:103)
at eu.etaxonomy.cdm.api.service.FeatureNodeServiceImpl.deleteFeatureNode(FeatureNodeServiceImpl.java:56)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:302)
at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:190)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
at org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:99)
at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:281)
...
</pre> EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=300892017-06-20T22:29:52ZAndreas Müller
<ul><li><strong>% Done</strong> changed from <i>90</i> to <i>70</i></li></ul> EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=300902017-06-20T22:32:55ZAndreas Müller
<ul></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>and when deleting a feature I get an NPE:</p>
<pre>login : admin
...
</pre></blockquote>
<p>This only happens for NON top level feature (feature which do have a parent).</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=300912017-06-20T22:42:02ZAndreas Müller
<ul></ul><p>Adding a new top level feature is not possible once a feature node is selected</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=300922017-06-20T22:47:15ZAndreas Müller
<ul></ul><p>Supplemental data are not yet shown (view is grey). It will not show many data but created, id and uuid might be very helpful, at least for debugging.</p>
<p>Also the details view might be needed for editing "inapplicableIf" and "onlyApplicableIf". Feel free to open new tickets for these issues.</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=300932017-06-20T22:48:49ZAndreas Müller
<ul></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>Patrick Plitzner wrote:</p>
<p>2 problems:</p>
<ul>
<li>even if NO feature tree is selected the field can still be edited (this does not make sense)</li>
<li>if the search dialog button is just beside the field it is not intuitive that this is an editing field. Search and editing should be clearly separated. Can we have a search section and an editing section which are separated? Also the search part should have an according label "Search"</li>
</ul>
</blockquote>
<p>The search button is still beside the titleCache button</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=300942017-06-20T22:50:05ZAndreas Müller
<ul></ul><p>Also for the trees themselves no supplemental data and details view is available, but might be a nice feature.</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=300962017-06-21T05:52:31ZPatrick Plitzner
<ul></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>Adding a new top level feature is not possible once a feature node is selected</p>
</blockquote>
<p>To do this you have to de-select the current feature (CTRL+Click on the selected item) or just move it to root after having added it</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=300972017-06-21T05:55:40ZPatrick Plitzner
<ul></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>Supplemental data are not yet shown (view is grey). It will not show many data but created, id and uuid might be very helpful, at least for debugging.</p>
<p>Also the details view might be needed for editing "inapplicableIf" and "onlyApplicableIf". Feel free to open new tickets for these issues.</p>
</blockquote>
<p>Added new ticket: <a class="issue tracker-5 status-5 priority-11 priority-default closed" title="feature request: Implement DetailsView and show SupplementalDataView for Feature Tree and FeatureNode (Closed)" href="https://dev.e-taxonomy.eu/redmine/issues/6746">#6746</a></p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=300982017-06-21T07:31:25ZAndreas Müller
<ul></ul><p>Patrick Plitzner wrote:</p>
<blockquote>
<p>Andreas Müller wrote:</p>
<blockquote>
<p>Adding a new top level feature is not possible once a feature node is selected</p>
</blockquote>
<p>To do this you have to de-select the current feature (CTRL+Click on the selected item) or just move it to root after having added it</p>
</blockquote>
<p>As adding top level elements makes 98% of the work you do in the feature tree editor this is not an acceptable solution. CTRL+Click is hidden knowledge which we can't expect the user to have. Moving it to root is a workaround users may find, but not very nice.</p>
<p>There might be different solutions: my preferred one is to have a right click menu like in the term editor and in many other editors and views. This would be more consistent throughout the application. It was ok to have "+" Button when the FeatureTree Editor was still in the preferences as most preferences work with "+". But now it is an "editor" and should follow the look and feel of editors.<br>
We can still keep the buttons but additionally could have a right click menu.</p>
<p>Another solution could be to allow toggle focus without having CTRL pressed (only by clicking). This makes it a bit easier to find. But still this is not really intuitive.</p>
<p>A third solution could be to always add features as top level elements and move them manually to the place were you need them. For the current use cases this is absolutely enough as it is very seldom that users really build trees. Usually they build lists. But for use cases like "additivity" this might be different.</p>
<p>Another solution could be 2 different button, one for top level one for children, but this is also not consistent with other editors (and maybe not intuitive)</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=300992017-06-21T08:01:50ZPatrick Plitzner
<ul><li><strong>Assignee</strong> changed from <i>Patrick Plitzner</i> to <i>Andreas Müller</i></li></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>Patrick Plitzner wrote:</p>
<blockquote>
<p>Andreas Müller wrote:</p>
<blockquote>
<p>Adding a new top level feature is not possible once a feature node is selected</p>
</blockquote>
<p>To do this you have to de-select the current feature (CTRL+Click on the selected item) or just move it to root after having added it</p>
</blockquote>
<p>As adding top level elements makes 98% of the work you do in the feature tree editor this is not an acceptable solution. CTRL+Click is hidden knowledge which we can't expect the user to have. Moving it to root is a workaround users may find, but not very nice.</p>
<p>There might be different solutions: my preferred one is to have a right click menu like in the term editor and in many other editors and views. This would be more consistent throughout the application. It was ok to have "+" Button when the FeatureTree Editor was still in the preferences as most preferences work with "+". But now it is an "editor" and should follow the look and feel of editors.<br>
We can still keep the buttons but additionally could have a right click menu.</p>
<p>Another solution could be to allow toggle focus without having CTRL pressed (only by clicking). This makes it a bit easier to find. But still this is not really intuitive.</p>
<p>A third solution could be to always add features as top level elements and move them manually to the place were you need them. For the current use cases this is absolutely enough as it is very seldom that users really build trees. Usually they build lists. But for use cases like "additivity" this might be different.</p>
<p>Another solution could be 2 different button, one for top level one for children, but this is also not consistent with other editors (and maybe not intuitive)</p>
</blockquote>
<p>Now new features are added to root always. Also the other session issues should be fixed now. But there were also cdmlib changes so you have to wait for the build if you test on the test DB</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=304802017-07-07T16:32:46ZAndreas Müller
<ul><li><strong>Precedes</strong> <i><a class="issue tracker-4 status-5 priority-10 priority-lowest closed" href="/redmine/issues/6786">bug #6786</a>: Remaining feature tree editor issues</i> added</li></ul> EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=304872017-07-07T17:15:07ZAndreas Müller
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Closed</i></li><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Patrick Plitzner</i></li></ul><p>I close this ticket as there was a release and open a new one with remaining issues: <a class="issue tracker-4 status-5 priority-10 priority-lowest closed" title="bug: Remaining feature tree editor issues (Closed)" href="https://dev.e-taxonomy.eu/redmine/issues/6786">#6786</a></p>
<p>Also some new issues were found. The most important issues are marked as critical and should be handled soon.</p>
EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=309452017-07-21T11:29:21ZAndreas Müller
<ul><li><strong>Related to</strong> <i><a class="issue tracker-5 status-5 priority-10 priority-lowest closed" href="/redmine/issues/6805">feature request #6805</a>: Implement drag and drop from Term Editor (Feature) to FeatureTreeEditor</i> added</li></ul> EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=309472017-07-21T11:29:40ZAndreas Müller
<ul><li><strong>Related to</strong> <i><a class="issue tracker-5 status-5 priority-10 priority-lowest closed" href="/redmine/issues/6806">feature request #6806</a>: Add context menu to FeatureTreeEditor</i> added</li></ul> EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=309492017-07-21T11:34:13ZAndreas Müller
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-5 priority-11 priority-default closed" href="/redmine/issues/6838">bug #6838</a>: Implement i18n for FeatureTreeEditor</i> added</li></ul> EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=309712017-07-22T06:40:30ZAndreas Müller
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-6 priority-11 priority-default closed" href="/redmine/issues/6844">bug #6844</a>: New feature tree selection does not allow "no save"</i> added</li></ul> EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=309742017-07-22T06:58:00ZAndreas Müller
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-8 priority-10 priority-lowest closed" href="/redmine/issues/6845">bug #6845</a>: dirty button does not work in feature tree editor</i> added</li></ul> EDIT - feature request #6694: Migrate FeatureTreeEditorhttps://dev.e-taxonomy.eu/redmine/issues/6694?journal_id=324042017-09-26T14:51:33ZPatrick Plitzner
<ul><li><strong>% Done</strong> changed from <i>70</i> to <i>100</i></li></ul>