feature request #6693: Implement missing nomenclatural codes for name detail element - EDIT - EDIT Project Management

Actions

Copy link

feature request #6693

closed

Implement missing nomenclatural codes for name detail element

Added by Patrick Plitzner over 6 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Highest

Assignee:

Katja Luther

Category:

taxeditor

Target version:

Release 4.10

Start date:

Due date:

% Done:

100%

Estimated time:

Severity:

major

Description

in class eu.etaxonomy.taxeditor.ui.section.name.NameDetailElement

private void createSpecificNameParts(ICdmFormElement formElement,
            INonViralName nonViralName, int style) {
        NomenclaturalCode code = nonViralName.getNomenclaturalCode();
        if (code != null){
            switch(nonViralName.getNomenclaturalCode()){
            case ICNAFP :
                //nothing do add
                createBotanicalNameParts(formElement, nonViralName, style);
                break;
            case Fungi :
                if (isAdvancedView){
                    createFungusNameParts(formElement, nonViralName, style);
                }
                break;
            case ICZN:
                createZoologicalNameParts(formElement, nonViralName, style);
                break;
            case ICVCN:
                //TODO implement
                logger.warn("ICVCN not yet implemented");
                break;
            case ICNB:
                //TODO implement
                logger.warn("ICNB not yet implemented");
                break;
            case ICNCP:
                //TODO implement
                logger.warn("ICNCP not yet implemented");
                break;
            case NonViral:
                //TODO implement
                logger.warn("NonViral not yet implemented");
                break;
            }
        }
    }

Files

picture96-1.png (2.25 KB) picture96-1.png

Andreas Müller, 09/18/2017 03:27 PM

Related issues

Actions

Copy link

Updated by Patrick Plitzner over 6 years ago

Related to feature request #6692: Make name types changeable added

Actions

Copy link

Updated by Katja Luther about 6 years ago

Status changed from New to Resolved
Priority changed from New to Highest
Target version changed from Unassigned CDM tickets to Release 4.10

added the missing nomenclatural codes, removed the viral code because it causes a NPE. Create a new ticket for details view for viral names (#6950)

Actions

Copy link

Updated by Andreas Müller about 6 years ago

Copied to feature request #6950: Alllow the usage of Viral Names added

Actions

Copy link

Updated by Andreas Müller about 6 years ago

Katja Luther wrote:

removed the viral code because it causes a NPE

Can you please commit this, otherwise I can't test

Actions

Copy link

Updated by Katja Luther about 6 years ago

is already commited in Revision 80c710e0, see above

Actions

Copy link

Updated by Andreas Müller about 6 years ago

Katja Luther wrote:

is already commited in Revision 80c710e0, see above

But this version still allows choosing ICVCN (however I currently work on the CacheStrategy update, maybe this is sufficient)

Actions

Copy link

Updated by Katja Luther about 6 years ago

sorry, I missed to commit it on friday, it was committed three hours ago.

Actions

Copy link

Updated by Andreas Müller about 6 years ago

File picture96-1.png picture96-1.png added

Katja Luther wrote:

sorry, I missed to commit it on friday, it was committed three hours ago.

But ICVCN is STILL available in the very latest version build 20 min ago! See attachement.

Please test with nightly.

Actions

Copy link

#10

Updated by Katja Luther about 6 years ago

% Done changed from 0 to 50

Applied in changeset taxeditor|d903b1d88feb526e0d13d330569c5c7c7ded40d4.

Actions

Copy link

#11

Updated by Andreas Müller about 6 years ago

Blocked by feature request #6957: Implement cache strategy for viral names added

Actions

Copy link

#12

Updated by Andreas Müller about 6 years ago

Blocked by deleted (feature request #6957: Implement cache strategy for viral names)

Actions

Copy link

#13

Updated by Andreas Müller about 6 years ago

Related to feature request #6957: Implement cache strategy for viral names added

Actions

Copy link

#14

Updated by Andreas Müller about 6 years ago

Is it possible to move the "Name approbation" for bacterial names either up below "LSID" or if this is not possible down below "Appended Phrase" as it is not part of the name but more an explanation.

Actions

Copy link

#15

Updated by Andreas Müller about 6 years ago

Andreas Müller wrote:

Is it possible to move the "Name approbation" for bacterial names either up below "LSID" or if this is not possible down below "Appended Phrase" as it is not part of the name but more an explanation.

Once this is implemented we can close this ticket from my side. We still need better cache strategies for the "new" codes but this is not part of this ticket.

Actions

Copy link

#16

Updated by Andreas Müller about 6 years ago

Related to feature request #6963: Implement cache strategy for cultivar plant names (done), bacterial names, fungi, etc. added

Actions

Copy link

#17

Updated by Andreas Müller about 6 years ago

Related to feature request #6361: [MASTER] Merge all TaxonName classes into 1 class added

Actions

Copy link

#18

Updated by Andreas Müller about 6 years ago

Status changed from Resolved to Feedback
Assignee changed from Patrick Plitzner to Katja Luther
Severity changed from normal to major

One more issue, which is a bit critical: we currently do have a hard validation if a name contains only data which is according to its code. E.g. a ICNAFP name must not have "acronym" or "nameApprobation" set. Otherwise one gets an validation exception and the name is not saved.

Therefore we need to delete these fields once the name type is changed. However, this is a bit critical if one changes the type only accidentally and changes it back afterwards. This will lead to a loss of data, maybe even not recognized by the user.
Therefore the better solution might be to run this check immediately before saving.

Another solution could be to remove this hard validation, but this may lead to dirty data. Also not nice.

Actions

Copy link

#19

Updated by Katja Luther about 6 years ago

Is duplicate of feature request #6691: Implement all name types in NameDetailElement added

Actions

Copy link

#20

Updated by Katja Luther about 6 years ago

Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

One more issue, which is a bit critical: we currently do have a hard validation if a name contains only data which is according to its code. E.g. a ICNAFP name must not have "acronym" or "nameApprobation" set. Otherwise one gets an validation exception and the name is not saved.

Therefore we need to delete these fields once the name type is changed. However, this is a bit critical if one changes the type only accidentally and changes it back afterwards. This will lead to a loss of data, maybe even not recognized by the user.
Therefore the better solution might be to run this check immediately before saving.

Another solution could be to remove this hard validation, but this may lead to dirty data. Also not nice.

But if you change the type accidentally, you are not able to save the taxon, so you have to delete the name approbiation before you are able to change the type and loose the data.

Actions

Copy link

#21

Updated by Katja Luther about 6 years ago

Andreas Müller wrote:

One more issue, which is a bit critical: we currently do have a hard validation if a name contains only data which is according to its code. E.g. a ICNAFP name must not have "acronym" or "nameApprobation" set. Otherwise one gets an validation exception and the name is not saved.

Therefore we need to delete these fields once the name type is changed. However, this is a bit critical if one changes the type only accidentally and changes it back afterwards. This will lead to a loss of data, maybe even not recognized by the user.
Therefore the better solution might be to run this check immediately before saving.

Another solution could be to remove this hard validation, but this may lead to dirty data. Also not nice.

Now a dialog pops up to confirm the deletion of the nametype specific parts.

Actions

Copy link

#22