Project

General

Profile

Actions

feature request #6691

closed

Implement all name types in NameDetailElement

Added by Andreas Müller over 5 years ago. Updated about 5 years ago.

Status:
Duplicate
Priority:
New
Assignee:
Category:
taxeditor
Target version:
-
Start date:
Due date:
% Done:

10%

Estimated time:
Severity:
normal

Description

It is now possible to switch name types easily. So we should allow to edit all name types, not only ICNAFP and ICZN.


Related issues

Related to EDIT - feature request #6361: [MASTER] Merge all TaxonName classes into 1 class ClosedAndreas Müller

Actions
Has duplicate EDIT - feature request #6693: Implement missing nomenclatural codes for name detail elementClosedKatja Luther

Actions
Actions #1

Updated by Andreas Müller over 5 years ago

  • Parent task deleted (#6361)
Actions #2

Updated by Andreas Müller over 5 years ago

Actions #3

Updated by Andreas Müller about 5 years ago

  • Target version changed from Release 4.8 to Release 4.9
Actions #4

Updated by Andreas Müller about 5 years ago

  • Target version changed from Release 4.9 to Release 4.10
Actions #5

Updated by Katja Luther about 5 years ago

  • Assignee changed from Katja Luther to Andreas Müller

All name types are available in drop down list. Switching between zoological and botanical codes also switching the available fields. There are any special fields for fungi or viruses??

Actions #6

Updated by Andreas Müller about 5 years ago

Katja Luther wrote:

Are there any special fields for fungi or viruses?

Please refere to the according interfaces (IViralName, IFungusName, ...) to adapt the UI properly.

Actions #7

Updated by Andreas Müller about 5 years ago

  • Assignee changed from Andreas Müller to Katja Luther
Actions #8

Updated by Andreas Müller about 5 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 10
Actions #9

Updated by Katja Luther about 5 years ago

if the name once is set to viral, the getTaggedName method returns always null.

else if (nonViralName.getNameType().isViral()){
            return null;
        }

we should remove the viral nomanclatural code to avoid this, because at the moment everything is based on INonViralName.

java.lang.NullPointerException
    at java.util.ArrayList.addAll(Unknown Source)
    at eu.etaxonomy.cdm.strategy.cache.name.TaxonNameDefaultCacheStrategy.getTaggedTitle(TaxonNameDefaultCacheStrategy.java:410)
    at eu.etaxonomy.cdm.strategy.cache.name.NameCacheStrategyBase.getTitleCache(NameCacheStrategyBase.java:150)
    at eu.etaxonomy.cdm.strategy.cache.name.NameCacheStrategyBase.getTitleCache(NameCacheStrategyBase.java:145)
    at eu.etaxonomy.cdm.strategy.cache.name.NameCacheStrategyBase.getTitleCache(NameCacheStrategyBase.java:1)
    at eu.etaxonomy.cdm.model.common.IdentifiableEntity.generateTitle(IdentifiableEntity.java:570)
    at eu.etaxonomy.cdm.model.common.IdentifiableEntity.getTitleCache(IdentifiableEntity.java:210)
    at eu.etaxonomy.cdm.model.name.TaxonName.getTitleCache(TaxonName.java:1446)
    at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailSection.setSectionTitle(AbstractCdmDetailSection.java:149)
    at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailSection.updateTitle(AbstractCdmDetailSection.java:169)
    at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.updateParentSection(AbstractCdmDetailElement.java:252)
    at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.handleTitleCacheRelevantChange(AbstractCdmDetailElement.java:244)
    at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.propertyChange(AbstractCdmDetailElement.java:210)
    at eu.etaxonomy.taxeditor.ui.element.AbstractCdmFormElement.firePropertyChangeEvent(AbstractCdmFormElement.java:235)
    at eu.etaxonomy.taxeditor.ui.element.AbstractCdmFormElement.firePropertyChangeEvent(AbstractCdmFormElement.java:263)
    at eu.etaxonomy.taxeditor.ui.section.AbstractCdmDetailElement.propertyChange(AbstractCdmDetailElement.java:229)
    at eu.etaxonomy.taxeditor.ui.element.AbstractCdmFormElement.firePropertyChangeEvent(AbstractCdmFormElement.java:235)
    at eu.etaxonomy.taxeditor.ui.combo.EnumComboElement.widgetSelected(EnumComboElement.java:184)
    at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249)
Actions #10

Updated by Katja Luther about 5 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

I removed the viral code from the drop down. Created a new ticket for this and close this one.(#6950)

Actions #11

Updated by Andreas Müller about 5 years ago

Is there a difference between this ticket and #6693 or is it a duplicate?

Actions #12

Updated by Andreas Müller about 5 years ago

  • Assignee changed from Andreas Müller to Katja Luther

To me this seems to be a duplicate for 6693 (or vice versa). Please see my comments on #6693.

Actions #13

Updated by Katja Luther about 5 years ago

  • Status changed from Resolved to Duplicate
  • Target version deleted (Release 4.10)

I think this is a duplicate

Actions #14

Updated by Katja Luther about 5 years ago

  • Has duplicate feature request #6693: Implement missing nomenclatural codes for name detail element added
Actions

Also available in: Atom PDF