EDIT

Applied in changeset taxeditor|6430b43e4a5e3def3a2778bf51f5114606cda156.

Sorry maybe it was too early to pass to assign to me. With current version the media is not yet stored in DB and even not in session as far as I can see.

the problem was that the start value of the mediaCreated field was not set correctly. It was saved but not displayed.

Now this is fixed, please review.

Generally it works, but there is no check for correct format.

However, there are a couple of problems related to the pure text input:

• No user visible format check exists: Compare e.g. with URI for format checking (red text if format is not correct). E.g. the user is not informed about entering just "xxx" has no effect on the data.
• It is not possible to enter time. Sometimes time might be an interesting information which gets completely lost. Also the user is not informed about the fact that it gets lost.
• If entering only a year this is transformed to the year on Jan. 1st. But the user is not informed about this changed.
• Entering e.g. 2008-02-30 may result in 2008-02-03 without the user being informed. This is because only the intermediate state is changed.
• Generally it is often more comfortable using a calendar entry component. Could you please leave a message in any of the DateTime tickets what the problem with the Calendar element e.g. from nebula is. Also leave a message where else the current solution is used so it can be changed in bulk once we have a better solution.

If using a Calendar component is to much work for now, we may stay with the text element but we should as a minimum implement a format check. If we allow only yyyy-mm-dd the data should be changed ONLY if it comes EXACTLY in this format. And the user should be informed in RED that the data is not stored or completely deleted if this red label appears.

By the way the label says "yyyy-MM-dd". Can we change this to "yyyy-mm-dd". Even if maybe not consistent with DateTime format rules it is easier to understand by ordinary users.

now there is a calendar widget to choose the date and the time.

The DateElement is used for DNAQualityCheck (qualityCheckDate), Reference (accessed) and MediaSpecimen(preparationDate).
The DateElement provides the possibility to edit also the textfield, but as long as we do not have a proper handling for wrong formated strings, this is disabled.

It looks much better now.

Some smaller issues:

• most important: if there is already data available the dialog should be set to this data. Currently it always shows the current date time (which is annoying if you have to move back e.g. 10 years only because you want to change the time)
• is it possible to add a title to the dialog "such as "Media created" (depending on the use case).
• the seconds can not be set but still appear in the result. So either we should allow editing seconds or we should remove them from the result and always set to 00
• currently it is not possible to edit data in the text field therefore we can remove the showing of the format "yyyy-mm-dd hh:mm:ss", however, once we allow editing via text field
• can you open a new ticket for remaining issue to edit via text field?
• for later when we show format again, hours should be hh, not HH
• The textfield should start at the same position as "Title", "Artist" and "Media URI". Currently there is a little identation

created new ticket for editing in textfield and set this ticket to resolved.

if there is already data available the dialog should be set to this data. Currently it always shows the current date time (which is annoying if you have to move back e.g. 10 years only because you want to change the time)

This is fixed if data is persisted, if data is not yet persisted or persisted with a different date (because you recently changed it) than the persisted or the current date is taken. But it should always open with the currently shown date.

needs to be fixed completely in 4.10

There is another critical issue. If you select e.g. July than June is written into the textfield. Looks like incorrect counting start is taken. Can you fix this immediately (should not take much time I guess).

I don't understand why you moved this to 4.10 (98% seems to be implemented in 4.8 therefore we should keep it there for documentation). "Edit Date in TextField" has been moved to a new ticket #6741 and some major bug (has been fixed in 4.9.0 and 4.9.1).

Only remaining issue to me seems: "This is still an open issue. The label is correct, but the text field has an indentation". But please read the full ticket carefully if there is maybe still something else open. I didn't check intensively.

And another new open issue is: #6558

Applied in changeset taxeditor|e38ddfeee4a59c876fedd950b64cb99147e4f865.

removed the indention. So we can close the ticket?