Project

General

Profile

feature request #6658

Make mediaCreated editable in Media view

Added by Andreas Müller over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
05/20/2017
Due date:
% Done:

100%

Severity:
critical

Description

Media has beside CdmBase.created another data called Media.mediaCreated.

This needs to be editable but currently isn't in the media view.


Related issues

Related to Edit - feature request #6659: Show mediaCreated in dataportal Closed 05/20/2017
Related to Edit - feature request #6607: Implement WebSite.accessed in TaxEditor Closed 04/30/2017
Related to Edit - feature request #6741: Edit Date in TextField New 06/20/2017
Related to Edit - bug #6860: Use consistent calendar system for date picker Closed 07/31/2017
Related to Edit - bug #7074: Use TimePeriod for Media.mediaCreated Closed 11/11/2017

Associated revisions

Revision 6430b43e (diff)
Added by Katja Luther over 1 year ago

fix #6658: add mediaCreated date field

Revision eb057b29 (diff)
Added by Katja Luther over 1 year ago

fix #6664: set value of mediaCreated correctly

Revision 97623d1d (diff)
Added by Katja Luther over 1 year ago

ref #6658: add calendar widget to dateElement

Revision dd665bef (diff)
Added by Katja Luther over 1 year ago

ref #6658: show actual data in DateElement and add title

Revision 2901517f (diff)
Added by Katja Luther over 1 year ago

add 1 to the month to get the right date out of the swt.DateTime

Revision 754477ec (diff)
Added by Andreas Müller over 1 year ago

ref #6658 remove 1 when mapping joda.DateTime.month to swt.DateTime

Revision b18418d0 (diff)
Added by Andreas Müller over 1 year ago

ref #6658 remove 1 when mapping joda.DateTime.month to swt.DateTime (II)

Revision eeaf7d09 (diff)
Added by Andreas Müller over 1 year ago

ref #6658 remove 1 when mapping joda.DateTime.month to swt.DateTime

Revision 6166b89a (diff)
Added by Andreas Müller over 1 year ago

ref #6658 remove 1 when mapping joda.DateTime.month to swt.DateTime (II)

Revision e38ddfee (diff)
Added by Katja Luther about 1 year ago

fix #6658: remove the indentation from text field of dateElement

History

#1 Updated by Andreas Müller over 1 year ago

#2 Updated by Andreas Müller over 1 year ago

#3 Updated by Andreas Müller over 1 year ago

  • Assignee changed from Patrick Plitzner to Katja Luther
  • Priority changed from New to Highest
  • Target version changed from Unassigned CDM tickets to Release 4.8

#4 Updated by Katja Luther over 1 year ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#5 Updated by Andreas Müller over 1 year ago

  • Assignee changed from Katja Luther to Andreas Müller

#6 Updated by Andreas Müller over 1 year ago

  • Assignee changed from Andreas Müller to Katja Luther

Sorry maybe it was too early to pass to assign to me. With current version the media is not yet stored in DB and even not in session as far as I can see.

#7 Updated by Katja Luther over 1 year ago

  • Assignee changed from Katja Luther to Andreas Müller

the problem was that the start value of the mediaCreated field was not set correctly. It was saved but not displayed.

Now this is fixed, please review.

#8 Updated by Andreas Müller over 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Generally it works, but there is no check for correct format.

However, there are a couple of problems related to the pure text input:

  • No user visible format check exists: Compare e.g. with URI for format checking (red text if format is not correct). E.g. the user is not informed about entering just "xxx" has no effect on the data.
  • It is not possible to enter time. Sometimes time might be an interesting information which gets completely lost. Also the user is not informed about the fact that it gets lost.
  • If entering only a year this is transformed to the year on Jan. 1st. But the user is not informed about this changed.
  • Entering e.g. 2008-02-30 may result in 2008-02-03 without the user being informed. This is because only the intermediate state is changed.
  • Generally it is often more comfortable using a calendar entry component. Could you please leave a message in any of the DateTime tickets what the problem with the Calendar element e.g. from nebula is. Also leave a message where else the current solution is used so it can be changed in bulk once we have a better solution.

If using a Calendar component is to much work for now, we may stay with the text element but we should as a minimum implement a format check. If we allow only yyyy-mm-dd the data should be changed ONLY if it comes EXACTLY in this format. And the user should be informed in RED that the data is not stored or completely deleted if this red label appears.

By the way the label says "yyyy-MM-dd". Can we change this to "yyyy-mm-dd". Even if maybe not consistent with DateTime format rules it is easier to understand by ordinary users.

#9 Updated by Katja Luther over 1 year ago

  • Assignee changed from Katja Luther to Andreas Müller

now there is a calendar widget to choose the date and the time.

The DateElement is used for DNAQualityCheck (qualityCheckDate), Reference (accessed) and MediaSpecimen(preparationDate).
The DateElement provides the possibility to edit also the textfield, but as long as we do not have a proper handling for wrong formated strings, this is disabled.

#10 Updated by Andreas Müller over 1 year ago

  • Status changed from Feedback to Resolved

#11 Updated by Andreas Müller over 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

It looks much better now.

Some smaller issues:

  • most important: if there is already data available the dialog should be set to this data. Currently it always shows the current date time (which is annoying if you have to move back e.g. 10 years only because you want to change the time)
  • is it possible to add a title to the dialog "such as "Media created" (depending on the use case).
  • the seconds can not be set but still appear in the result. So either we should allow editing seconds or we should remove them from the result and always set to 00
  • currently it is not possible to edit data in the text field therefore we can remove the showing of the format "yyyy-mm-dd hh:mm:ss", however, once we allow editing via text field
  • can you open a new ticket for remaining issue to edit via text field?
  • for later when we show format again, hours should be hh, not HH
  • The textfield should start at the same position as "Title", "Artist" and "Media URI". Currently there is a little identation

#12 Updated by Katja Luther over 1 year ago

#13 Updated by Katja Luther over 1 year ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

created new ticket for editing in textfield and set this ticket to resolved.

#14 Updated by Andreas Müller over 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

if there is already data available the dialog should be set to this data. Currently it always shows the current date time (which is annoying if you have to move back e.g. 10 years only because you want to change the time)

This is fixed if data is persisted, if data is not yet persisted or persisted with a different date (because you recently changed it) than the persisted or the current date is taken. But it should always open with the currently shown date.

#15 Updated by Andreas Müller over 1 year ago

The textfield should start at the same position as "Title", "Artist" and "Media URI". Currently there is a little indentation.

This is still an open issue. The label is correct, but the text field has an indentation

#16 Updated by Katja Luther over 1 year ago

  • Target version changed from Release 4.8 to Release 4.10

needs to be fixed completely in 4.10

#17 Updated by Andreas Müller over 1 year ago

  • Severity changed from normal to critical

There is another critical issue. If you select e.g. July than June is written into the textfield. Looks like incorrect counting start is taken. Can you fix this immediately (should not take much time I guess).

#18 Updated by Katja Luther over 1 year ago

Andreas Müller wrote:

There is another critical issue. If you select e.g. July than June is written into the textfield. Looks like incorrect counting start is taken. Can you fix this immediately (should not take much time I guess).

This is strange because the toString-method of joda time is used to set the text:

this.textDate.setText(initialDateTime.toString(pattern));

I will have a look at this.

#19 Updated by Katja Luther over 1 year ago

Katja Luther wrote:

Andreas Müller wrote:

There is another critical issue. If you select e.g. July than June is written into the textfield. Looks like incorrect counting start is taken. Can you fix this immediately (should not take much time I guess).

This is strange because the toString-method of joda time is used to set the text:
~~~ java
this.textDate.setText(initialDateTime.toString(pattern));
~~~

I will have a look at this.

swt.DateTime starts with 0 as the first month, so adding 1 to fit with joda time.

#20 Updated by Andreas Müller over 1 year ago

you also need to substract 1 when reading joda.DateTime to swt.DateTime. Otherwise you increase existing data by 1 month each time you open the editor and store the data. Implemented with taxeditor|754477ecee0a6cc9e77686b533ceee623702ee30 and taxeditor|b18418d0b56a957b3c0490fc72dc7957a6952f53

#21 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 4.10 to Release 4.8

I don't understand why you moved this to 4.10 (98% seems to be implemented in 4.8 therefore we should keep it there for documentation). "Edit Date in TextField" has been moved to a new ticket #6741 and some major bug (has been fixed in 4.9.0 and 4.9.1).

Only remaining issue to me seems: "This is still an open issue. The label is correct, but the text field has an indentation". But please read the full ticket carefully if there is maybe still something else open. I didn't check intensively.

And another new open issue is: #6558

#22 Updated by Andreas Müller about 1 year ago

  • Related to bug #6860: Use consistent calendar system for date picker added

#23 Updated by Katja Luther about 1 year ago

  • Status changed from Feedback to Resolved

#24 Updated by Katja Luther about 1 year ago

  • Assignee changed from Katja Luther to Andreas Müller

removed the indention. So we can close the ticket?

#25 Updated by Andreas Müller about 1 year ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 100

#26 Updated by Andreas Müller about 1 year ago

  • Related to bug #7074: Use TimePeriod for Media.mediaCreated added

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)