bug #6614
cdm_taxontree: plus/minus/loading gifs not correctly loaded
0%
Description
When navigating the taxontree the small icons to close/expand the subtree disappear. The regex misses to match a ".
cdm_taxontree.js
195: var bg_image_tmp = jQuery(this).css('background-image');
196: var bg_image_new = bg_image_tmp.replace(/.*(\/.*)())$/, '$1/' + imageFile + '$3');
197: if (jQuery.browser.mozilla) {
198: // Special bug handling for mozilla: strip of last closing bracket.
199: bg_image_new = bg_image_new.substr(0, bg_image_new.length - 1);
This is actually not a bug in mozilla.
bg_img_tmp: url("http://portal.cybertaxonomy.org/flora-guianas/sites/flora-guianas/modules/cdm_dataportal/cdm_taxontree/plus.png")
bg_image_new: url("http://portal.cybertaxonomy.org/flora-guianas/sites/flora-guianas/modules/cdm_dataportal/cdm_taxontree/loading_subtree.gif)
bg_image_new actually misses a " before the closing parenthesis, because it's matched in group $2. The "fix" removes enough from the string that firefox can autofix it.
Chrome throws something like this:
GET http://portal.cybertaxonomy.org/flora-guianas/sites/flora-guianas/modules/cdm_dataportal/cdm_taxontree/minus.png) 404 (Not Found)
Notice the closing bracket in the end.
Associated revisions
ref #6614: icons to travers taxontree appear correctly.
fixes the regex so $3 correctly includes the double-quote rather than $2.
The distinction for mozilla is therefore no longer needed.
Merge remote-tracking branch 'origin/6614_cdm_taxontree' into develop
History
#1 Updated by Saskia Gennrich over 3 years ago
- Assignee changed from Saskia Gennrich to Andreas Kohlbecker
#2 Updated by Andreas Kohlbecker over 3 years ago
- Status changed from New to Feedback
- Assignee changed from Andreas Kohlbecker to Saskia Gennrich
- Priority changed from New to Priority14
- Target version changed from Unassigned CDM tickets to Release 4.7
Hi Saskia,
thank you for the bugfix. The commit looks good, please merge the changes into the develop branch.
Andreas
#3 Updated by Andreas Kohlbecker over 3 years ago
I finally merged the branch into develop
#4 Updated by Andreas Müller over 3 years ago
So can we close the ticket?
And can you please adapt the "Subject" in a way that it is easier to read for standard users?
#5 Updated by Saskia Gennrich over 3 years ago
- Status changed from Feedback to Closed
Sorry, forgot that I was supposed to merge it in develop.
What would be a more appropriate Subject line?