Project

General

Profile

Actions

bug #6614

closed

cdm_taxontree: plus/minus/loading gifs not correctly loaded

Added by Saskia Gennrich almost 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Priority14
Assignee:
Saskia Gennrich
Category:
cdm-dataportal
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Severity:
normal
Found in Version:

Description

When navigating the taxontree the small icons to close/expand the subtree disappear. The regex misses to match a ".

cdm_taxontree.js
195: var bg_image_tmp = jQuery(this).css('background-image');
196: var bg_image_new = bg_image_tmp.replace(/.*(\/.*)())$/, '$1/' + imageFile + '$3');
197: if (jQuery.browser.mozilla) {
198: // Special bug handling for mozilla: strip of last closing bracket.
199: bg_image_new = bg_image_new.substr(0, bg_image_new.length - 1);

This is actually not a bug in mozilla.

bg_img_tmp: url("http://portal.cybertaxonomy.org/flora-guianas/sites/flora-guianas/modules/cdm_dataportal/cdm_taxontree/plus.png")
bg_image_new: url("http://portal.cybertaxonomy.org/flora-guianas/sites/flora-guianas/modules/cdm_dataportal/cdm_taxontree/loading_subtree.gif)

bg_image_new actually misses a " before the closing parenthesis, because it's matched in group $2. The "fix" removes enough from the string that firefox can autofix it.
Chrome throws something like this:
GET http://portal.cybertaxonomy.org/flora-guianas/sites/flora-guianas/modules/cdm_dataportal/cdm_taxontree/minus.png) 404 (Not Found)

Notice the closing bracket in the end.

Actions #1

Updated by Saskia Gennrich almost 7 years ago

  • Assignee changed from Saskia Gennrich to Andreas Kohlbecker
Actions #2

Updated by Andreas Kohlbecker almost 7 years ago

  • Status changed from New to Feedback
  • Assignee changed from Andreas Kohlbecker to Saskia Gennrich
  • Priority changed from New to Priority14
  • Target version changed from Unassigned CDM tickets to Release 4.7

Hi Saskia,

thank you for the bugfix. The commit looks good, please merge the changes into the develop branch.

Andreas

Actions #3

Updated by Andreas Kohlbecker almost 7 years ago

I finally merged the branch into develop

Actions #4

Updated by Andreas Müller almost 7 years ago

So can we close the ticket?

And can you please adapt the "Subject" in a way that it is easier to read for standard users?

Actions #5

Updated by Saskia Gennrich almost 7 years ago

  • Status changed from Feedback to Closed

Sorry, forgot that I was supposed to merge it in develop.

What would be a more appropriate Subject line?

Actions

Also available in: Atom PDF