EDIT

· Die Option „Lösche das Medianobjekt, auch wenn es von einem Specimen verwendet wird“ verstehe ich nicht ganz. Welcher spezielle Usecase soll hier behandelt werden?

CRITICAL: you have removed the according checkbox, but as far as what I can see the following happens now:

If you choose "delete the media object" the media is removed even if linked by a specimen description (or maybe any other link). This should not be possible. The specimen link is even not removed from the DB but links to a not existing record. This is very critical as it results in inconsistent data.

We should adapt the label to "Delete media record from database if possible" and implement this option in a way that it is not possible to delete if linked from elsewhere.

By the way I would set the default to this option because I don't think people expect media to stay in the database if removed from image gallery but not referenced elsewhere.

Andreas Müller wrote:

I just realized that also in the Media bulk editor CRITICAL things happen. Even if you do NOT check "Delete the media object even if it is part of a taxon description", the media is deleted if it is part of a taxon description. The related image gallery afterwards links to a missing record. Very bad (Trump speech).

I wonder that hibernate allows creation of such corrupted data.

This is fixed by the fix of the isDeletable method.

Andreas Müller wrote:

· Die Option „Lösche das Medianobjekt, auch wenn es von einem Specimen verwendet wird“ verstehe ich nicht ganz. Welcher spezielle Usecase soll hier behandelt werden?

CRITICAL: you have removed the according checkbox, but as far as what I can see the following happens now:

If you choose "delete the media object" the media is removed even if linked by a specimen description (or maybe any other link). This should not be possible. The specimen link is even not removed from the DB but links to a not existing record. This is very critical as it results in inconsistent data.

We should adapt the label to "Delete media record from database if possible" and implement this option in a way that it is not possible to delete if linked from elsewhere.

By the way I would set the default to this option because I don't think people expect media to stay in the database if removed from image gallery but not referenced elsewhere.

This is done, but I used the term media data, because I think media record is also a technical term??
But I can also change it to media record.

Katja Luther wrote:

This is done, but I used the term media data, because I think media record is also a technical term??
But I can also change it to media record.

The title still says "Wollen sie wirklich das Medienobjekt löschen?", please change to "... die Mediendaten...".

Further more in option 1 you say "Lösche die Mediendaten" while in option 2 you say "Entferne Mediendaten". Either both times use "die" or never. I prefer not to use it.

Further more I suggest to add "Lösche Mediendaten aus der Datenbank, wenn ...". This makes the distinction to option 2 most clear where we say "... aus der Gallerie"

In German I would prefer "Wollen Sie die Mediendaten wirklich löschen?" statt "Wollen Sie wirklich die Mediendaten löschen.

If choosing "Delete media data, if not referenced by other data" now returns a kind of error saying that it is not possible to delete, because the media data is referenced (at least if the media data is really used elsewhere).
The media is NOT removed from the gallery.

This is not the expected behavior. I would expect that the media is removed from the gallery but a warning is given, that it could not be completely removed from the database because it is used elsewhere. This is something we have already elsewhere (I think when deleting taxa and checking if the name can also be deleted or something similar).

This is also why I originally suggested to say "Delete media data if possible". Maybe we can change the label to "Remove media data from gallery and remove from database if possible/if not referenced elsewhere". Too long?

By the way, we may need the same configurator for "Image gallery delete". To me it looks like this currently does not delete the media completely but only deletes the image gallery while the media are still in the DB. The same might be true for deleting the complete taxon or even taxon subtrees. We need to integrate this to all configurators. Feel free to create new ticket(s) for this.