Project

General

Profile

bug #6484

Include all paramaters of FindOccurrencesConfigurator in HQL query

Added by Patrick Plitzner over 2 years ago. Updated 20 days ago.

Status:
New
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
03/09/2017
Due date:
% Done:

20%

Severity:
normal
Found in Version:
Tags:

Description

Currently AssignmentStatus and isRetrieveIndirectlyAssociatedSpecimens() are not queried via HQL but in the service method via a for loop. This is very time consuming and also does not allow to use these parameters in the countOccurrences() method.

Associated revisions

Revision 2023e9a6 (diff)
Added by Patrick Plitzner over 2 years ago

ref #6484 Fix test for specimen count retrieval

  • temporary fix until ticket is solved

Revision 1cfc76cb (diff)
Added by Patrick Plitzner over 1 year ago

ref #6484 Move enum AssignmentStatus to cdm-persistence

Revision 7dab8082 (diff)
Added by Patrick Plitzner over 1 year ago

ref #6484 Adjust count method to find method to return the same number

  • performance can still be improved by integrating AssignmentStatus and/or indirectlyAssociatedSpecimen into the HQL query

History

#1 Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 4.7 to Release 4.8

#2 Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 4.8 to Release 4.9

#3 Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 4.9 to Release 4.10

#4 Updated by Andreas Müller about 2 years ago

  • Target version changed from Release 4.10 to Release 4.11

#5 Updated by Andreas Müller about 2 years ago

  • Target version changed from Release 4.11 to Release 4.12

#6 Updated by Andreas Müller about 2 years ago

  • Target version changed from Release 4.12 to Release 4.13

#7 Updated by Andreas Müller almost 2 years ago

  • Target version changed from Release 4.13 to Release 4.14

#8 Updated by Andreas Müller almost 2 years ago

  • Target version changed from Release 4.14 to Release 5.0

#9 Updated by Patrick Plitzner over 1 year ago

  • Priority changed from Highest to Priority12
  • Target version changed from Release 5.0 to Reviewed Next Major Release
  • % Done changed from 0 to 20

#10 Updated by Andreas Müller 10 months ago

  • Priority changed from Priority12 to Priority11

#11 Updated by Andreas Müller 20 days ago

  • Tags set to pp_uebergabe
  • Target version changed from Reviewed Next Major Release to Additivity experimental

Can you give some more information about context (specimen tree, matrix, dataportal, ...?) and other information required to solve the ticket.

#12 Updated by Patrick Plitzner 20 days ago

  • Assignee changed from Patrick Plitzner to Andreas Müller

This configurator is used in a lot of places: specimen tree editor, specimen facet search (experimental), TaxonService, SpecimenImport, ...(results from string search of the workspace)

The service method to look for is OccurrenceServiceImpl.findByTitle()

The two mentioned options AssignmentStatus and indirectlyAssociatedSpecimen are currently evaluated in an extra loop in OccurrenceServiceImpl.filterOccurencesByAssignmentAndHierarchy(), which could maybe be integrated into the database query. This is especially bad for the countByTitle() method which currently loads the objects because of that instead of just retrieving the count from the DB.

AssignmentStatus: enum to define whether the specimen have an association to a taxon or not
indirectlyAssociatedSpecimen: if true the complete derivative hierarchy including all parent and child derivatives is returned of the associated specimen

#13 Updated by Andreas Müller 20 days ago

  • Priority changed from Priority11 to Highest
  • Target version changed from Additivity experimental to Release 5.12

Ok, this makes it much clearer. I will have a look if this can be implemented somehow.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)