Project

General

Profile

bug #6459

feature request #4719: [MASTER] Implement IntextReference

Implement deduplication for IntextReferences

Added by Andreas Müller almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
03/02/2017
Due date:
% Done:

70%

Severity:
normal
Found in Version:

Description

Currently if references are merged the markup text referenced by an IntextReference using this reference is not changed.

Open issues:

  • Add further tests for all Target classes (currently we have only for Reference)
  • Add test that other language string texts are not changed somehow
  • Try to update via HQL instead of using POJOs (discuss if this is relevant at all)

Related issues

Related to Edit - feature request #4706: Create IntextReference Closed 03/12/2015 03/18/2015
Related to Edit - bug #6511: Handling of objects being referenced in a InTextReference during deleting Rejected 03/15/2017

Associated revisions

Revision 3c6ba3cd (diff)
Added by Andreas Müller almost 2 years ago

fix #6459 Implement deduplication for IntextReferences

Revision c524a825 (diff)
Added by Andreas Müller almost 2 years ago

fix #6459 Implement deduplication for IntextReferences (add interface to SpecimenOrObservationBase)

Revision bd1bf93c (diff)
Added by Andreas Müller almost 2 years ago

ref #6459 added IntextReferenceHelper class and added some more tests (for name and Annotation)

History

#1 Updated by Andreas Müller almost 2 years ago

  • Status changed from New to In Progress

#2 Updated by Andreas Müller almost 2 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 50

#3 Updated by Andreas Müller almost 2 years ago

  • Description updated (diff)
  • % Done changed from 50 to 0

#4 Updated by Andreas Müller almost 2 years ago

#5 Updated by Andreas Müller almost 2 years ago

#7 Updated by Andreas Müller almost 2 years ago

  • Assignee changed from Andreas Müller to Katja Luther

Could you please review

#8 Updated by Katja Luther over 1 year ago

  • Status changed from Resolved to Feedback

there are not all cases covered by the tests, espacially the usecase of deleting the intextReferenceTarget.
the rest looks fine.

I create a new ticket for the handling of inTextReferenceTarget handling while deleting.

#9 Updated by Katja Luther over 1 year ago

  • Related to bug #6511: Handling of objects being referenced in a InTextReference during deleting added

#10 Updated by Katja Luther over 1 year ago

  • Assignee changed from Katja Luther to Andreas Müller

#11 Updated by Andreas Müller over 1 year ago

  • Parent task set to #6514

#12 Updated by Andreas Müller over 1 year ago

  • % Done changed from 0 to 70
  • Parent task changed from #6514 to #4719

#13 Updated by Andreas Müller over 1 year ago

Katja Luther wrote:

there are not all cases covered by the tests, especially the usecase of deleting the intextReferenceTarget.
the rest looks fine.

I create a new ticket for the handling of intextReferenceTarget handling while deleting.

Are there any other open issues or can we close the ticket?

#14 Updated by Andreas Müller over 1 year ago

  • Assignee changed from Andreas Müller to Katja Luther

#15 Updated by Katja Luther over 1 year ago

  • Status changed from Feedback to Closed
  • Assignee changed from Katja Luther to Andreas Müller

no open issues without a ticket, so we can close the ticket

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)