Project

General

Profile

Actions
Copy link

bug #6385

closed

Specimen Editor should handle new search same as bulk editor

Added by Andreas Müller about 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Katja Luther
Category:
taxeditor
Target version:
Release 4.7
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:

Description

For the bulk editors we realised that a new search should trigger a completely new session. Which also includes asking if potential changes (dirty data) should be thrown away a saved before new search.

Currently this is not the case in the specimen editor.

Generally the behavior (also for delete etc.) should be similar. How can this be guaranteed?

Actions
Copy link
 #1

Updated by Andreas Müller about 7 years ago

Katja, could you please add the existing similar ticket for the bulk editor as a related ticket?

Actions
Copy link
 #2

Updated by Andreas Müller about 7 years ago

  • Priority changed from New to Highest
  • Target version changed from Unassigned CDM tickets to Release 4.6
Actions
Copy link
 #3

Updated by Andreas Müller about 7 years ago

  • Target version changed from Release 4.6 to Release 4.7
Actions
Copy link
 #4

Updated by Katja Luther about 7 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions
Copy link
 #6

Updated by Katja Luther about 7 years ago

@Patrick: I was working on the specimen editor, so I fixed it already. Please review.

Actions
Copy link
 #7

Updated by Patrick Plitzner almost 7 years ago

  • Assignee changed from Patrick Plitzner to Katja Luther

You should not invoke dispose() on the part because this is a UI method which is used to free any resources like handlers, listeners and images. I think you only want to close and open a new session. So we should extract that code into a new method which you can use in this case and which is also invoked by the dipsose() method

Actions
Copy link
 #8

Updated by Andreas Müller almost 7 years ago

  • Status changed from Resolved to Feedback
Actions
Copy link
 #9

Updated by Katja Luther almost 7 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link
 #10

Updated by Katja Luther almost 7 years ago

  • Assignee changed from Katja Luther to Patrick Plitzner

now cdmEntitySession.dispose() is called instead of editor.dispose(), so that only the session is closed, this method is also called in editor.dispose()

Actions
Copy link
 #11

Updated by Patrick Plitzner almost 7 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Patrick Plitzner to Katja Luther
  • % Done changed from 50 to 100

seems fine

Actions
Copy link
 #12

Updated by Patrick Plitzner almost 7 years ago

taxeditor|9f5ce1e084d9a4d3c41e774f657cd97cf79e3bbb.
Ask for save before another search

Actions
Copy link

Also available in: Atom PDF