Project

General

Profile

bug #6385

Specimen Editor should handle new search same as bulk editor

Added by Andreas Müller almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
01/25/2017
Due date:
% Done:

100%

Severity:
normal
Found in Version:

Description

For the bulk editors we realised that a new search should trigger a completely new session. Which also includes asking if potential changes (dirty data) should be thrown away a saved before new search.

Currently this is not the case in the specimen editor.

Generally the behavior (also for delete etc.) should be similar. How can this be guaranteed?

Associated revisions

Revision 9f5ce1e0 (diff)
Added by Katja Luther over 1 year ago

fix #6385: new search, new session for specimen editor

Revision 9fc9ae69 (diff)
Added by Katja Luther over 1 year ago

fix #6385: use only session.dispose() instead of editor.dispose()

History

#1 Updated by Andreas Müller almost 2 years ago

Katja, could you please add the existing similar ticket for the bulk editor as a related ticket?

#2 Updated by Andreas Müller almost 2 years ago

  • Priority changed from New to Highest
  • Target version changed from Unassigned CDM tickets to Release 4.6

#3 Updated by Andreas Müller almost 2 years ago

  • Target version changed from Release 4.6 to Release 4.7

#4 Updated by Katja Luther over 1 year ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#6 Updated by Katja Luther over 1 year ago

@Patrick: I was working on the specimen editor, so I fixed it already. Please review.

#7 Updated by Patrick Plitzner over 1 year ago

  • Assignee changed from Patrick Plitzner to Katja Luther

You should not invoke dispose() on the part because this is a UI method which is used to free any resources like handlers, listeners and images. I think you only want to close and open a new session. So we should extract that code into a new method which you can use in this case and which is also invoked by the dipsose() method

#8 Updated by Andreas Müller over 1 year ago

  • Status changed from Resolved to Feedback

#9 Updated by Katja Luther over 1 year ago

  • Status changed from Feedback to Resolved

#10 Updated by Katja Luther over 1 year ago

  • Assignee changed from Katja Luther to Patrick Plitzner

now cdmEntitySession.dispose() is called instead of editor.dispose(), so that only the session is closed, this method is also called in editor.dispose()

#11 Updated by Patrick Plitzner over 1 year ago

  • Status changed from Resolved to Closed
  • Assignee changed from Patrick Plitzner to Katja Luther
  • % Done changed from 50 to 100

seems fine

#12 Updated by Patrick Plitzner over 1 year ago

taxeditor|9f5ce1e084d9a4d3c41e774f657cd97cf79e3bbb.
Ask for save before another search

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)