bug #6324
closed
fix dozer mapping after removal of synonym relations and after using TaxonNode
Added by Andreas Kohlbecker over 7 years ago.
Updated about 3 years ago.
Description
the the dozer mapping file /cdmlib-remote/src/main/resources/eu/etaxonomy/cdm/remote/dto/tdwg/mappings-deep.xml a per field mapping is defined for synonymRelations which is no longer valid after the removal of the synonym relations.
<field>
<a>synonymRelations</a>
<b>hasRelationship</b>
<a-hint>eu.etaxonomy.cdm.model.taxon.TaxonRelationship</a-hint>
<b-hint>eu.etaxonomy.cdm.remote.dto.tdwg.voc.Relationship</b-hint>
</field>
up to date dozer documentation if found at https://dozermapper.github.io/gitbook/
- Subject changed from fix docker mapping after removal of synonym relations to fix dozer mapping after removal of synonym relations
- Has duplicate bug #6948: OAIPMH service broken by NPE with verb=ListIdentifiers & set=taxon added
- Status changed from New to In Progress
- Priority changed from New to Highest
- Target version changed from Unassigned CDM tickets to Release 4.10
- Description updated (diff)
The issue #6948 is fixed now, but the broken mapping needs to be reestablished. So this issue needs to be kept open until this is done.
- Tags set to oaipmh
- Priority changed from Highest to Priority12
- Target version changed from Release 4.10 to Reviewed Next Major Release
Even if duplicate issue is closed now this issue here can not yet be closed since its solution requires additional work.
- Priority changed from Priority12 to Priority09
- Related to bug #5095: Fix failing dozer related tests added
- Status changed from In Progress to Resolved
- % Done changed from 0 to 50
- Target version changed from Reviewed Next Major Release to Release 5.21
- Subject changed from fix dozer mapping after removal of synonym relations to fix dozer mapping after removal of synonym relations and after using TaxonNode
The mapping was not only corrupt for synonyms but also for TaxonNodes as they were not mapped as taxon relations yet. There was no test finding this, yet.
I added mapping also for TaxonNode (a bit preliminary as the TDWG Ontology is not really used much and I didn't want to spend too much time on it) and changed the title of the ticket to include taxon nodes.
Please review.
- Related to task #9454: [DISCUSS] Decide on using dozer or similar frameworks for mapping DTOs added
- Assignee changed from Andreas Kohlbecker to Andreas Müller
I could not inspect all code changes in depth as this would require more time to dive into the whole topic of relation in the TDWG Ontology etc.
From the birs perspective this looks ok and can be release as is.
One minor note only: in cdmlib-remote/src/main/resources/eu/etaxonomy/cdm/remote/dto/tdwg/mappings-deep.xml there is a comment:
<!-- not fully correct to only use the first node, needs custom converter to implement correctly -->
the custom converter seems to be use already, though.
isn't this a ticket for 5.20.0 ?
- Assignee changed from Andreas Müller to Andreas Kohlbecker
No there is no custom converter in use yet for field taxonNodes. But ofcourse we use it elsewhere e.g. here
<field type="one-way" custom-converter-id="hibernateProxyDeepConverter" custom-converter-param="authorship">
I is not a big issue to create one. However, having >1 taxon node is extremely seldom in existing data. Also it is expected that we will have a model change here in the nearer future so for me it was not worse to implement this (also because the TDWG ontology is not really in use anymore and therefore this issue has no high priority)
- Target version changed from Release 5.21 to Release 5.20
Andreas Müller wrote:
No there is no custom converter in use yet for field taxonNodes. But ofcourse we use it elsewhere e.g. here
<field type="one-way" custom-converter-id="hibernateProxyDeepConverter" custom-converter-param="authorship">
I is not a big issue to create one. However, having >1 taxon node is extremely seldom in existing data. Also it is expected that we will have a model change here in the nearer future so for me it was not worse to implement this (also because the TDWG ontology is not really in use anymore and therefore this issue has no high priority)
Agreed, ticket can be closed.
- Assignee changed from Andreas Kohlbecker to Andreas Müller
- Status changed from Resolved to Closed
- % Done changed from 50 to 100
Also available in: Atom
PDF