bug #6045
NPE when using TaxonNaturalComparator
50%
Description
When sorting a taxon hierarchy like the following:
/*
* Classification
* * Abies
* `- Abies alba
* * Pinus
* `- Pinus pampa
*/
the comparator throws an NPE when sorting Abies alba and Pinus pampa.
Associated revisions
ref #6045 Fix NPE for TaxonNaturalComparator
- fix getAncestors() method of taxon node
- added JUnit test
ref #6045 Fix NPE for TaxonNaturalComparator
- fix getAncestors() method of taxon node
- added JUnit test
fix #6045: fixing the NaturalOrderComparator and complete the test
fix #6045: fixing the NaturalOrderComparator and complete the test
ref #6045 Add test for getAncestor()
ref #6045 Add test for getAncestor()
ref #6045 some comments and clean up
ref #6045 Fix NPE for TaxonNaturalComparator
- fix getAncestors() method of taxon node
- added JUnit test
fix #6045: fixing the NaturalOrderComparator and complete the test
ref #6045 Add test for getAncestor()
ref #6045 some comments and clean up
History
#2 Updated by Patrick Plitzner about 5 years ago
- Assignee changed from Patrick Plitzner to Katja Luther
The NPE should be fixed with the attached revision. But I am not sure what the correct natural ordering of taxa looks like.
@Katja: Could you implement the missing check for the correct order in the test eu.etaxonomy.cdm.api.service.TaxonNodeServiceImplTest.testCompareNaturalOrder()?
#4 Updated by Katja Luther about 5 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 50
Applied in changeset edit-svn|r28904.
#5 Updated by Katja Luther about 5 years ago
- Assignee changed from Katja Luther to Patrick Plitzner
please review, the sort order should depend on the sortindex of the taxonnode
#6 Updated by Patrick Plitzner about 5 years ago
- Status changed from Resolved to Closed
- Assignee changed from Patrick Plitzner to Katja Luther
#7 Updated by Andreas Müller about 5 years ago
- Category changed from cdm to cdmlib
