Project

General

Profile

feature request #5974

Remove synonym relationships

Added by Andreas Müller about 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
New
Category:
cdm
Target version:
Start date:
11/14/2016
Due date:
% Done:

100%

Severity:
normal

Description

Synonym relationships are not necessarily needed as a synonym always belongs to 1 explicit taxon. They are only needed for pro parte synonyms, a concept not correct as pro parte indicates concept relationships.

As reusing of synonyms for this incorrect purpose was never asked by users we may remove it.

Open question is if synonym sec and synonym relationship citation are both needed. Probably not with syn sec being the reference saying that the synonym (name) is a synonym of the given concept. The synonym itself does not have a real secundum as it is not a concept, only a name usage. Synonyms mentionied in the same reference as the accepted taxon secundum will get the same syn sec.

This is according to the fact that we use "syn. sec." already instead of sec. for synonyms in dataportal/cache strategy.

We need to check if any reused synonyms exist and if any syn rel citations exist, which may get lost when removing the SynonymRelationship class.

see also #5523


Subtasks

feature request #6198: Remove synonym relationships in TaxEditorClosedPatrick Plitzner

bug #6201: Adapt dataportal to the new synonym datamodelClosedAndreas Kohlbecker

bug #6210: Null values for boolean fields are causing PropertyAccessExceptionClosedAndreas Müller

bug #6211: massive heap consumption by service endpoint /portal/taxon/{uuid}/synonymyClosedAndreas Kohlbecker


Related issues

Related to Edit - feature request #5523: [DISCUSS] Do we need to distinguish homotypic and heterotypic synonym relationships In Progress 02/03/2016
Related to Edit - bug #6323: LIE during request to name_catalogue/taxon.json Closed 01/11/2017
Related to Edit - bug #6324: fix dozer mapping after removal of synonym relations In Progress 01/11/2017
Related to Edit - feature request #7334: Make pro parte and partial synonyms real concept relationships Resolved 03/28/2018
Precedes Edit - task #7319: [CHECK] Import synonyms correctly in E+M Resolved 03/19/2018
Copied to Edit - task #6521: Check existing imports for handling new synonym structure correctly New 03/17/2017

Associated revisions

Revision f476ff86 (diff)
Added by Andreas Müller almost 3 years ago

ref #5974 Remove synonym relationship first compiling implementation in cdmlib

Revision fbeefcaf (diff)
Added by Andreas Müller almost 3 years ago

ref #5974 Replace synonymRelationshipType by SynonymType and replace some other occurrences of synonym relationship

Revision 152fcd76 (diff)
Added by Andreas Müller almost 3 years ago

ref #5974 Replace synonym relationship update scripts (untested)

Revision 3ef2e1bd (diff)
Added by Andreas Müller almost 3 years ago

ref #5974 Remove synonym relationships (not finished yet)

Revision d7fa3e13 (diff)
Added by Andreas Müller almost 3 years ago

fix #5974 fix moving synonym type to TaxonBase and SynonymRelationType label

Revision 15566c6f (diff)
Added by Andreas Müller almost 3 years ago

ref #5974 implement substitute method for TaxonService.getAllRelationships

Revision 0e522f9f (diff)
Added by Andreas Müller almost 3 years ago

ref #5974 Remove synonym relationships

Revision 47936c60 (diff)
Added by Andreas Müller almost 3 years ago

ref #5974 remove synonym relationship and other model changes

Revision 1925e9f2 (diff)
Added by Andreas Müller almost 3 years ago

ref #5974 Fix synonymRelationship issues in vaadin

Revision d34abf30 (diff)
Added by Andreas Müller almost 3 years ago

ref #5974 Remove synonym relationships (compiling)

Revision bdd1bcf5 (diff)
Added by Andreas Müller almost 3 years ago

ref #5974 Remove synonym relationships (rename synRelType to synRel and others)

Revision aa01111e (diff)
Added by Andreas Müller almost 3 years ago

ref #5974 Some synonymRelationship updates and update for dataset.dtd in TaxEditor

Revision 1b945f03 (diff)
Added by Andreas Müller almost 3 years ago

ref #5974 Some synonymRelationship updates

Revision e73a46a0 (diff)
Added by Andreas Müller almost 3 years ago

ref #5974 Some synonymRelationship updates in TaxEditor tests

Revision 45844ac2 (diff)
Added by Andreas Müller almost 3 years ago

ref #5974 fix update script for synonym duplicates

Revision b19c294b (diff)
Added by Andreas Kohlbecker almost 3 years ago

ref #5974 fixing LIE in controller

Revision f3d4c9bc (diff)
Added by Andreas Müller over 2 years ago

Fix proparte is null in update script

Revision 04a88dbc (diff)
Added by Andreas Kohlbecker over 2 years ago

fix #6323 adding missing bean init path missing after ref #5974

Revision 8e6fba80 (diff)
Added by Andreas Kohlbecker over 2 years ago

fix #4377 adding missing bean init path missing after ref #5974

Revision e5dfd829 (diff)
Added by Andreas Müller over 2 years ago

ref #5974 remove synonymRelationships from BfN Import init strategy

Revision 525e5ef8 (diff)
Added by Andreas Müller about 1 year ago

ref #5974 fully remove multi value field logic from AcceptedTaxonBridge

Revision ed06021d (diff)
Added by Andreas Müller about 1 year ago

ref #5974 fully remove multi value field logic from AcceptedTaxonBridge

History

#1 Updated by Andreas Müller almost 3 years ago

  • Description updated (diff)
  • % Done changed from 0 to 40

#2 Updated by Andreas Müller almost 3 years ago

  • Related to feature request #5523: [DISCUSS] Do we need to distinguish homotypic and heterotypic synonym relationships added

#3 Updated by Andreas Müller almost 3 years ago

  • Status changed from New to In Progress

#4 Updated by Andreas Müller almost 3 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 40 to 50

#5 Updated by Andreas Müller almost 3 years ago

  • Private changed from Yes to No

#6 Updated by Andreas Kohlbecker over 2 years ago

  • Related to bug #6323: LIE during request to name_catalogue/taxon.json added

#7 Updated by Andreas Kohlbecker over 2 years ago

  • Related to bug #6324: fix dozer mapping after removal of synonym relations added

#9 Updated by Andreas Müller over 2 years ago

  • Related to task #6521: Check existing imports for handling new synonym structure correctly added

#10 Updated by Andreas Müller over 2 years ago

  • Status changed from Resolved to Closed

This can be closed as we are using it for longer time already. Only open issue might be that imports need to be adapted. Handled in new ticket: #6521

#11 Updated by Andreas Müller over 2 years ago

  • Related to deleted (task #6521: Check existing imports for handling new synonym structure correctly)

#12 Updated by Andreas Müller over 2 years ago

  • Copied to task #6521: Check existing imports for handling new synonym structure correctly added

#13 Updated by Andreas Müller over 1 year ago

  • Precedes task #7319: [CHECK] Import synonyms correctly in E+M added

#14 Updated by Andreas Müller over 1 year ago

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)