Project

General

Profile

Actions

feature request #5972

closed

Prevent user from unwanted author and reference updates

Added by Andreas Müller over 6 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Priority13
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
4:00 h
Severity:
critical

Description

From time to time it happens that users press the "edit" button for editing authors or references.

This is usually unwanted and very risky as the record might be used at many places. We expect that changes should usually take place only in the bulk editor. The only usecase where it is wanted to edit immediately is directly after creating a new record to correct it. E.g. after incorrect parsing it might be wanted.

There are multiple solutions:

  • Make availability of editing button a preference with default to "not available".

  • Check if record is persisted (id > 0), if not, make button available as this is without risk - see entity.isPersisted()

  • Inform the user via dialog box or with red, bold warning that he/she might edit a record that is used elsewhere

  • Check if the record is used elsewhere (via referencing objects). Only allow editing if not used elsewhere (this might be a performance issue the request may take time, we may need a new method that only checks IF the record is used elsewhere, not how and not with initializing any records)

  • same as before but method is only called when record is opened for editing

  • we might also handle this via rights&roles but probably this is not adequate. Generally we allow those users to update agent/reference records but only in bulk editor. We would need TaxEditor specific rights to do so.


Related issues

Related to EDIT - bug #6176: Creating a new Reference throws TOE (TransientObjectException)ClosedAndreas Müller

Actions
Related to EDIT - bug #6178: TOE Exception when creating a new ReferenceDuplicateKatja Luther

Actions
Related to PhycoBank - bug #6185: prevent from erroneous author or reference changesClosedAndreas Kohlbecker

Actions
Related to EDIT - feature request #7706: Warning for reused Media is missingClosedKatja Luther

Actions
Related to EDIT - feature request #6487: Implement warning for multiple used records where ever neededNewKatja Luther

Actions
Actions #1

Updated by Andreas Müller over 6 years ago

  • Assignee changed from Andreas Müller to k.luther -
Actions #2

Updated by Andreas Müller over 6 years ago

  • Description updated (diff)
  • Priority changed from Highest to Priority13
  • Target version changed from Unassigned CDM tickets to Release 4.4
  • Estimated time set to 4:00 h

Decision: for id > 0 implement check for further references and inform the user in red about these references if they exist

Actions #3

Updated by Katja Luther over 6 years ago

  • Status changed from New to In Progress
  • Assignee changed from Katja Luther to Andreas Müller

@AM Please have a look whether the message is ok or if it should be bigger or other text...

Actions #4

Updated by Katja Luther over 6 years ago

  • % Done changed from 0 to 80
Actions #5

Updated by Katja Luther about 6 years ago

  • Related to bug #6175: Exception when deleting transient object added
Actions #6

Updated by Katja Luther about 6 years ago

  • Related to bug #6176: Creating a new Reference throws TOE (TransientObjectException) added
Actions #7

Updated by Katja Luther about 6 years ago

  • Related to deleted (bug #6175: Exception when deleting transient object)
Actions #8

Updated by Andreas Müller about 6 years ago

  • Status changed from In Progress to Resolved
Actions #9

Updated by Andreas Müller about 6 years ago

  • Related to bug #6178: TOE Exception when creating a new Reference added
Actions #10

Updated by Andreas Kohlbecker about 6 years ago

  • Related to bug #6185: prevent from erroneous author or reference changes added
Actions #11

Updated by Andreas Müller about 6 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

I would change the label to "This reference is referenced by xxx records. The change will take for all these records."

Make it bold.

Background should be gray, as it is not an editable part (like for other labels, too).

Have more spacing around the label.

Actions #12

Updated by Andreas Müller about 6 years ago

It looks like it wokrs only for references until now. But we need it for all objects (if this is difficult, at least for authors).

Actions #13

Updated by Andreas Müller about 6 years ago

  • Private changed from Yes to No
Actions #14

Updated by Andreas Müller over 4 years ago

I think this is fixed or mostly fixed. Can you please check and give me back for review if you think it is fixed?

Actions #15

Updated by Andreas Müller over 4 years ago

Actions #16

Updated by Andreas Kohlbecker over 4 years ago

  • Description updated (diff)

we might also handle this via rights&roles but probably this is not adequate. Generally we allow those users to update agent/reference records but only in bulk editor. We would need TaxEditor specific rights to do so.

I think a combination of appropriate permissions and blocking the modification of entities which are used elsewhere would be a suitable solution. see #4305 for an in depth discussion

Actions #17

Updated by Katja Luther over 1 year ago

  • Status changed from Feedback to Closed
  • % Done changed from 80 to 100

Andreas Müller wrote:

It looks like it wokrs only for references until now. But we need it for all objects (if this is difficult, at least for authors).

For references and authors it is implemented. For other elements we should have a new ticket.(#6487)

Actions #18

Updated by Katja Luther over 1 year ago

Actions

Also available in: Atom PDF