Project

General

Profile

feature request #5971

feature request #3958: Handle CDMPreference table

bug #6105: Make CdmPreferences editable in separate view

Implement database wide CdmPreference writing

Added by Andreas Müller about 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
07/08/2016
Due date:
% Done:

100%

Estimated time:
3.00 h
Severity:
normal

Description

Similar to TaxEditor preferences CDM Preferences need to be inserted/updated.

In the new "Admin" main menu we need an additional sub menu item "CDM Preferences". This will open a dialog / assistant to set the preferences. We will start with enum PreferencePredicate#NomenclaturalCode. This is a dropdown with values from enum NomenclaturalCode and a checkbox for "allowOverride".

see also #5969, #3958, #5970


Related issues

Related to Edit - feature request #5969: Implement CdmPreference reading for database preferences Closed 07/08/2016
Related to Edit - bug #6215: NPE when opening preferences with no DB connection Closed 11/23/2016

Associated revisions

Revision be140ab3 (diff)
Added by Katja Luther almost 3 years ago

ref #5971: add an admin page to the prefs and add cdm pref nomenclatural code

Revision 9d8df0cf (diff)
Added by Katja Luther almost 3 years ago

ref #5971: don't allow to edit local nomenclatural code if allowOverride is false

Revision e9773ade (diff)
Added by Katja Luther over 2 years ago

ref #5971: new main menu admin with cdm preference nomenclatural code and insert polytomous key node

Revision 0bd095d9 (diff)
Added by Katja Luther over 2 years ago

fix #5971: admin menu is visible only if connected and user has role manager

Revision bb920fa1 (diff)
Added by Katja Luther over 2 years ago

fix #5971: move admin menu in front of Help

Revision 5de23116 (diff)
Added by Andreas Müller over 2 years ago

fix #5971 fix NPE for not existing preference

History

#1 Updated by Andreas Müller almost 3 years ago

  • Description updated (diff)
  • Priority changed from New to Highest

#2 Updated by Andreas Müller almost 3 years ago

#3 Updated by Andreas Müller almost 3 years ago

  • Target version changed from Unassigned CDM tickets to Release 4.4
  • Estimated time set to 3.00 h

#4 Updated by Katja Luther almost 3 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 70

Now it is implemented on editor side, we need the update of the CdmPreference table (allowOverride) to complete it (see #5970)

#5 Updated by Katja Luther almost 3 years ago

  • Assignee changed from Katja Luther to Andreas Müller

#6 Updated by Andreas Müller almost 3 years ago

  • Assignee changed from Andreas Müller to Katja Luther

allowOverride #5970 is now fixed, so we can finalize this task.

#7 Updated by Andreas Müller almost 3 years ago

  • Parent task set to #6105

This is a subtask of the more general implementation described in #6105 (but more or less also a duplicate)

#8 Updated by Katja Luther over 2 years ago

Now we have a main menu admin. This menu should only be visible for admins or project manager.

#9 Updated by Katja Luther over 2 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 70 to 50

#10 Updated by Andreas Müller over 2 years ago

  • Related to bug #6215: NPE when opening preferences with no DB connection added

#11 Updated by Andreas Müller over 2 years ago

Please move the new menu in between Extras/Window and Help. Help should always be the last in the row.

#12 Updated by Andreas Müller over 2 years ago

  • Status changed from Resolved to Feedback

#13 Updated by Katja Luther over 2 years ago

  • Status changed from Feedback to Resolved

#14 Updated by Andreas Müller over 2 years ago

If no CdmPreference exists yet for nomenclatural code an NPE is thrown:

login : admin
editor version : 4.4.0.201612011150
server : test.e-taxonomy.eu / edit-test
schema version : 4.1.0.0.201607300000
os : Windows Server 2012 6.2 amd64
java : 1.7.0_65
java.lang.NullPointerException
    at eu.etaxonomy.taxeditor.preference.NomenclaturalCodePreferences.init(NomenclaturalCodePreferences.java:100)
    at org.eclipse.ui.internal.dialogs.WorkbenchPreferenceNode.createPage(WorkbenchPreferenceNode.java:57)
    at org.eclipse.jface.preference.PreferenceDialog.createPage(PreferenceDialog.java:1339)
    at org.eclipse.ui.internal.dialogs.FilteredPreferenceDialog.createPage(FilteredPreferenceDialog.java:376)
    at org.eclipse.jface.preference.PreferenceDialog.showPage(PreferenceDialog.java:1230)
    at org.eclipse.ui.internal.dialogs.FilteredPreferenceDialog.showPage(FilteredPreferenceDialog.java:674)
    at org.eclipse.jface.preference.PreferenceDialog$10.run(PreferenceDialog.java:708)
    at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
    at org.eclipse.jface.preference.PreferenceDialog$9.selectionChanged(PreferenceDialog.java:704)
    at org.eclipse.jface.viewers.StructuredViewer$3.run(StructuredViewer.java:888)
    at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
    at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
    at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
    at org.eclipse.jface.viewers.StructuredViewer.firePostSelectionChanged(StructuredViewer.java:886)
    at org.eclipse.jface.viewers.StructuredViewer.handlePostSelect(StructuredViewer.java:1226)
    at org.eclipse.jface.viewers.StructuredViewer$5.widgetSelected(StructuredViewer.java:1251)
    at org.eclipse.jface.util.OpenStrategy.firePostSelectionEvent(OpenStrategy.java:262)
    at org.eclipse.jface.util.OpenStrategy.access$5(OpenStrategy.java:256)
    at org.eclipse.jface.util.OpenStrategy$3.run(OpenStrategy.java:433)
    at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
    at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
    at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4140)

#15 Updated by Katja Luther over 2 years ago

  • Status changed from Resolved to Closed

this works now.

#16 Updated by Andreas Müller over 2 years ago

  • Private changed from Yes to No

#17 Updated by Andreas Müller about 1 year ago

  • % Done changed from 50 to 100

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)