Project

General

Profile

feature request #5752

Reduce TaxEditor size

Added by Andreas Müller over 4 years ago. Updated about 1 month ago.

Status:
Closed
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
05/24/2016
Due date:
% Done:

100%

Severity:
normal

Description

There are many places where the Editor code needs to be cleaned up in terms of real dependencies and code which links to dependencies but is not necessary.

Most important issue is to keep only 1 instance of cdmlib-remote-webapp. Currently there is 1 instance in taxeditor.cdmlib and 1 in taxeditor.remote-webapp.

Also important to reduce the dependencies in taxeditor.cdmlib. With using only remoting from now on, we do not need most of the cdmlib-dependencies anymore. This will reduce the current size of libraries of 120MB tremendously.

Further tasks are to clean up all poms and Manifest.MFs (see also #5530) etc.

Idea from #967: Split the cdmlib plugin into two plugins: One for cdmlib dependencies and one for taxeditor-only dependencies


Related issues

Related to Edit - bug #7306: No initial default classification is created when creating a new data source New 03/09/2018
Related to Edit - task #9119: Remove schema create and schema update functionality from datsource view Closed 07/02/2020
Related to Edit - task #9189: Move datasource view to taxeditor.webapp Resolved 08/13/2020
Copied to Edit - feature request #9154: Further reduce TaxEditor size by cleaning up dependencies and making taxeditor.webapp plugin optional New 07/15/2020

Associated revisions

Revision 5fbf2e5f (diff)
Added by Patrick Plitzner over 3 years ago

ref #5752 cleanup dependencies in taxeditor.cdmlib

Revision 3fe30969 (diff)
Added by Patrick Plitzner over 3 years ago

ref #5752 cleanup dependencies in taxeditor.cdmlib Part 2

Revision 78204354 (diff)
Added by Patrick Plitzner over 3 years ago

ref #5752 cleanup dependencies in taxeditor.cdmlib Part 3

Revision 11724b00 (diff)
Added by Patrick Plitzner over 3 years ago

ref #5752 cleanup dependencies in taxeditor.cdmlib Part 4

Revision 889bde96 (diff)
Added by Patrick Plitzner over 3 years ago

ref #5752 revert last 3 "cleanup dependencies in taxeditor.cdmlib"

Revision d4547dee (diff)
Added by Patrick Plitzner over 3 years ago

ref #5752 wrap specific exception to avoid dependency on lucene library

Revision 353af88b (diff)
Added by Patrick Plitzner over 3 years ago

ref #5752 Fix dependencies for integration tests

Revision 9035b51e (diff)
Added by Patrick Plitzner over 3 years ago

ref #5752 Remove jars from lib folder

Revision 3ca8a283 (diff)
Added by Patrick Plitzner over 3 years ago

ref #5752 wrap lucene exception for name and occurrence service

Revision da12936b (diff)
Added by Patrick Plitzner over 3 years ago

ref #5752 Adapt implementations to new wrapper for lucene exceptions

Revision 392d2a8d (diff)
Added by Patrick Plitzner over 3 years ago

ref #5752 Thin out feature.platform dependencies

  • also gets rid of "Run" menu

Revision 7c961a96 (diff)
Added by Patrick Plitzner over 3 years ago

ref #5752 Add missing dependency

Revision d4e83e37 (diff)
Added by Patrick Plitzner over 3 years ago

ref #5752 Re-add dependencies needed for creating a new data model

Revision 1fd65fb3 (diff)
Added by Andreas Müller 3 months ago

remove xstream and dependencies xpp3(_min) and xmlpull from taxeditor.cdmlib plugin

Revision 439eb660 (diff)
Added by Andreas Müller 3 months ago

remove mysql-connector-java from taxeditor-cdmlib

Revision 5cd207e3 (diff)
Added by Andreas Müller 3 months ago

update mysql-connector to 8.0.20 in taxeditor-webapp

Revision 93381d65 (diff)
Added by Andreas Müller 3 months ago

ref #5752 remove cdmlib-remote-webapp.war from taxeditor.cdmlib

Revision 096d7d2f (diff)
Added by Andreas Müller 3 months ago

ref #5752 remove cdmlib-remote-webapp.war from taxeditor.cdmlib (cont.)

Revision ae1769f4 (diff)
Added by Andreas Müller 3 months ago

ref #5752 remove cdmlib-remote-webapp.war from taxeditor.cdmlib (cont.)

Revision c38b8384 (diff)
Added by Andreas Müller 3 months ago

ref #5752 remove easymock-2.3, easymockclassextension-2.3, h2-1.4.190, h2mig_pagestore_addon, hsqldb-2.3.3, junit-benchmarks-0.7.2, ognl-2.6.9, yip-controller-api-redist from taxeditor.cdmlib

Revision e2f6663b (diff)
Added by Andreas Müller 3 months ago

ref #5752 add h2-1.4.200 to taxeditor.test

Revision 773143f9 (diff)
Added by Andreas Müller 3 months ago

ref #5752 use taxeditor.webapp cdmlib-remote-webapp.war for taxeditor tests

Revision 6fa33238 (diff)
Added by Andreas Müller 3 months ago

ref #5752 remove javax.servlet-api and spring-webmvc

Revision e7ffaed2 (diff)
Added by Andreas Müller 3 months ago

ref #5752 remove spring-modules-cache and dependeny concurrent-1.3.4

Revision ab49c2fa (diff)
Added by Andreas Müller 3 months ago

ref #5752 remove spring-security-web

Revision bd41d7a4 (diff)
Added by Andreas Müller 3 months ago

ref #5752 remove spring-security-oauth2 including jackson-mapper-asl and jackson-core-asl

Revision b31e1c21 (diff)
Added by Andreas Müller 3 months ago

ref #5752 remove dozer-5.3.0

Revision 7536e2e2 (diff)
Added by Andreas Müller 3 months ago

ref #5752 remove hibernate-cglib-repack-2.1_3, hibernate-ehcache-5.0.7.Final

Revision e5a23c6b (diff)
Added by Andreas Müller 3 months ago

ref #5752 remove xom and springfox-swagger-common-2.3.1 and springfox-swagger2-2.3.1

Revision ea24519c (diff)
Added by Andreas Müller about 1 month ago

ref #5752 reattache H2 to TaxEditor dependencies

History

#1 Updated by Andreas Müller over 4 years ago

  • Assignee changed from p.plitzner - to Andreas Müller
  • Target version changed from Unassigned CDM tickets to Release 4.1
  • Priority changed from New to Highest

#2 Updated by Andreas Müller over 4 years ago

  • Target version changed from Release 4.1 to Release 4.2

#3 Updated by Andreas Müller about 4 years ago

  • Target version changed from Release 4.2 to Release 4.3

#4 Updated by Andreas Müller about 4 years ago

  • Target version changed from Release 4.3 to Release 4.4

#5 Updated by Andreas Müller almost 4 years ago

  • Target version changed from Release 4.4 to Release 4.5

#6 Updated by Andreas Müller over 3 years ago

  • Target version changed from Release 4.5 to Release 4.6

#7 Updated by Patrick Plitzner over 3 years ago

  • Description updated (diff)
  • Status changed from New to In Progress
  • Assignee changed from Andreas Müller to Patrick Plitzner
  • Target version changed from Release 4.6 to Release 4.7

#8 Updated by Patrick Plitzner over 3 years ago

With the commit taxeditor|d4e83e37febf32601f065390770060398ec63a80. I re-added the dependencies needed for creating a fresh, new data model for an empty data source.
These dependencies can be removed when we moved this functionality completely to the server side

#9 Updated by Andreas Müller over 3 years ago

  • Target version changed from Release 4.7 to Release 4.8
  • Private changed from Yes to No

#10 Updated by Andreas Müller about 3 years ago

  • Target version changed from Release 4.8 to Release 4.9

#11 Updated by Andreas Müller about 3 years ago

  • Target version changed from Release 4.9 to Release 4.10

#12 Updated by Andreas Müller about 3 years ago

  • Target version changed from Release 4.10 to Release 4.12

#13 Updated by Andreas Müller almost 3 years ago

  • Target version changed from Release 4.12 to Release 4.13

#14 Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 4.13 to Release 4.14

#15 Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 4.14 to Release 5.0

#16 Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 5.0 to Release 5.1

#17 Updated by Patrick Plitzner over 2 years ago

  • Related to bug #7306: No initial default classification is created when creating a new data source added

#18 Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 5.1 to Release 5.2

#19 Updated by Andreas Müller about 2 years ago

  • Target version changed from Release 5.2 to Release 5.3

#21 Updated by Patrick Plitzner about 2 years ago

  • Description updated (diff)

#22 Updated by Patrick Plitzner about 2 years ago

  • Target version changed from Release 5.3 to Release 5.4

#23 Updated by Patrick Plitzner almost 2 years ago

  • Target version changed from Release 5.4 to Release 5.5

#24 Updated by Patrick Plitzner almost 2 years ago

  • Target version changed from Release 5.5 to Release 5.6

#25 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.6 to Reviewed Next Major Release

#26 Updated by Andreas Müller 10 months ago

  • Assignee changed from Patrick Plitzner to Katja Luther

#27 Updated by Andreas Müller 3 months ago

  • Related to task #9119: Remove schema create and schema update functionality from datsource view added

#28 Updated by Andreas Müller 2 months ago

  • Target version changed from Reviewed Next Major Release to Release 5.18

cdmlib-remote-webapp is now removed from taxeditor.cdmlib which reduces the size of TaxEditor about 115 MB

#29 Updated by Andreas Müller 2 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Many improvements have been done in this ticket. For further improvements a follow up ticket exists: #9154

Open issue is still to reattache H2 and PostGreSQL drivers as they are needed for database view edit dialog for testing the connection or find a better solution for testing. Datasource view could be moved to taxeditor.webapp as it is only relevant together with it.

#30 Updated by Andreas Müller 2 months ago

  • Subject changed from Clean up Editor dependencies to Reduce TaxEditor size

#31 Updated by Andreas Müller 2 months ago

  • Copied to bug #9145: Add sources to E+M IPNI distribution data added

#32 Updated by Andreas Müller 2 months ago

  • % Done changed from 0 to 80

#33 Updated by Andreas Müller 2 months ago

  • Copied to feature request #9154: Further reduce TaxEditor size by cleaning up dependencies and making taxeditor.webapp plugin optional added

#34 Updated by Andreas Müller 2 months ago

  • Copied to deleted (bug #9145: Add sources to E+M IPNI distribution data)

#35 Updated by Andreas Müller about 1 month ago

  • Description updated (diff)

#36 Updated by Andreas Müller about 1 month ago

  • Related to task #9189: Move datasource view to taxeditor.webapp added

#37 Updated by Andreas Müller about 1 month ago

  • Assignee changed from Andreas Müller to Katja Luther

Can you please review if you think all up-to-now changes (removing of dependencies etc) are ok. I think you do not need to review Patricks changes from 3 years ago as they are in production mode for long time, now.

There is a follow-up ticket for further size reductions.

#38 Updated by Katja Luther about 1 month ago

  • Status changed from Resolved to Closed
  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 80 to 100

I checked all removed dependencies and they are not used anyhwere and I did not get any problems while working with the editor, so I close this tickeet.

#39 Updated by Andreas Kohlbecker about 1 month ago

  • Status changed from Closed to Feedback

Can you please add a summary to the ticked description on the amount of the size reduction?
This could be valuable for later.

#40 Updated by Andreas Müller about 1 month ago

  • Status changed from Feedback to Closed

The size reduction was about 120MB. Most of it (110MB) related to the removed remote-webapp.war file in taxeditor.cdmlib. The remaining related to some dependencies that removed in taxeditor.cdmlib.

#41 Updated by Andreas Müller about 1 month ago

  • Target version changed from Release 5.18 to Release 5.17

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)