feature request #5616: Add the"Open in..." menu to taxon search - EDIT - EDIT Project Management

Custom queries

5.33
cdm-dataportal (open)
last 7 days tickets
mine in current release
phycobank
phycobank-index-closed
phycobank-registration-closed
potentially missed issues
recently updated
Release3.7
Release3.8
Release4.0
Release4.1
Release4.10
Release4.11
Release4.12
Release4.13
Release4.14
Release4.16
Release4.2
Release4.3
Release4.4
Release4.5
Release4.6
Release4.7
Release4.8
Release4.9
Release4.9
Release5.0
Release5.1
Release5.10
Release5.11
Release5.12
Release5.13
Release5.14
Release5.15
Release5.16
Release5.17
Release5.18
Release5.19
Release5.2
Release5.20
Release5.21
Release5.22
Release5.23
Release5.24
Release5.25
Release5.26
Release5.27
Release5.28
Release5.29
Release5.3
Release5.30
Release5.31
Release5.32
Release5.33
Release5.34
Release5.35
Release5.36
Release5.37
Release5.38
Release5.39
Release5.4
Release5.40
Release5.41
Release5.5
Release5.6
Release5.7
Release5.8
Release5.9
Remoting-Versions
Taxeditor-UX (Platform Etablierung)

Actions

Copy link

feature request #5616

closed

Add the"Open in..." menu to taxon search

Added by Andreas Müller about 8 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

New

Assignee:

Patrick Plitzner

Category:

taxeditor

Target version:

Release 4.3

Start date:

Due date:

% Done:

100%

Estimated time:

Severity:

normal

Description

Taxon search lists taxa and names (if name is not attached to a taxon).

So we need an open in

"Name Editor" if object is a taxon/synonym and if the (accepted) taxon belongs to a taxon node
"Taxon Bulk Editor" if object is a taxon/synonym
"Name Bulk Editor" if object is a name

So for ordinary taxa within a classification we offer 2 possibilities. The default for double click is to open the name editor. Only if this is not possible we should open the bulk editor (the later might be a separate ticket)

Updated by Patrick Plitzner about 8 years ago

Status changed from New to In Progress
Target version changed from Unassigned CDM tickets to Release 4.0

Actions

Copy link

Updated by Andreas Müller almost 8 years ago

Target version changed from Release 4.0 to Release 4.1

Actions

Copy link

Updated by Andreas Müller almost 8 years ago

Target version changed from Release 4.1 to Release 4.2

Actions

Copy link

Updated by Andreas Müller almost 8 years ago

Target version changed from Release 4.2 to Release 4.3

Actions

Copy link

Updated by Patrick Plitzner over 7 years ago

Description updated (diff)
Status changed from In Progress to Feedback
Assignee changed from Patrick Plitzner to Andreas Müller

Actions

Copy link

Updated by Andreas Müller over 7 years ago

Status changed from Feedback to Resolved

Actions

Copy link

Updated by Andreas Müller over 7 years ago

Status changed from Resolved to Feedback
Assignee changed from Andreas Müller to Patrick Plitzner
Priority changed from New to Highest
% Done changed from 0 to 70

Works fine for pure names and taxon nodes.

For orphaned taxa it should not show allow the option "open in name editor" but only "open in bulk editor"

Actions

Copy link

Updated by Patrick Plitzner over 7 years ago

Status changed from Feedback to Resolved
% Done changed from 70 to 50

Applied in changeset taxeditor:commit:taxeditor|30afcea01068a7e0dcd2bde6b9a5f28e4bbcdd6f.

Actions

Copy link

#10

Updated by Patrick Plitzner over 7 years ago

Assignee changed from Patrick Plitzner to Andreas Müller
% Done changed from 50 to 70

Actions

Copy link

#11

Updated by Andreas Müller over 7 years ago

Status changed from Resolved to Feedback
Assignee changed from Andreas Müller to Patrick Plitzner

Now it does not offer bulkeditor at all anymore, not for pure names, not for orphaned taxa and not for ordinary taxa/synonyms, but it should for all 3 of them.

Actions

Copy link

#12

Updated by Patrick Plitzner over 7 years ago

Assignee changed from Patrick Plitzner to Andreas Müller

Fixed in taxeditor:commit:taxeditor|92634d22a080f6de8af639dae12fe771cda64ceb

Actions

Copy link

#13

Updated by Andreas Müller over 7 years ago

Assignee changed from Andreas Müller to Patrick Plitzner

Better now but still some issues:

For pure names (not related to taxa) the right click menu does not show up at all anymore. Only double-click works. But even if there is only one alternative we should show a right click menu for consistency.
as mentioned above, orphaned taxa should not allow opening in name editor as the name editor can not handle them. Especially double click should not go to name editor but to bulk editor
maybe related to the later: orphaned taxa again are not shown with a special icon (brown) but with the icon for accepted taxa (black), this is misleading and should be changed back. We had the same issue a couple of month ago already so there might be a closed ticket about the issue.

Actions

Copy link

#14

Updated by Patrick Plitzner over 7 years ago

Assignee changed from Patrick Plitzner to Andreas Müller

Andreas Müller wrote:

Better now but still some issues:

For pure names (not related to taxa) the right click menu does not show up at all anymore. Only double-click works. But even if there is only one alternative we should show a right click menu for consistency.

as mentioned above, orphaned taxa should not allow opening in name editor as the name editor can not handle them. Especially double click should not go to name editor but to bulk editor

maybe related to the later: orphaned taxa again are not shown with a special icon (brown) but with the icon for accepted taxa (black), this is misleading and should be changed back. We had the same issue a couple of month ago already so there might be a closed ticket about the issue.

Fixed the last issue with the last commit but I cannot reproduce the other two issues

Actions

Copy link

#15

Updated by Andreas Müller over 7 years ago

The first issue seems to be fixed.

Handling of orphaned taxa still does not work (neither the icon nor the right click menu which should not show the name editor, but does).

Please check with taxon "Orphaned taxon" in rem_conf_am on edit-test. It shows a black icon and allows opening in name editor. Maybe this is because it has taxon relationships. But only misapplied name relationships should be handled special and should handle taxa as not orphaned.

Actions

Copy link

#16

Updated by Andreas Müller over 7 years ago

Assignee changed from Andreas Müller to Patrick Plitzner

Actions

Copy link

#17

Updated by Patrick Plitzner over 7 years ago

Andreas Müller wrote:

The first issue seems to be fixed.

Handling of orphaned taxa still does not work (neither the icon nor the right click menu which should not show the name editor, but does).

Please check with taxon "Orphaned taxon" in rem_conf_am on edit-test. It shows a black icon and allows opening in name editor. Maybe this is because it has taxon relationships. But only misapplied name relationships should be handled special and should handle taxa as not orphaned.

"Orphaned taxon" is returned as UuidAndTitleCache with the isOrphaned flag set to false. This is a service call to ITaxonService.findTaxaAndNamesForEditor().
@Andreas: Didn't you work on this a few days ago?

Actions

Copy link

#18

Updated by Patrick Plitzner over 7 years ago

Assignee changed from Patrick Plitzner to Andreas Müller

Actions

Copy link

#19

Updated by Katja Luther over 7 years ago

The problem seems to be in the calculation of the orphan value. A taxon is only orphaned when it is not used in a classification or in a taxon relationship. synonyms never are orphaned.

We have to have a look at this query.

Actions

Copy link

#20

Updated by Andreas Müller over 7 years ago

Katja Luther wrote:

The problem seems to be in the calculation of the orphan value. A taxon is only orphaned when it is not used in a classification or in a taxon relationship. synonyms never are orphaned.

We have to have a look at this query.

An update will come with the model change merge (probably today). Let's check again afterwards.

Actions

Copy link

#21

Updated by Andreas Müller over 7 years ago

Katja Luther wrote:

The problem seems to be in the calculation of the orphan value. A taxon is only orphaned when it is not used in a classification or in a taxon relationship. synonyms never are orphaned.

We have to have a look at this query.

OK, this seems to be the reason. I can see in Taxon.class that isOrphaned is implemented such. New ticket #6220 to handle this more correctly.

Actions

Copy link

#22