Project

General

Profile

feature request #5575

DNA Sample requires CacheStrategy

Added by Andreas Müller over 5 years ago. Updated 4 months ago.

Status:
Closed
Priority:
Priority14
Category:
cdmlib
Target version:
Start date:
02/18/2016
Due date:
% Done:

100%

Severity:
normal

Description

What exactly do we want to have in a generic DnaSample Cache Strategy? Is it possible to have a common strategy? A pure DNA Sample only derived from field unit may have different requirements than a sample in a full derivation hierarchy.

Discuss with users: #4585

See also #5573 and #5581


Related issues

Related to Edit - feature request #7612: CacheStrategy for MediaSpecimens Duplicate 07/31/2018
Related to Edit - task #9455: Merge DnaSample and DerivedUnit New 02/05/2021
Related to Edit - task #9595: Use DerivedUnit or DnaSample for DnaSampleGeneralDetailElement Closed 04/29/2021
Related to Edit - task #9678: Remove Derived- and FieldUnitFacadeCacheStrategies Closed 06/25/2021

Associated revisions

Revision a30452ad (diff)
Added by Andreas Müller 10 months ago

ref #5575 add first version of DnaSample cache strategy

Revision 493cdee0 (diff)
Added by Andreas Müller 9 months ago

ref #5575 refactor initialization of cache strategy (initialize when needed, not in constructor)

Revision 05f06f64 (diff)
Added by Andreas Müller 9 months ago

ref #9443, ref #5575 tissue sample as DnaSample generation and initialization of DNA sample cache strategies

Revision e651eaf3 (diff)
Added by Andreas Müller 6 months ago

ref #7612, ref #5573, ref #5575 use mostSignificantIdentifier instead of accession number only

Revision 8aaabf50 (diff)
Added by Andreas Müller 6 months ago

ref #9595 , ref #5575 use DnaSampleCacheStrategy in DerivateLabelProvider

History

#1 Updated by Andreas Müller 10 months ago

#2 Updated by Andreas Müller 10 months ago

  • Description updated (diff)
  • Private changed from Yes to No

#3 Updated by Andreas Müller 10 months ago

  • Status changed from New to In Progress
  • Priority changed from New to Priority14
  • Target version changed from Unassigned CDM tickets to Release 5.19
  • % Done changed from 0 to 30

I added a very first version for DNASample cache strategy to avoid the -titleCache not availble- messages

#4 Updated by Andreas Müller 9 months ago

  • Target version changed from Release 5.19 to Release 5.21

As TissueSample are currently still handled as DnaSample modellwise (to allow adding of sequences directly without DnaSample intermediate) we need to distinguish the correct CacheStrategy depending on the SpecimenOrObservationType. This can only be done after constructing the object as otherwise the type has not been filled by hibernate yet for persistent objects.

Therefore I refactored the initialization of cache strategies in the way that they are only loaded when needed: 493cdee0c5

#5 Updated by Andreas Müller 9 months ago

  • Related to task #9455: Merge DnaSample and DerivedUnit added

#6 Updated by Andreas Müller 9 months ago

  • Status changed from In Progress to Resolved

#7 Updated by Andreas Müller 9 months ago

  • Target version changed from Release 5.21 to Release 5.20

#8 Updated by Andreas Müller 6 months ago

  • Related to task #9595: Use DerivedUnit or DnaSample for DnaSampleGeneralDetailElement added

#9 Updated by Andreas Müller 6 months ago

  • Target version changed from Release 5.20 to Release 5.25

#10 Updated by Andreas Müller 6 months ago

  • Status changed from Resolved to Feedback

The initialization of the cache strategy does not seem to fully work yet. See comment in #9595#note-2

#11 Updated by Andreas Müller 5 months ago

  • Target version changed from Release 5.25 to Release 5.23

#12 Updated by Andreas Müller 5 months ago

  • % Done changed from 30 to 80

#13 Updated by Andreas Müller 4 months ago

  • Related to task #9678: Remove Derived- and FieldUnitFacadeCacheStrategies added

#14 Updated by Andreas Müller 4 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 80 to 100

Not sure if this is already fully fixed but it needs to be adapted/tested anyway once we unify DnaSample with DerivedUnit class. Also we have an explicit DerivedUnitDefaultCacheStrategy now (#9678) which may improve the situation with cache strategy loading.

So for now I close this ticket.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)