Project

General

Profile

bug #4944

task #4338: [MASTER] Handle abbreviated title and protected cache correctly in TaxEditor

"Protected" indication for references needs to be improved

Added by Andreas Müller almost 6 years ago. Updated 3 months ago.

Status:
Resolved
Priority:
Priority13
Assignee:
Category:
taxeditor
Target version:
Start date:
05/28/2015
Due date:
% Done:

0%

Severity:
normal
Found in Version:

Description

There are some issues with the orange coloring which indicates that a cache is protected in the reference details view.

  1. Generally the reference type is never orange though it should whenever a cache is protected

  2. If the reference cache is protected the "Abbrev cache" and the "Abbrev title" should not be orange as these fields are not primarily made invisible by the protection of the title cache (for discussion see also #4915)

  3. If both caches are protected and then one cache is toggled to unprotect only 2-3 fields stay orange. This is inconsistent with the state when you have both caches unprotected on switch to one field being protected. The same protection state should always result in the same state of colored fields. This can easily be reached by having one method that computes the coloring and that is always called when any of the protection states are changing or when a new object is loaded (a similar behavior has been observed for names: #3737)

  4. Related to the above we may think about different colors for the 3 states "titleCache protected", "abbrevCache protected", "both protected"

  5. We may think about not having the "Reference Abstract" orange as nobody will expect that the abstract will go into the caches

The following is a split from #3561: [DISCUSS] If only Reference Cache or only Abbrev Title Cache are protected how should the other fields be coloured? E.g. should the author be coloured organge? YES because cache 1 is protected, NO because cache 2 is not protected.

closely related to #4915


Related issues

Related to Edit - bug #9405: Fields set to irrelevant for cache should be set by state only Closed 01/20/2021
Related to Edit - feature request #9417: Advanced issues for cache relevance handling New 01/23/2021

Associated revisions

Revision 202edbff (diff)
Added by Andreas Müller 3 months ago

ref #9405 , ref #4944 refactor the cache protection indication handling in TaxEditor details view elements

Revision c3b6d097 (diff)
Added by Andreas Müller 3 months ago

ref #9405 , ref #4944 fix NPE in CacheRelevanceHelper

Revision 5014c22f (diff)
Added by Andreas Müller about 1 month ago

ref #9405, ref #4944 adapt colors for cache protected fields a bit

History

#1 Updated by Andreas Müller almost 6 years ago

  • Target version set to Release 3.7
  • Priority changed from New to Priority13

#2 Updated by Andreas Müller over 5 years ago

  • Target version changed from Release 3.7 to Release 3.8

#3 Updated by Andreas Kohlbecker over 5 years ago

  • Target version deleted (Release 3.8)

moving unresolved tickets to next milestone after release of 3.8.0

#4 Updated by Katja Luther over 5 years ago

  • Status changed from New to Resolved
  • Assignee changed from k.luther - to Andreas Müller

adapted the colouring for all cache relevant parts (taxon, name, reference r26363)

@AM: Please have a look if everything works like expected.

I think we should have two or better three different colours. I will put this in another ticket.

#5 Updated by Andreas Müller 3 months ago

  • Description updated (diff)
  • Private changed from Yes to No

#6 Updated by Andreas Müller 3 months ago

  • Related to bug #9405: Fields set to irrelevant for cache should be set by state only added

#8 Updated by Andreas Müller 3 months ago

  • Assignee changed from Andreas Müller to Katja Luther

with implementation of #9405 this should be fully fixed now. Please review with new implementation.

The following is a split from #3561: [DISCUSS] If only Reference Cache or only Abbrev Title Cache are protected how should the other fields be coloured? E.g. should the author be coloured organge? YES because cache 1 is protected, NO because cache 2 is not protected.

This should also be fixed now with possibility of using 3 different colors.

#9 Updated by Andreas Müller 3 months ago

#10 Updated by Andreas Müller 3 months ago

#11 Updated by Andreas Müller 3 months ago

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)