Project

General

Profile

Actions

bug #4944

closed

task #4338: [MASTER] Handle abbreviated title and protected cache correctly in TaxEditor

"Protected" indication for references needs to be improved

Added by Andreas Müller over 7 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Priority13
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

50%

Estimated time:
Severity:
normal
Found in Version:

Description

There are some issues with the orange coloring which indicates that a cache is protected in the reference details view.

  1. Generally the reference type is never orange though it should whenever a cache is protected

  2. If the reference cache is protected the "Abbrev cache" and the "Abbrev title" should not be orange as these fields are not primarily made invisible by the protection of the title cache (for discussion see also #4915)

  3. If both caches are protected and then one cache is toggled to unprotect only 2-3 fields stay orange. This is inconsistent with the state when you have both caches unprotected on switch to one field being protected. The same protection state should always result in the same state of colored fields. This can easily be reached by having one method that computes the coloring and that is always called when any of the protection states are changing or when a new object is loaded (a similar behavior has been observed for names: #3737)

  4. Related to the above we may think about different colors for the 3 states "titleCache protected", "abbrevCache protected", "both protected"

  5. We may think about not having the "Reference Abstract" orange as nobody will expect that the abstract will go into the caches

The following is a split from #3561: [DISCUSS] If only Reference Cache or only Abbrev Title Cache are protected how should the other fields be coloured? E.g. should the author be coloured organge? YES because cache 1 is protected, NO because cache 2 is not protected.

closely related to #4915


Related issues

Related to EDIT - bug #9405: Fields set to irrelevant for cache should be set by state onlyClosedAndreas Müller

Actions
Related to EDIT - bug #4915: Abbrev title for person should never be orangeClosedAndreas Müller

Actions
Related to EDIT - feature request #9417: Advanced issues for cache relevance handlingNewAndreas Müller

Actions
Actions #1

Updated by Andreas Müller over 7 years ago

  • Target version set to Release 3.7
  • Priority changed from New to Priority13
Actions #2

Updated by Andreas Müller over 7 years ago

  • Target version changed from Release 3.7 to Release 3.8
Actions #3

Updated by Andreas Kohlbecker over 7 years ago

  • Target version deleted (Release 3.8)

moving unresolved tickets to next milestone after release of 3.8.0

Actions #4

Updated by Katja Luther about 7 years ago

  • Status changed from New to Resolved
  • Assignee changed from k.luther - to Andreas Müller

adapted the colouring for all cache relevant parts (taxon, name, reference r26363)

@AM: Please have a look if everything works like expected.

I think we should have two or better three different colours. I will put this in another ticket.

Actions #5

Updated by Andreas Müller about 2 years ago

  • Description updated (diff)
  • Private changed from Yes to No
Actions #6

Updated by Andreas Müller about 2 years ago

  • Related to bug #9405: Fields set to irrelevant for cache should be set by state only added
Actions #7

Updated by Andreas Müller about 2 years ago

  • Related to bug #4915: Abbrev title for person should never be orange added
Actions #8

Updated by Andreas Müller about 2 years ago

  • Assignee changed from Andreas Müller to Katja Luther

with implementation of #9405 this should be fully fixed now. Please review with new implementation.

The following is a split from #3561: [DISCUSS] If only Reference Cache or only Abbrev Title Cache are protected how should the other fields be coloured? E.g. should the author be coloured organge? YES because cache 1 is protected, NO because cache 2 is not protected.

This should also be fixed now with possibility of using 3 different colors.

Actions #9

Updated by Andreas Müller about 2 years ago

Actions #10

Updated by Andreas Müller about 2 years ago

Actions #11

Updated by Andreas Müller about 2 years ago

Actions #12

Updated by Andreas Müller over 1 year ago

  • % Done changed from 0 to 50
Actions #13

Updated by Katja Luther 11 months ago

  • Status changed from Resolved to Closed

This works now.

Actions

Also available in: Atom PDF