Project

General

Profile

Actions

bug #4915

closed

task #4338: [MASTER] Handle abbreviated title and protected cache correctly in TaxEditor

Abbrev title for person should never be orange

Added by Andreas Müller about 7 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Priority10
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:

Description

the abbreviated title of a person should never become orange as it is not a cache field. However it sometimes becomes orange.

What I did:

  • Open Person or Team Bulk editor

  • create new Person (right click New-Author) => the new person is shown with protected white title cache and white abbrev. title

  • do any change in title cache => the abbrev. title becomes orange !!

You may go further and unprotect the title cache => everything becomes white and then protect it and again everything incluging abbrev title becomes orange

related to #4944, for general implementation issues see there.

see also #4912


Related issues

Related to EDIT - bug #4944: "Protected" indication for references needs to be improvedClosedKatja Luther

Actions
Related to EDIT - bug #9405: Fields set to irrelevant for cache should be set by state onlyClosedAndreas Müller

Actions
Related to EDIT - feature request #9417: Advanced issues for cache relevance handlingNewAndreas Müller

Actions
Actions #1

Updated by Andreas Müller about 7 years ago

  • Target version deleted ()
  • Priority changed from Priority08 to Priority10
Actions #2

Updated by Katja Luther about 7 years ago

the abbrev title is used for the titleCache if no lastname is available so if the cachestrategy is correct the orange colour is correct, too, or not?

Actions #3

Updated by Andreas Müller about 7 years ago

It is true, that if long and abbreviated forms exist these 2 forms always are the fallback if no real atomized data exist. This is e.g. is the case for Teams too.

However, for me the semantics of orange is more indicating that these fields are REPLACED by the protected cache field and e.g other objects referring to the field will not depend on having these fields filled.

This is definitely not the case for the abbrev field which holds important and independent information and the fallback is only a solution to avoid empty caches for dirty data.

Therefore I would always keep title cache and abbrev cache independent in terms of orange.

NOTE: By the way we do have a similar issue for teams but it appears only after unprotecting and reprotecting the field which is inconsistent behavior anyway. Maybe you can fix this, too.

Actions #4

Updated by Andreas Müller about 7 years ago

  • Target version set to Release 3.7
Actions #5

Updated by Andreas Müller about 7 years ago

  • Target version changed from Release 3.7 to Release 3.8
Actions #6

Updated by Andreas Kohlbecker almost 7 years ago

  • Target version deleted (Release 3.8)

moving unresolved tickets to next milestone after release of 3.8.0

Actions #7

Updated by Katja Luther almost 7 years ago

  • Status changed from New to Resolved
  • Assignee changed from k.luther - to Andreas Müller

fixing with r26363

Actions #8

Updated by Andreas Müller over 1 year ago

  • Related to bug #4944: "Protected" indication for references needs to be improved added
Actions #9

Updated by Andreas Müller over 1 year ago

  • Related to bug #9405: Fields set to irrelevant for cache should be set by state only added
Actions #10

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 50

This should also be fully fixed with #9405 being implemented. Please review again as the frameworks has been fully refactored.

Actions #11

Updated by Andreas Müller over 1 year ago

Actions #12

Updated by Andreas Müller over 1 year ago

Actions #13

Updated by Andreas Müller over 1 year ago

Actions #14

Updated by Andreas Müller 5 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 50 to 100

I guess this can be closed. I never observed an orange person titleCache field since the reimplementation.

Actions #15

Updated by Andreas Müller 5 months ago

  • Private changed from Yes to No
Actions

Also available in: Atom PDF