Project

General

Profile

Actions

bug #4821

closed

Changing order of terms not possible

Added by Andreas Müller almost 7 years ago. Updated 3 months ago.

Status:
Closed
Priority:
Priority12
Assignee:
Category:
taxeditor
Target version:
Start date:
04/29/2015
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:

Description

When trying to change the order of an ordered term vocabulary (e.g. Presence Absence Term) by moving an existing term in between 2 other terms the term is added as a child to the above term instead of just changing the order.


Related issues

Related to Edit - bug #5684: NPE when trying to move a presence-absence term within the vocabularyWorksformeAndreas Müller

Actions
Precedes Edit - bug #6343: TermVocabularies of OrderedTerms must be OrderedVocabulariesIn ProgressAndreas Müller01/18/2017

Actions
Actions #1

Updated by Andreas Müller over 6 years ago

  • Target version deleted ()
  • Priority changed from Priority08 to Priority12
Actions #2

Updated by Cherian Mathew over 6 years ago

  • Status changed from New to Resolved
  • Assignee changed from c.mathew - to Andreas Müller

Added possibility to change order for ordered terms, disabled insert feedback for non ordered terms and added sorting of ordered terms based on order index (descending) - r23988

Actions #3

Updated by Andreas Müller over 6 years ago

  • Assignee changed from Andreas Müller to c.mathew -
  • Target version changed from TaxEditor RELEASE 3.6.0 to Release 3.7

When moving a term the predecessor term is completely removed from the vocabulary on my machine (windows using release 3.6.0).

This also happens on non ordered terms/vocabularies sometimes.

Actions #4

Updated by Andreas Müller about 6 years ago

  • Assignee changed from c.mathew - to k.luther -
  • Target version changed from Release 3.7 to Release 3.12

As Cherian won't have time to work on this I switch owner

Actions #5

Updated by Katja Luther about 6 years ago

the removing of the term in ordered vocabularies are now fixed. r26743

and for the not ordered terms r26744

Actions #6

Updated by Katja Luther about 6 years ago

  • Assignee changed from k.luther - to Andreas Müller
Actions #7

Updated by Andreas Müller over 5 years ago

  • Assignee changed from Andreas Müller to k.luther -

The term still disappears if I try to move it. Reappears at old possition after reconnect.

What I did:

  • created a new vocabulary for NamedArea

  • Added 3 areas as direct children

  • Reconnected (to be on the save side that everything is saved and refreshed)

  • Via drag&drop moved the 3 area in the list to the second position

  • => it disappeared

  • saved

  • closed and opening the term editor did not change anything

  • reconnected

  • => the term reappeared but at the old position

Actions #8

Updated by Katja Luther about 5 years ago

  • Description updated (diff)

This is because the new created vocabulary is not of the type OrderedTermVocabulary.

Actions #9

Updated by Katja Luther about 5 years ago

  • % Done changed from 0 to 50
Actions #10

Updated by Andreas Müller about 5 years ago

Should I review or are there still open aspects?

Actions #11

Updated by Andreas Müller about 5 years ago

  • Precedes bug #6343: TermVocabularies of OrderedTerms must be OrderedVocabularies added
Actions #12

Updated by Katja Luther about 5 years ago

  • Assignee changed from Katja Luther to Andreas Müller

Yes, please review.

Actions #13

Updated by Andreas Müller about 5 years ago

  • Related to bug #5684: NPE when trying to move a presence-absence term within the vocabulary added
Actions #14

Updated by Patrick Plitzner about 3 years ago

review ping

Actions #15

Updated by Andreas Müller about 3 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

For ordered terms it seems to work now (though there are other issues but they will be handled in another ticket).
For unordered terms it is only possible to make them children. This is correct behavior but then we should remove the drag possiblity for in-between drag maybe to make clear that this is not possible.

Actions #16

Updated by Andreas Müller almost 2 years ago

  • Assignee changed from Patrick Plitzner to Katja Luther
Actions #17

Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
Actions #18

Updated by Katja Luther 3 months ago

Andreas Müller wrote:

For ordered terms it seems to work now (though there are other issues but they will be handled in another ticket).
For unordered terms it is only possible to make them children. This is correct behavior but then we should remove the drag possiblity for in-between drag maybe to make clear that this is not possible.

this is fixed now.

Actions #19

Updated by Katja Luther 3 months ago

  • Assignee changed from Katja Luther to Andreas Müller

please review

Actions #20

Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 100

Can be closed.

Actions #21

Updated by Andreas Müller 3 months ago

  • Private changed from Yes to No
Actions

Also available in: Atom PDF