Project

General

Profile

Actions

feature request #3836

closed

Implement modifiers and modifying text for Description Elements in TaxEditor

Added by Andreas Müller about 9 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Priority14
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

but not for TextData as we expect that TextData will handle modifiers with its text.

see also #3746

Only the recommended modifiers should be shown for the given feature (Feature.recommendedModifierEnumeration)


Related issues

Related to EDIT - feature request #3746: Implement time period scope for description elements in TaxEditorClosedKatja Luther

Actions
Related to EDIT - feature request #3747: Check if time period is handled correctly for description elements in data portals ClosedAndreas Kohlbecker

Actions
Related to EDIT - feature request #8144: Check if modifiers and modifyingText is handled correctly for description elements in data portals NewAndreas Kohlbecker

Actions
Related to EDIT - feature request #8226: make modifiers for description elements configurableClosedKatja Luther

Actions
Related to EDIT - feature request #8236: [DISCUSS] Should recommended modifiers also hold for DescriptionElementsNewAndreas Müller

Actions
Actions #1

Updated by Andreas Müller over 4 years ago

  • Description updated (diff)
  • Assignee changed from Cherian Mathew to Katja Luther
  • Target version changed from TaxEditor Next Major Release to Unassigned CDM tickets
Actions #2

Updated by Andreas Müller over 4 years ago

  • Private changed from Yes to No
Actions #3

Updated by Andreas Müller over 4 years ago

  • Related to feature request #3746: Implement time period scope for description elements in TaxEditor added
Actions #4

Updated by Andreas Müller over 4 years ago

  • Related to feature request #3747: Check if time period is handled correctly for description elements in data portals added
Actions #5

Updated by Andreas Kohlbecker almost 4 years ago

  • Subject changed from Implement modifiers and modifying text for Description Elements to Implement modifiers and modifying text for Description Elements in TaxEditor
Actions #6

Updated by Andreas Kohlbecker almost 4 years ago

  • Related to feature request #8144: Check if modifiers and modifyingText is handled correctly for description elements in data portals added
Actions #7

Updated by Andreas Müller almost 4 years ago

  • Target version changed from Unassigned CDM tickets to Release 5.6

As we have decided to check for old unimplemented model issues in this version I add it to current milestone. But we may discuss if this makes sense.

Actions #8

Updated by Katja Luther over 3 years ago

  • Priority changed from New to Priority14
Actions #9

Updated by Katja Luther over 3 years ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

This is implemented now, please review

Actions #10

Updated by Andreas Müller over 3 years ago

  • Assignee changed from Andreas Müller to Patrick Plitzner

please do first review on nightly

Actions #11

Updated by Patrick Plitzner over 3 years ago

  • Assignee changed from Patrick Plitzner to Andreas Müller

Tested on nightly:

  • Created a specimen description element and set modifier and Modifying text
  • Closed and re-opened, re-connected and everything was stored correctly
  • TextData like e.g. citation do not have modifiers
Actions #12

Updated by Andreas Müller over 3 years ago

  • Description updated (diff)
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Only the recommended modifiers should be shown for the given feature (Feature.recommendedModifierEnumeration) - sorry this requirement was missing in the initial description.

Also for some reason when editing a feature in term editor currently it is not possible to edit the recommended modifiers. Patrick, is this maybe a regression from additivity?

Actions #13

Updated by Andreas Müller over 3 years ago

We may also discuss if the modifiers should only be shown if the recommended modifier enumeration is not empty.

Also we may want to make modifers configurable (show only if switched on) as some projects may consider them as not necessary.

But these might be issues of a new ticket.

Actions #14

Updated by Katja Luther over 3 years ago

Andreas Müller wrote:

Only the recommended modifiers should be shown for the given feature (Feature.recommendedModifierEnumeration) - sorry this requirement was missing in the initial description.

Also for some reason when editing a feature in term editor currently it is not possible to edit the recommended modifiers. Patrick, is this maybe a regression from additivity?

This is only possible for categorical data and quantitative data and for these the drop down is filled with the recommended modifiers, if no recommended modifiers exist all modifiers from Vocabulary Modifier are loaded.

Actions #15

Updated by Katja Luther over 3 years ago

Andreas Müller wrote:

We may also discuss if the modifiers should only be shown if the recommended modifier enumeration is not empty.

Also we may want to make modifers configurable (show only if switched on) as some projects may consider them as not necessary.

But these might be issues of a new ticket.

created new ticket #8226

Actions #16

Updated by Katja Luther over 3 years ago

Actions #17

Updated by Katja Luther over 3 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

for description elements only the recommended modifiers are shown. configurability is moved to a new ticket.

Actions #18

Updated by Katja Luther over 3 years ago

  • % Done changed from 0 to 70
Actions #19

Updated by Andreas Müller over 3 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Katja Luther wrote:

Andreas Müller wrote:

Only the recommended modifiers should be shown for the given feature (Feature.recommendedModifierEnumeration) - sorry this requirement was missing in the initial description.

Also for some reason when editing a feature in term editor currently it is not possible to edit the recommended modifiers. Patrick, is this maybe a regression from additivity?

This is only possible for categorical data and quantitative data and for these the drop down is filled with the recommended modifiers, if no recommended modifiers exist all modifiers from Vocabulary Modifier are loaded.

Hmm, this needs to be discussed. CategoricalData and QuantitativeData have extra modifiers in StateData and StatisticalMeasurmentValue. Maybe therefore only they allow to define the recommended enumerations currently. However, for the DescriptionElements either all (except text data) or none should evaluate the enumeration.
But definetely IF we evaluate the enumeration an empty list should be handled as NO modifier available and not as All modifiers. This is because there are too many different modifier types which may not match at all.

Not sure how we handle this for this release now. We need to discuss if we need 2 different modifier enumerations for catergorical+quantitative data or if we can use the same enumeration for both places.
As we havn't really time to discuss this until release I suggeset to hide the field until we have decided. Can you open a ticket to decide how to handle the modifier enumerationsß

Actions #20

Updated by Katja Luther over 3 years ago

now the modifier section is shown only if the feature has recommended modifier voc, so it is hided for all features it is not possible to add recommended modifier vocabularies.

Actions #21

Updated by Katja Luther over 3 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
Actions #22

Updated by Andreas Müller over 3 years ago

  • Related to feature request #8236: [DISCUSS] Should recommended modifiers also hold for DescriptionElements added
Actions #23

Updated by Andreas Müller over 3 years ago

The discussion on recommended modifiers I moved to #8236.

Actions #24

Updated by Andreas Müller over 3 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Katja Luther wrote:

now the modifier section is shown only if the feature has recommended modifier voc, so it is hided for all features it is not possible to add recommended modifier vocabularies.

Only the structured modifiers may need to be hidden. The freetext modifier (modifying text) is vocabulary independent and therefore can always be shown (except for configuration via preferences that it should not be shown for UI simplification)

Actions #25

Updated by Katja Luther over 3 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

Katja Luther wrote:

now the modifier section is shown only if the feature has recommended modifier voc, so it is hided for all features it is not possible to add recommended modifier vocabularies.

Only the structured modifiers may need to be hidden. The freetext modifier (modifying text) is vocabulary independent and therefore can always be shown (except for configuration via preferences that it should not be shown for UI simplification)

this is implemented now.

Actions #26

Updated by Andreas Müller about 3 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 70 to 100

I think I tested this in the context of #8226 and I think it worked.

Actions

Also available in: Atom PDF