Edit

As we have decided to check for old unimplemented model issues in this version I add it to current milestone. But we may discuss if this makes sense.

This is implemented now, please review

please do first review on nightly

Tested on nightly:

• Created a specimen description element and set modifier and Modifying text
• Closed and re-opened, re-connected and everything was stored correctly
• TextData like e.g. citation do not have modifiers

Only the recommended modifiers should be shown for the given feature (Feature.recommendedModifierEnumeration) - sorry this requirement was missing in the initial description.

Also for some reason when editing a feature in term editor currently it is not possible to edit the recommended modifiers. Patrick, is this maybe a regression from additivity?

for description elements only the recommended modifiers are shown. configurability is moved to a new ticket.

Katja Luther wrote:

Andreas Müller wrote:

Only the recommended modifiers should be shown for the given feature (Feature.recommendedModifierEnumeration) - sorry this requirement was missing in the initial description.

Also for some reason when editing a feature in term editor currently it is not possible to edit the recommended modifiers. Patrick, is this maybe a regression from additivity?

This is only possible for categorical data and quantitative data and for these the drop down is filled with the recommended modifiers, if no recommended modifiers exist all modifiers from Vocabulary Modifier are loaded.

Hmm, this needs to be discussed. CategoricalData and QuantitativeData have extra modifiers in StateData and StatisticalMeasurmentValue. Maybe therefore only they allow to define the recommended enumerations currently. However, for the DescriptionElements either all (except text data) or none should evaluate the enumeration.
But definetely IF we evaluate the enumeration an empty list should be handled as NO modifier available and not as All modifiers. This is because there are too many different modifier types which may not match at all.

Not sure how we handle this for this release now. We need to discuss if we need 2 different modifier enumerations for catergorical+quantitative data or if we can use the same enumeration for both places.
As we havn't really time to discuss this until release I suggeset to hide the field until we have decided. Can you open a ticket to decide how to handle the modifier enumerationsß

Katja Luther wrote:

now the modifier section is shown only if the feature has recommended modifier voc, so it is hided for all features it is not possible to add recommended modifier vocabularies.

Only the structured modifiers may need to be hidden. The freetext modifier (modifying text) is vocabulary independent and therefore can always be shown (except for configuration via preferences that it should not be shown for UI simplification)

Andreas Müller wrote:

Katja Luther wrote:

now the modifier section is shown only if the feature has recommended modifier voc, so it is hided for all features it is not possible to add recommended modifier vocabularies.

Only the structured modifiers may need to be hidden. The freetext modifier (modifying text) is vocabulary independent and therefore can always be shown (except for configuration via preferences that it should not be shown for UI simplification)

this is implemented now.