Project

General

Profile

Actions

feature request #3573

closed

Improve EDITOR import UI configuration panel

Added by Cherian Mathew over 9 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Priority12
Assignee:
Patrick Plitzner
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

50%

Estimated time:
1:00 h
Severity:
normal

Description

From P.Kelbert,

Everybody know that the users don't like the configuration interface in

the Editor for importing data, as the option displayed are not clear at

all ("isdoreusetaxa" etc etc).

For the ABCD Import, I made some changes (for the moment locally), by:

1) renaming the configuration options (more explicit)

2) doing a small add in the GenericConfiguratorWizardPage (package

eu.etaxonomy.taxeditor.io.wizard), line 143.


  private void createCheckbox(Composite parent, Method method,

             final IIoConfigurator configurator) {


         final String methodName = method.getName();

         final Button checkBox = new Button(parent, SWT.CHECK);



if(configurator.getClass().equals(Abcd206ImportConfigurator.class)){

             String[[] r =|methodName.split("set")r1].split("(?=\\p{Upper})");

             checkBox.setText(getLabel(StringUtils.join(r," ")));

         }

         else{

             checkBox.setText(getLabel(methodName));

         }

         // retrieve the default values and set the checkbox accordingly

         boolean defaultSelection = 

executeBooleanGetMethod(configurator, "is"

                 + methodName.substring(3));

         checkBox.setSelection(defaultSelection);

         checkBox.addSelectionListener(new SelectionAdapter() {


             /*

* (non-Javadoc)

              *

* @see

* 

org.eclipse.swt.events.SelectionAdapter#widgetSelected(org.eclipse

* .swt.events.SelectionEvent)

              */

 @Override

 public void widgetSelected(SelectionEvent e) {

 executeBooleanSetMethod(configurator, methodName,

 checkBox.getSelection());

 }


         });


     }

In attachment, you will see the "before" and "after" pictures.

It still not the best solution, but I think it's really better than the

old display. What do you think? Could we include it for the next

release, at least for the ABCD import?

You may notice the "Interact with user" option. When it's set to True,

some pop-up are displayed when the user should take a decision, for

example for selecting an existing NamedArea when several match, entering

his own Reference Name or Classification name etc.

Any objection to add this ABCD Improvement in the next release?

Patricia

see also: #1029


Files

before.png (160 KB) before.png Cherian Mathew, 07/01/2013 10:00 AM
after.png (214 KB) after.png Cherian Mathew, 07/01/2013 10:00 AM

Related issues

Related to EDIT - feature request #6305: [MASTER] Improve EDITOR import/export UI configuration panel for all imports/exportsNewKatja Luther

Actions
Actions #1

Updated by Cherian Mathew over 9 years ago

From A.Mueller,

I definetly agree that the new assistent looks better then the old one. So lets use it.

However we urgently need to completely refactor the whole part. I don't think that creating the assistent via method names of the configurator is the right approach.

Can't we easily create a fully manually created assitent, which then also allows tooltips etc. And also it allows more then only checkboxes.

Also i18n is much easier to implement then.

I suggest to have a little meeting about this. Who is interested to take part?

Some minor notes:

1) renaming the configuration options (more explicit)

This broke some code in app-import so we should be careful with doing so (a further reason for decoupling method names from UI creation.

The new name is "reuseExistingTaxaWhenPossible"? We should discuss if this has the same semantics.

Ignore Null

doesn't make sense in the ABCD context I think. Should be removed (but is in base class !!)

Actions #2

Updated by Cherian Mathew about 9 years ago

  • Target version deleted (TaxEditor RELEASE 3.3.0)
Actions #3

Updated by Andreas Kohlbecker almost 9 years ago

  • Target version deleted ()

no release 3.3.1 of the taxeditor so I am moving all tickets to the next milestone 3.3.2

Actions #4

Updated by Andreas Müller over 8 years ago

  • Assignee changed from Patricia Kelbert to a.oppermann -
  • Target version deleted (TaxEditor RELEASE 3.3.7)
  • Priority changed from Priority08 to Priority12
Actions #5

Updated by Andreas Müller almost 8 years ago

  • Assignee changed from a.oppermann - to p.plitzner -

Hi Patrick, I think you already have worked on this a bit, therefore I change owner to you as AO won't have time to do it anymore. Can be discussed.

Actions #6

Updated by Patrick Plitzner over 6 years ago

  • Description updated (diff)
  • Status changed from New to In Progress
  • Target version changed from Reviewed Next Major Release to Release 4.4
Actions #7

Updated by Andreas Müller over 6 years ago

  • Estimated time set to 1:00 h
Actions #8

Updated by Andreas Müller over 6 years ago

  • Description updated (diff)
Actions #9

Updated by Patrick Plitzner over 6 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 50
Actions #10

Updated by Patrick Plitzner over 6 years ago

  • Assignee changed from Patrick Plitzner to Katja Luther
Actions #11

Updated by Katja Luther about 6 years ago

We should do this for all types of imports. Close this ticket and create a new one for the other imports, see #6305

Actions #12

Updated by Katja Luther about 6 years ago

  • Related to feature request #6305: [MASTER] Improve EDITOR import/export UI configuration panel for all imports/exports added
Actions #13

Updated by Katja Luther about 6 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Katja Luther to Patrick Plitzner
Actions #14

Updated by Andreas Müller about 6 years ago

  • Private changed from Yes to No
Actions

Also available in: Atom PDF